Add global handler for std::bad_alloc

These exceptions will be represented by exception code 0xE03B10C0

Author: botder

Client/cefweb/CefWeb.cpp

@@ -22,6 +22,8 @@ extern "C" _declspec(dllexport) CWebCoreInterface* InitWebCoreInterface(CCoreInt
     // Ensure main thread identification is consistent
     IsMainThread();
 
+    SetMemoryAllocationFailureHandler();
+
     CWebCore* pWebCore = new CWebCore;
     return pWebCore;
 }

Client/core/CCommandFuncs.cpp

@@ -427,6 +427,19 @@ void CCommandFuncs::Test(const char* szParameters)
             }
         }
     }
+#if defined(MTA_DEBUG) || MTASA_VERSION_TYPE == VERSION_TYPE_CUSTOM
+    else if (SStringX(szParameters) == "bad_alloc")
+    {
+        if (FileExists(CalcMTASAPath("debug.txt")))
+        {
+            while (true)
+            {
+                new int[100 * 1024 * 1024]();
+                g_pCore->GetConsole()->Print("Allocated 100 MiB");
+            }
+        }
+    }
+#endif
 }
 
 void CCommandFuncs::Serial(const char* szParameters)

Client/core/CCrashDumpWriter.cpp

@@ -291,6 +291,8 @@ void CCrashDumpWriter::DumpCoreLog(CExceptionInformation* pExceptionInformation)
 
         // For the crash dialog
         SetApplicationSetting("diagnostics", "last-crash-info", strInfo);
+        SetApplicationSetting("diagnostics", "last-crash-module", pExceptionInformation->GetModulePathName());
+        SetApplicationSettingInt("diagnostics", "last-crash-code", pExceptionInformation->GetCode());
         WriteDebugEvent(strInfo.Replace("\n", " "));
     }
 }

Client/core/Core.cpp

@@ -15,6 +15,7 @@
 #include "profiler/SharedUtil.Profiler.h"
 #define UTF8_FILE_HOOKS_PERSONALITY_Core
 #include "SharedUtil.Win32Utf8FileHooks.hpp"
+#include "SharedUtil.Memory.h"
 
 #define CORE_API extern "C" __declspec(dllexport)
 
@@ -94,6 +95,8 @@ CORE_API int InitializeCore()
 
     WriteDebugEvent(SString("ModuleFileName: %s", *GetLaunchPathFilename()));
 
+    SetMemoryAllocationFailureHandler();
+
     g_pCore = new CCore();
     return 0;
 }

Client/game_sa/gamesa_init.cpp

@@ -14,6 +14,7 @@
 #include <net/CNet.h>
 #include "gamesa_init.h"
 #include "CGameSA.h"
+#include "SharedUtil.Memory.h"
 #define DECLARE_PROFILER_SECTION_gamesa_init
 #include "profiler/SharedUtil.Profiler.h"
 
@@ -30,6 +31,8 @@ MTAEXPORT CGame* GetGameInterface(CCoreInterface* pCore)
     g_pNet = pCore->GetNetwork();
     assert(g_pNet);
 
+    SetMemoryAllocationFailureHandler();
+
     pGame = new CGameSA;
     g_pCore = pCore;
 

Client/gui/Main.cpp

@@ -31,6 +31,7 @@ MTAEXPORT CGUI* InitGUIInterface(IDirect3DDevice9* pDevice)
     // Create our GUI interface if not already done
     if (!g_pGUI)
     {
+        SetMemoryAllocationFailureHandler();
         g_pGUI = new CGUI_Impl(pDevice);
     }
 

Client/loader-proxy/main.cpp

@@ -117,6 +117,8 @@ BOOL OnLibraryAttach()
 
 VOID OnGameLaunch()
 {
+    SetMemoryAllocationFailureHandler();
+
     std::error_code ec{};
 
     // MTA:SA launches GTA:SA process with the GTA:SA installation directory as the current directory.

Client/loader/CInstallManager.cpp

@@ -16,6 +16,7 @@
 #include "GameExecutablePatcher.h"
 #include "FileGenerator.h"
 #include "FileSystem.h"
+#include "SharedUtil.Memory.h"
 
 namespace fs = std::filesystem;
 
@@ -418,9 +419,10 @@ SString CInstallManager::_ShowCrashFailDialog()
         SetApplicationSetting("diagnostics", "gta-fopen-fail", GetApplicationSetting("diagnostics", "gta-fopen-last"));
     SetApplicationSetting("diagnostics", "gta-fopen-last", "");
 
-    SString strMessage = GetApplicationSetting("diagnostics", "last-crash-info");
     SString strReason = GetApplicationSetting("diagnostics", "last-crash-reason");
     SetApplicationSetting("diagnostics", "last-crash-reason", "");
+
+    SString strMessage = GetApplicationSetting("diagnostics", "last-crash-info");
     if (strReason == "direct3ddevice-reset")
     {
         strMessage += _("** The crash was caused by a graphics driver error **\n\n** Please update your graphics drivers **");
@@ -430,6 +432,15 @@ SString CInstallManager::_ShowCrashFailDialog()
         strMessage += strReason;
     }
 
+    const SString moduleName = GetApplicationSetting("diagnostics", "last-crash-module");
+    const int     exceptionCode = GetApplicationSettingInt("diagnostics", "last-crash-code");
+
+    if (exceptionCode == CUSTOM_EXCEPTION_CODE_OOM && moduleName.EndsWithI("\\kernelbase.dll"))
+    {
+        strMessage += '\n';
+        strMessage += _("** Out of memory - this crash was caused by insufficient free or fragmented memory. **");
+    }
+
     strMessage = strMessage.Replace("\r", "").Replace("\n", "\r\n");
     SString strResult = ShowCrashedDialog(g_hInstance, strMessage);
     HideCrashedDialog();

Client/loader/MainFunctions.cpp

@@ -568,6 +568,8 @@ void PreLaunchWatchDogs()
     WatchDogBeginSection("L1");            // Gets closed when online game has started
     SetApplicationSetting("diagnostics", "gta-fopen-fail", "");
     SetApplicationSetting("diagnostics", "last-crash-reason", "");
+    SetApplicationSetting("diagnostics", "last-crash-module", "");
+    SetApplicationSetting("diagnostics", "last-crash-code", "");
     SetApplicationSetting("diagnostics", "gta-fopen-last", "");
 }
 

Client/mods/deathmatch/Client.cpp

@@ -10,6 +10,7 @@
  *****************************************************************************/
 
 #include "StdInc.h"
+#include "SharedUtil.Memory.h"
 
 CClient* g_pClient = NULL;
 
@@ -18,6 +19,7 @@ MTAEXPORT CClientBase* __cdecl InitClient(void)
     // Eventually create a client base interface
     if (!g_pClient)
     {
+        SetMemoryAllocationFailureHandler();
         g_pClient = new CClient;
     }
     return g_pClient;