Skip to content

Commit 9db2199

Browse files
committed
Disable GPU compositing checkbox when GPU disabled
1 parent 47cf382 commit 9db2199

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

Client/core/CSettings.cpp

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -920,9 +920,10 @@ void CSettings::CreateGUI()
920920
m_pCheckBoxBrowserGPUEnabled = reinterpret_cast<CGUICheckBox*>(pManager->CreateCheckBox(m_pTabBrowser, _("Enable GPU rendering"), true));
921921
m_pCheckBoxBrowserGPUEnabled->SetPosition(CVector2D(vecTemp.fX + 300.0f, vecTemp.fY - 20.0f));
922922
m_pCheckBoxBrowserGPUEnabled->AutoSize(NULL, 20.0f);
923+
m_pCheckBoxBrowserGPUEnabled->SetClickHandler(GUI_CALLBACK(&CSettings::OnGPUSettingChanged, this));
923924

924925
m_pCheckBoxBrowserGPUCompositingEnabled =
925-
reinterpret_cast<CGUICheckBox*>(pManager->CreateCheckBox(m_pTabBrowser, _("Enable GPU compositing (GPU required)"), true));
926+
reinterpret_cast<CGUICheckBox*>(pManager->CreateCheckBox(m_pTabBrowser, _("Enable GPU compositing"), true));
926927
m_pCheckBoxBrowserGPUCompositingEnabled->SetPosition(CVector2D(vecTemp.fX + 300.0f, vecTemp.fY));
927928
m_pCheckBoxBrowserGPUCompositingEnabled->AutoSize(NULL, 20.0f);
928929

@@ -3298,6 +3299,10 @@ void CSettings::LoadData()
32983299
m_pCheckBoxRemoteJavascript->SetSelected(bVar);
32993300
CVARS_GET("browser_enable_gpu", bVar);
33003301
m_pCheckBoxBrowserGPUEnabled->SetSelected(bVar);
3302+
3303+
if (!bVar)
3304+
m_pCheckBoxBrowserGPUCompositingEnabled->SetEnabled(false);
3305+
33013306
CVARS_GET("browser_enable_gpu_compositing", bVar);
33023307
m_pCheckBoxBrowserGPUCompositingEnabled->SetSelected(bVar);
33033308

@@ -4901,3 +4906,9 @@ bool CSettings::IsActive()
49014906
{
49024907
return m_pWindow->IsActive();
49034908
}
4909+
4910+
bool CSettings::OnGPUSettingChanged(CGUIElement* pElement)
4911+
{
4912+
m_pCheckBoxBrowserGPUCompositingEnabled->SetEnabled(m_pCheckBoxBrowserGPUEnabled->GetSelected());
4913+
return true;
4914+
}

Client/core/CSettings.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -384,6 +384,7 @@ class CSettings
384384
bool OnBrowserWhitelistRemove(CGUIElement* pElement);
385385
bool OnBrowserWhitelistDomainAddFocused(CGUIElement* pElement);
386386
bool OnBrowserWhitelistDomainAddDefocused(CGUIElement* pElement);
387+
bool OnGPUSettingChanged(CGUIElement* pElement);
387388

388389
bool OnMouseDoubleClick(CGUIMouseEventArgs Args);
389390

0 commit comments

Comments
 (0)