review

Author: Proxy-99

Server/mods/deathmatch/logic/CVehicle.h

@@ -499,7 +499,7 @@ class CVehicle final : public CElement
     unsigned char m_ucVariant2;
 
     bool m_onFire;
-    float m_nitroLevel;
+    float m_nitroLevel {0.0f};
 
     CTickCount m_LastPushedTime;
     CVector    m_vecStationaryCheckPosition;

Server/mods/deathmatch/logic/luadefs/CLuaVehicleDefs.cpp

@@ -3070,12 +3070,10 @@ bool CLuaVehicleDefs::SetVehicleNitroActivated(CVehicle* vehicle, bool state) no
 
 float CLuaVehicleDefs::GetVehicleNitroLevel(CVehicle* vehicle) noexcept
 {
-    float fLevel;
-    fLevel = vehicle->GetNitroLevel();
+    float fLevel = vehicle->GetNitroLevel();
 
     if (fLevel < 0)
         fLevel = 1 + fLevel;
 
     return fLevel;
-
 }

Server/mods/deathmatch/logic/net/CSimVehiclePuresyncPacket.cpp

@@ -260,7 +260,7 @@ bool CSimVehiclePuresyncPacket::Read(NetBitStreamInterface& BitStream)
              if (!BitStream.Read(vehicleNitro))
                  return false;
 
-             m_Cache.VehNitroLevel = vehicleNitro;
+             m_Cache.vehNitroLevel = vehicleNitro;
         }
 
 
@@ -436,7 +436,7 @@ bool CSimVehiclePuresyncPacket::Write(NetBitStreamInterface& BitStream) const
 
 
         if (BitStream.Can(eBitStreamVersion::IsVehicleNitroActivated_Serverside))
-            BitStream.Write(m_Cache.VehNitroLevel);
+            BitStream.Write(m_Cache.vehNitroLevel);
 
         // Success
         return true;

Server/mods/deathmatch/logic/net/CSimVehiclePuresyncPacket.h

@@ -75,7 +75,7 @@ class CSimVehiclePuresyncPacket : public CSimPacket
         CVector VehTurnSpeed;
 
         float fVehHealth;
-        float VehNitroLevel;
+        float vehNitroLevel;
 
         std::vector<STrailerInfo> TrailerList;
 

Server/mods/deathmatch/logic/packets/CVehiclePuresyncPacket.cpp

@@ -454,14 +454,13 @@ bool CVehiclePuresyncPacket::Read(NetBitStreamInterface& BitStream)
             if (BitStream.Can(eBitStreamVersion::SetElementOnFire))
                 pVehicle->SetOnFire(BitStream.ReadBit());
 
-             if (BitStream.Can(eBitStreamVersion::IsVehicleNitroActivated_Serverside))
+            if (BitStream.Can(eBitStreamVersion::IsVehicleNitroActivated_Serverside))
             {
                 float vehicleNitro;
                 if (!BitStream.Read(vehicleNitro))
                     return false;
 
                 pVehicle->SetNitroLevel(vehicleNitro);
-
             }
 
             // Success

Shared/sdk/net/bitstream.h

@@ -608,6 +608,8 @@ enum class eBitStreamVersion : unsigned short
     // 2025-01-10
     WorldSpecialProperty_FlyingComponents,
 
+    //2025-01-16
+    //Add isVehicleNitroActivated and getVehicleNitroLevel Server side
     IsVehicleNitroActivated_Serverside,
 
     // This allows us to automatically increment the BitStreamVersion when things are added to this enum.