Fixed memory leak and crash in password functions

Author: ccw808

Client/mods/deathmatch/logic/lua/CLuaFunctionRef.cpp

@@ -140,6 +140,7 @@ int CLuaFunctionRef::ToInt ( void ) const
     return m_iFunction;
 }
 
+// Returns null if VM has closed
 lua_State* CLuaFunctionRef::GetLuaVM ( void ) const
 {
     return m_luaVM;

Shared/mods/deathmatch/logic/luadefs/CLuaCryptDefs.cpp

@@ -230,18 +230,22 @@ int CLuaCryptDefs::PasswordHash(lua_State* luaVM)
                             // Execute time-consuming task
                             return SharedUtil::BcryptHash(password, salt, cost);
 
-                        }, [luaFunctionRef, pLuaMain](const SString& hash) {
-                            CLuaArguments arguments;
-
-                            if (hash.empty())
+                        }, [luaFunctionRef](const SString& hash) {
+                            CLuaMain* pLuaMain = m_pLuaManager->GetVirtualMachine(luaFunctionRef.GetLuaVM());
+                            if (pLuaMain)
                             {
-                                m_pScriptDebugging->LogCustom(pLuaMain->GetVM(), "Invalid value for field 'salt'");
-                                arguments.PushBoolean(false);
-                            }
-                            else
-                                arguments.PushString(hash);
+                                CLuaArguments arguments;
 
-                            arguments.Call(pLuaMain, luaFunctionRef);
+                                if (hash.empty())
+                                {
+                                    m_pScriptDebugging->LogCustom(pLuaMain->GetVM(), "Invalid value for field 'salt'");
+                                    arguments.PushBoolean(false);
+                                }
+                                else
+                                    arguments.PushString(hash);
+
+                                arguments.Call(pLuaMain, luaFunctionRef);
+                            }
                         });
 
                         lua_pushboolean(luaVM, true);
@@ -295,11 +299,14 @@ int CLuaCryptDefs::PasswordVerify(lua_State* luaVM)
                         // Execute time-consuming task
                         return SharedUtil::BcryptVerify(password, hash);
 
-                    }, [luaFunctionRef, pLuaMain](const bool& correct) {
-                        CLuaArguments arguments;
-                        arguments.PushBoolean(correct);
-
-                        arguments.Call(pLuaMain, luaFunctionRef);
+                    }, [luaFunctionRef](const bool& correct) {
+                        CLuaMain* pLuaMain = m_pLuaManager->GetVirtualMachine(luaFunctionRef.GetLuaVM());
+                        if (pLuaMain)
+                        {
+                            CLuaArguments arguments;
+                            arguments.PushBoolean(correct);
+                            arguments.Call(pLuaMain, luaFunctionRef);
+                        }
                     });
 
                     lua_pushboolean(luaVM, true);

Shared/sdk/SharedUtil.AsyncTaskScheduler.h

@@ -19,6 +19,7 @@ namespace SharedUtil
     {
         struct SBaseTask
         {
+            virtual ~SBaseTask() {}
             virtual void Execute() = 0;
             virtual void ProcessResult() = 0;
         };