Fixed logical incongruity

ccw808 · ccw808 · commit c3c28a903d3c · 2016-09-20T00:33:19.000+01:00
diff --git a/Server/mods/deathmatch/logic/CConsoleCommands.cpp b/Server/mods/deathmatch/logic/CConsoleCommands.cpp
@@ -1599,7 +1599,7 @@ bool CConsoleCommands::OpenPortsTest ( CConsole* pConsole, const char* szArgumen
 
 bool CConsoleCommands::SetDbLogLevel ( CConsole* pConsole, const char* szArguments, CClient* pClient, CClient* pEchoClient )
 {
-    if ( !pClient->GetClientType () == CClient::CLIENT_CONSOLE )
+    if ( pClient->GetClientType () != CClient::CLIENT_CONSOLE )
     {
         if ( !g_pGame->GetACLManager()->CanObjectUseRight ( pClient->GetAccount ()->GetName ().c_str (), CAccessControlListGroupObject::OBJECT_TYPE_USER, "debugdb", CAccessControlListRight::RIGHT_TYPE_COMMAND, false ) )
         {
@@ -1626,7 +1626,7 @@ bool CConsoleCommands::SetDbLogLevel ( CConsole* pConsole, const char* szArgumen
 
 bool DoAclRequest ( CConsole* pConsole, const char* szArguments, CClient* pClient, CClient* pEchoClient )
 {
-    if ( !pClient->GetClientType () == CClient::CLIENT_CONSOLE )
+    if ( pClient->GetClientType () != CClient::CLIENT_CONSOLE )
     {
         if ( !g_pGame->GetACLManager()->CanObjectUseRight ( pClient->GetAccount ()->GetName ().c_str (), CAccessControlListGroupObject::OBJECT_TYPE_USER, "aclrequest", CAccessControlListRight::RIGHT_TYPE_COMMAND, false ) )
         {
@@ -1698,7 +1698,7 @@ bool CConsoleCommands::AclRequest ( CConsole* pConsole, const char* szArguments,
 
 bool CConsoleCommands::AuthorizeSerial( CConsole* pConsole, const char* szArguments, CClient* pClient, CClient* pEchoClient )
 {
-    if ( !pClient->GetClientType() == CClient::CLIENT_CONSOLE )
+    if ( pClient->GetClientType() != CClient::CLIENT_CONSOLE )
     {
         if ( !g_pGame->GetACLManager()->CanObjectUseRight( pClient->GetAccount()->GetName(), CAccessControlListGroupObject::OBJECT_TYPE_USER, "authserial", CAccessControlListRight::RIGHT_TYPE_COMMAND, false ) )
         {
@@ -1812,7 +1812,7 @@ bool CConsoleCommands::FakeLag ( CConsole* pConsole, const char* szArguments, CC
 {
 #if defined(MTA_DEBUG) || defined(MTA_BETA)
 
-    if ( !pClient->GetClientType () == CClient::CLIENT_CONSOLE )
+    if ( pClient->GetClientType () != CClient::CLIENT_CONSOLE )
     {
         if ( !g_pGame->GetACLManager()->CanObjectUseRight ( pClient->GetAccount ()->GetName ().c_str (), CAccessControlListGroupObject::OBJECT_TYPE_USER, "sfakelag", CAccessControlListRight::RIGHT_TYPE_COMMAND, false ) )
         {
@@ -1847,7 +1847,7 @@ bool CConsoleCommands::FakeLag ( CConsole* pConsole, const char* szArguments, CC
 
 bool CConsoleCommands::DebugJoinFlood ( CConsole* pConsole, const char* szArguments, CClient* pClient, CClient* pEchoClient )
 {
-    if ( !pClient->GetClientType () == CClient::CLIENT_CONSOLE )
+    if ( pClient->GetClientType () != CClient::CLIENT_CONSOLE )
     {
         if ( !g_pGame->GetACLManager()->CanObjectUseRight ( pClient->GetAccount ()->GetName ().c_str (), CAccessControlListGroupObject::OBJECT_TYPE_USER, "debugjoinflood", CAccessControlListRight::RIGHT_TYPE_COMMAND, false ) )
         {
@@ -1871,7 +1871,7 @@ bool CConsoleCommands::DebugJoinFlood ( CConsole* pConsole, const char* szArgume
 
 bool CConsoleCommands::DebugUpTime ( CConsole* pConsole, const char* szArguments, CClient* pClient, CClient* pEchoClient )
 {
-    if ( !pClient->GetClientType () == CClient::CLIENT_CONSOLE )
+    if ( pClient->GetClientType () != CClient::CLIENT_CONSOLE )
     {
         if ( !g_pGame->GetACLManager()->CanObjectUseRight ( pClient->GetAccount ()->GetName ().c_str (), CAccessControlListGroupObject::OBJECT_TYPE_USER, "debuguptime", CAccessControlListRight::RIGHT_TYPE_COMMAND, false ) )
         {

Original file line number	Diff line number	Diff line change
`@@ -1599,7 +1599,7 @@ bool CConsoleCommands::OpenPortsTest ( CConsole* pConsole, const char* szArgumen`
`1599`	`1599`
`1600`	`1600`	`bool CConsoleCommands::SetDbLogLevel ( CConsole* pConsole, const char* szArguments, CClient* pClient, CClient* pEchoClient )`
`1601`	`1601`	`{`
`1602`		`- if ( !pClient->GetClientType () == CClient::CLIENT_CONSOLE )`
	`1602`	`+ if ( pClient->GetClientType () != CClient::CLIENT_CONSOLE )`
`1603`	`1603`	`{`
`1604`	`1604`	`if ( !g_pGame->GetACLManager()->CanObjectUseRight ( pClient->GetAccount ()->GetName ().c_str (), CAccessControlListGroupObject::OBJECT_TYPE_USER, "debugdb", CAccessControlListRight::RIGHT_TYPE_COMMAND, false ) )`
`1605`	`1605`	`{`
`@@ -1626,7 +1626,7 @@ bool CConsoleCommands::SetDbLogLevel ( CConsole* pConsole, const char* szArgumen`
`1626`	`1626`
`1627`	`1627`	`bool DoAclRequest ( CConsole* pConsole, const char* szArguments, CClient* pClient, CClient* pEchoClient )`
`1628`	`1628`	`{`
`1629`		`- if ( !pClient->GetClientType () == CClient::CLIENT_CONSOLE )`
	`1629`	`+ if ( pClient->GetClientType () != CClient::CLIENT_CONSOLE )`
`1630`	`1630`	`{`
`1631`	`1631`	`if ( !g_pGame->GetACLManager()->CanObjectUseRight ( pClient->GetAccount ()->GetName ().c_str (), CAccessControlListGroupObject::OBJECT_TYPE_USER, "aclrequest", CAccessControlListRight::RIGHT_TYPE_COMMAND, false ) )`
`1632`	`1632`	`{`
`@@ -1698,7 +1698,7 @@ bool CConsoleCommands::AclRequest ( CConsole* pConsole, const char* szArguments,`
`1698`	`1698`
`1699`	`1699`	`bool CConsoleCommands::AuthorizeSerial( CConsole* pConsole, const char* szArguments, CClient* pClient, CClient* pEchoClient )`
`1700`	`1700`	`{`
`1701`		`- if ( !pClient->GetClientType() == CClient::CLIENT_CONSOLE )`
	`1701`	`+ if ( pClient->GetClientType() != CClient::CLIENT_CONSOLE )`
`1702`	`1702`	`{`
`1703`	`1703`	`if ( !g_pGame->GetACLManager()->CanObjectUseRight( pClient->GetAccount()->GetName(), CAccessControlListGroupObject::OBJECT_TYPE_USER, "authserial", CAccessControlListRight::RIGHT_TYPE_COMMAND, false ) )`
`1704`	`1704`	`{`
`@@ -1812,7 +1812,7 @@ bool CConsoleCommands::FakeLag ( CConsole* pConsole, const char* szArguments, CC`
`1812`	`1812`	`{`
`1813`	`1813`	`#if defined(MTA_DEBUG) \|\| defined(MTA_BETA)`
`1814`	`1814`
`1815`		`- if ( !pClient->GetClientType () == CClient::CLIENT_CONSOLE )`
	`1815`	`+ if ( pClient->GetClientType () != CClient::CLIENT_CONSOLE )`
`1816`	`1816`	`{`
`1817`	`1817`	`if ( !g_pGame->GetACLManager()->CanObjectUseRight ( pClient->GetAccount ()->GetName ().c_str (), CAccessControlListGroupObject::OBJECT_TYPE_USER, "sfakelag", CAccessControlListRight::RIGHT_TYPE_COMMAND, false ) )`
`1818`	`1818`	`{`
`@@ -1847,7 +1847,7 @@ bool CConsoleCommands::FakeLag ( CConsole* pConsole, const char* szArguments, CC`
`1847`	`1847`
`1848`	`1848`	`bool CConsoleCommands::DebugJoinFlood ( CConsole* pConsole, const char* szArguments, CClient* pClient, CClient* pEchoClient )`
`1849`	`1849`	`{`
`1850`		`- if ( !pClient->GetClientType () == CClient::CLIENT_CONSOLE )`
	`1850`	`+ if ( pClient->GetClientType () != CClient::CLIENT_CONSOLE )`
`1851`	`1851`	`{`
`1852`	`1852`	`if ( !g_pGame->GetACLManager()->CanObjectUseRight ( pClient->GetAccount ()->GetName ().c_str (), CAccessControlListGroupObject::OBJECT_TYPE_USER, "debugjoinflood", CAccessControlListRight::RIGHT_TYPE_COMMAND, false ) )`
`1853`	`1853`	`{`
`@@ -1871,7 +1871,7 @@ bool CConsoleCommands::DebugJoinFlood ( CConsole* pConsole, const char* szArgume`
`1871`	`1871`
`1872`	`1872`	`bool CConsoleCommands::DebugUpTime ( CConsole* pConsole, const char* szArguments, CClient* pClient, CClient* pEchoClient )`
`1873`	`1873`	`{`
`1874`		`- if ( !pClient->GetClientType () == CClient::CLIENT_CONSOLE )`
	`1874`	`+ if ( pClient->GetClientType () != CClient::CLIENT_CONSOLE )`
`1875`	`1875`	`{`
`1876`	`1876`	`if ( !g_pGame->GetACLManager()->CanObjectUseRight ( pClient->GetAccount ()->GetName ().c_str (), CAccessControlListGroupObject::OBJECT_TYPE_USER, "debuguptime", CAccessControlListRight::RIGHT_TYPE_COMMAND, false ) )`
`1877`	`1877`	`{`