Improve check in CSimBulletsyncPacket::Read

Author: Dutchman101

Server/mods/deathmatch/logic/CPickupManager.cpp

@@ -68,6 +68,11 @@ bool CPickupManager::IsValidWeaponID(unsigned int uiWeaponID)
     return (uiWeaponID > 0 && uiWeaponID != 13 && uiWeaponID != 19 && uiWeaponID != 20 && uiWeaponID != 21 && uiWeaponID <= 46);
 }
 
+bool CPickupManager::HasWeaponBulletSync(uint32_t weaponID)
+{
+    return weaponID >= 22 && weaponID <= 34;
+}
+
 unsigned short CPickupManager::GetWeaponModel(unsigned int uiWeaponID)
 {
     if (uiWeaponID <= 46)

Server/mods/deathmatch/logic/CPickupManager.h

@@ -36,6 +36,7 @@ class CPickupManager
     std::list<CPickup*>::const_iterator IterEnd() { return m_List.end(); };
 
     static bool           IsValidWeaponID(unsigned int uiWeaponID);
+    static bool           HasWeaponBulletSync(uint32_t weaponID);
     static unsigned short GetWeaponModel(unsigned int uiWeaponID);
     static unsigned short GetHealthModel() { return 1240; };
     static unsigned short GetArmorModel() { return 1242; };

Server/mods/deathmatch/logic/net/CSimBulletsyncPacket.cpp

@@ -26,7 +26,7 @@ bool CSimBulletsyncPacket::Read(NetBitStreamInterface& BitStream)
 {
     char cWeaponType;
     BitStream.Read(cWeaponType);
-    if (!CPickupManager::IsValidWeaponID(cWeaponType))
+    if (!CPickupManager::HasWeaponBulletSync(cWeaponType))
         return false;
     m_Cache.weaponType = (eWeaponType)cWeaponType;