Revert suspension related changes for now, as we need stable master.

It will be re-introduced later (revised).

The now-reverted changes were prompted by exposing GTA streaming race conditions, but since what exposed them was also reverted for stability reasons, it's not urgent.
Everything (and related) will be re-pushed when fully tested.

Author: Dutchman101

Client/game_sa/CModelInfoSA.cpp

@@ -488,15 +488,6 @@ bool CModelInfoSA::DoIsLoaded()
     return bLoaded;
 }
 
-bool CModelInfoSA::IsCollisionLoaded()
-{
-    m_pInterface = ppModelInfo[m_dwModelID];
-    if (!m_pInterface || !m_pInterface->pColModel)
-        return false;
-
-    return m_pInterface->pColModel->m_data != nullptr;
-}
-
 unsigned short CModelInfoSA::GetFlags()
 {
     return ppModelInfo[m_dwModelID]->usFlags;

Client/game_sa/CModelInfoSA.h

@@ -389,7 +389,6 @@ class CModelInfoSA : public CModelInfo
     void           Remove();
     bool           UnloadUnused();
     bool           IsLoaded();
-    bool           IsCollisionLoaded() override;
     bool           DoIsLoaded();
     unsigned short GetFlags();
     unsigned short GetOriginalFlags();

Client/game_sa/CVehicleSA.cpp

@@ -1839,7 +1839,7 @@ void CVehicleSA::RecalculateSuspensionLines()
 
     DWORD       dwModel = GetModelIndex();
     CModelInfo* pModelInfo = pGame->GetModelInfo(dwModel);
-    if (pModelInfo && (pModelInfo->IsCar() || pModelInfo->IsMonsterTruck() || pModelInfo->IsTrailer()))
+    if (pModelInfo && pModelInfo->IsMonsterTruck() || pModelInfo->IsCar())
     {
         // Trains (Their trailers do as well!)
         if (pModelInfo->IsTrain() || dwModel == 571 || dwModel == 570 || dwModel == 569 || dwModel == 590)

Client/mods/deathmatch/logic/CClientVehicle.cpp

@@ -4300,15 +4300,6 @@ void CClientVehicle::ApplyHandling()
     if (!m_pVehicle)
         return;
 
-    // Ensure model is loaded before recalculating handling
-    CModelInfo* pModelInfo = g_pGame->GetModelInfo(GetModel());
-    if (!pModelInfo || !pModelInfo->IsLoaded())
-        return;
-
-    // Ensure collision model is loaded before recalculating (needed for suspension lines)
-    if (!pModelInfo->IsCollisionLoaded())
-        return;
-
     m_pVehicle->RecalculateHandling();
 
     if (m_eVehicleType == CLIENTVEHICLE_BMX || m_eVehicleType == CLIENTVEHICLE_BIKE)

Client/mods/deathmatch/logic/CStaticFunctionDefinitions.cpp

@@ -8905,10 +8905,6 @@ bool CStaticFunctionDefinitions::SetVehicleHandling(CClientVehicle* pVehicle, Ha
     {
         if (SetEntryHandling(pEntry, eProperty, ucValue))
         {
-            CModelInfo* pModelInfo = g_pGame->GetModelInfo(pVehicle->GetModel());
-            if (!pModelInfo || !pModelInfo->IsLoaded())
-                return false;
-
             pVehicle->ApplyHandling();
             return true;
         }
@@ -8926,10 +8922,6 @@ bool CStaticFunctionDefinitions::SetVehicleHandling(CClientVehicle* pVehicle, Ha
     {
         if (SetEntryHandling(pEntry, eProperty, uiValue))
         {
-            CModelInfo* pModelInfo = g_pGame->GetModelInfo(pVehicle->GetModel());
-            if (!pModelInfo || !pModelInfo->IsLoaded())
-                return false;
-
             pVehicle->ApplyHandling();
             return true;
         }
@@ -8947,10 +8939,6 @@ bool CStaticFunctionDefinitions::SetVehicleHandling(CClientVehicle* pVehicle, Ha
     {
         if (SetEntryHandling(pEntry, eProperty, fValue))
         {
-            CModelInfo* pModelInfo = g_pGame->GetModelInfo(pVehicle->GetModel());
-            if (!pModelInfo || !pModelInfo->IsLoaded())
-                return false;
-
             pVehicle->ApplyHandling();
             return true;
         }
@@ -8968,10 +8956,6 @@ bool CStaticFunctionDefinitions::SetVehicleHandling(CClientVehicle* pVehicle, Ha
     {
         if (SetEntryHandling(pEntry, eProperty, strValue))
         {
-            CModelInfo* pModelInfo = g_pGame->GetModelInfo(pVehicle->GetModel());
-            if (!pModelInfo || !pModelInfo->IsLoaded())
-                return false;
-
             pVehicle->ApplyHandling();
             return true;
         }
@@ -8989,10 +8973,6 @@ bool CStaticFunctionDefinitions::SetVehicleHandling(CClientVehicle* pVehicle, Ha
     {
         if (SetEntryHandling(pEntry, eProperty, vecValue))
         {
-            CModelInfo* pModelInfo = g_pGame->GetModelInfo(pVehicle->GetModel());
-            if (!pModelInfo || !pModelInfo->IsLoaded())
-                return false;
-
             pVehicle->ApplyHandling();
             return true;
         }
@@ -9051,10 +9031,6 @@ bool CStaticFunctionDefinitions::ResetVehicleHandling(CClientVehicle* pVehicle)
             pEntry->SetSuspensionUpperLimit(pEntry->GetSuspensionLowerLimit() - 0.1f);
     }
 
-    CModelInfo* pModelInfo = g_pGame->GetModelInfo(pVehicle->GetModel());
-    if (!pModelInfo || !pModelInfo->IsLoaded())
-        return false;
-
     pVehicle->ApplyHandling();
 
     return true;
@@ -9104,10 +9080,6 @@ bool CStaticFunctionDefinitions::ResetVehicleHandlingProperty(CClientVehicle* pV
             return false;
         }
 
-        CModelInfo* pModelInfo = g_pGame->GetModelInfo(pVehicle->GetModel());
-        if (!pModelInfo || !pModelInfo->IsLoaded())
-            return false;
-
         pVehicle->ApplyHandling();
 
         return true;

Client/mods/deathmatch/logic/luadefs/CLuaVehicleDefs.cpp

@@ -2518,15 +2518,6 @@ int CLuaVehicleDefs::SetVehicleHandling(lua_State* luaVM)
 
     if (!argStream.HasErrors())
     {
-        // Check if the vehicle model is loaded
-        CModelInfo* pModelInfo = g_pGame->GetModelInfo(pVehicle->GetModel());
-        if (!pModelInfo || !pModelInfo->IsLoaded())
-        {
-            m_pScriptDebugging->LogWarning(luaVM, "setVehicleHandling failed: vehicle model not loaded");
-            lua_pushboolean(luaVM, false);
-            return 1;
-        }
-
         if (argStream.NextIsString())
         {
             SString strProperty;

Client/sdk/game/CModelInfo.h

@@ -162,7 +162,6 @@ class CModelInfo
     virtual BYTE           GetVehicleType() const noexcept = 0;
     virtual void           Request(EModelRequestType requestType, const char* szTag /* = NULL*/) = 0;
     virtual bool           IsLoaded() = 0;
-    virtual bool           IsCollisionLoaded() = 0;
     virtual unsigned short GetFlags() = 0;
     virtual unsigned short GetOriginalFlags() = 0;
     virtual void           SetFlags(unsigned short usFlags) = 0;