Revert "Fixed some non standard constructs introduced with da1709d"

This reverts commit ec79f29.

Author: jushar

Client/mods/deathmatch/logic/CClientDisplayManager.cpp

@@ -87,7 +87,7 @@ void CClientDisplayManager::DoPulse ( void )
 {
     // Render all our displays
     m_bCanRemoveFromList = false;
-    auto iter  = m_List.begin ();
+    auto& iter  = m_List.begin ();
     while ( iter != m_List.end () )
     {
         CClientDisplay* pObject = *iter;

Client/mods/deathmatch/logic/CClientModelRequestManager.cpp

@@ -222,7 +222,7 @@ void CClientModelRequestManager::Cancel ( CClientEntity* pEntity, bool bAllowQue
         {
             // Anything requested by the given class?
             SClientModelRequest* pEntry;
-            for ( auto iter = m_Requests.begin(); iter != m_Requests.end(); )
+            for ( auto& iter = m_Requests.begin(); iter != m_Requests.end(); )
             {
                 pEntry = *iter;
 
@@ -259,7 +259,7 @@ void CClientModelRequestManager::DoPulse ( void )
 
         // Call the callback for those finished loading and remove them from the list
         SClientModelRequest* pEntry;
-        for ( auto iter = m_Requests.begin (); iter != m_Requests.end (); )
+        for ( auto& iter = m_Requests.begin (); iter != m_Requests.end (); )
         {
             pEntry = *iter;
 
@@ -323,7 +323,7 @@ void CClientModelRequestManager::DoPulse ( void )
 bool CClientModelRequestManager::GetRequestEntry ( CClientEntity* pRequester, std::list < SClientModelRequest* > ::iterator& iterOut )
 {
     // Look through the list
-    for ( auto iter = m_Requests.begin() ; iter != m_Requests.end (); iter++ )
+    for ( auto& iter = m_Requests.begin() ; iter != m_Requests.end (); iter++ )
     {
         // Same requester as we check for? He has requested something.
         if ( (*iter)->pEntity == pRequester )

Client/mods/deathmatch/logic/CClientSoundManager.cpp

@@ -409,7 +409,7 @@ void CClientSoundManager::ProcessStopQueues( bool bFlush )
         }
     }
 
-    for( auto iter = m_AudioStopQueue.begin() ; iter != m_AudioStopQueue.end() ;)
+    for( auto& iter = m_AudioStopQueue.begin() ; iter != m_AudioStopQueue.end() ;)
     {
         if ( iter->second.Get() > 100 || bFlush )
         {

Client/mods/deathmatch/logic/CClientTask.cpp

@@ -306,8 +306,8 @@ bool CClientTask::WriteParameters ( lua_State* luaVM, int iTableIndex )
     }
 
     // Push the values to it.
-    auto iterKey = m_Keys.begin ();
-    auto iterValue = m_Values.begin ();
+    auto& iterKey = m_Keys.begin ();
+    auto& iterValue = m_Values.begin ();
     while ( iterKey != m_Keys.end () )
     {
         // Add the entries to it

Client/mods/deathmatch/logic/CClientVehicle.cpp

@@ -2295,7 +2295,7 @@ void CClientVehicle::StreamedInPulse ( void )
         // Handle door ratio auto reallowment
         if ( !m_AutoReallowDoorRatioMap.empty() )
         {
-            for ( auto iter = m_AutoReallowDoorRatioMap.begin() ; iter != m_AutoReallowDoorRatioMap.end() ; )
+            for ( auto& iter = m_AutoReallowDoorRatioMap.begin() ; iter != m_AutoReallowDoorRatioMap.end() ; )
             {
                 if ( ( CTickCount::Now() - iter->second ).ToInt() > 4000 )
                 {

Client/mods/deathmatch/logic/CLocalServer.cpp

@@ -349,7 +349,7 @@ bool CLocalServer::Save ( void )
         // Remove old resources from the config
         CXMLNode* pRoot = m_pConfig->GetRootNode();
         auto& list = pRoot->GetChildren();
-        for ( auto iter = list.begin(); iter != list.end(); ++iter )
+        for ( auto& iter = list.begin(); iter != list.end(); ++iter )
         {
             CXMLNode* pNode = reinterpret_cast < CXMLNode* > ( *iter );
             if ( pNode->GetTagName().compare ( "resource" ) == 0 )

Client/mods/deathmatch/logic/CMovingObjectsManager.cpp

@@ -19,7 +19,7 @@ void CMovingObjectsManager::DoPulse ( void )
     // Pulse all the objects we're moving
     bool bRemoved = false;
     CDeathmatchObject* pObject;
-    auto iter = m_List.begin ();
+    auto& iter = m_List.begin ();
     while ( iter != m_List.end () )
     {
         pObject = *iter;

Client/mods/deathmatch/logic/CRegisteredCommands.cpp

@@ -61,7 +61,7 @@ bool CRegisteredCommands::RemoveCommand ( CLuaMain* pLuaMain, const char* szKey
 
     int iCompareResult;
 
-    auto iter = m_Commands.begin();
+    auto& iter = m_Commands.begin();
     while ( iter != m_Commands.end () )
     {
         if ( (*iter)->bCaseSensitive )
@@ -111,7 +111,7 @@ void CRegisteredCommands::CleanUpForVM ( CLuaMain* pLuaMain )
     assert ( pLuaMain );
 
     // Delete every command that matches
-    for ( auto iter = m_Commands.begin() ; iter != m_Commands.end (); )
+    for ( auto& iter = m_Commands.begin() ; iter != m_Commands.end (); )
     {
         // Matching VM's?
         if ( (*iter)->pLuaMain == pLuaMain )

Client/mods/deathmatch/logic/CScriptKeyBinds.cpp

@@ -99,7 +99,7 @@ void CScriptKeyBinds::Add ( CScriptKeyBind* pKeyBind )
 
 void CScriptKeyBinds::Clear ( eScriptKeyBindType bindType )
 {
-    auto iter = m_List.begin ();
+    auto& iter = m_List.begin ();
     while ( iter != m_List.end () )
     {
         auto& pKeyBind = *iter;
@@ -279,7 +279,7 @@ bool CScriptKeyBinds::RemoveKeyFunction ( const SScriptBindableKey* pKey, CLuaMa
     bool bFound = false;
     CScriptKeyFunctionBind* pBind = NULL;
     auto cloneList = m_List;
-    auto iter = cloneList.begin ();
+    auto& iter = cloneList.begin ();
     while ( iter != cloneList.end () )
     {
         if ( !(*iter)->IsBeingDeleted () && (*iter)->GetType () == SCRIPT_KEY_BIND_FUNCTION )
@@ -357,7 +357,7 @@ void CScriptKeyBinds::RemoveAllKeys ( CLuaMain* pLuaMain )
 {
     CScriptKeyBind * pBind = NULL;
     auto cloneList = m_List;
-    auto iter = cloneList.begin ();
+    auto& iter = cloneList.begin ();
     while ( iter != cloneList.end () )
     {
         pBind = *iter;
@@ -437,7 +437,7 @@ bool CScriptKeyBinds::RemoveControlFunction ( const SScriptBindableGTAControl* p
     bool bFound = false;
     CScriptControlFunctionBind* pBind = NULL;
     auto cloneList = m_List;
-    auto iter = cloneList.begin ();
+    auto& iter = cloneList.begin ();
     while ( iter != cloneList.end () )
     {
         if ( !(*iter)->IsBeingDeleted () && (*iter)->GetType () == SCRIPT_KEY_BIND_CONTROL_FUNCTION )

Shared/mods/deathmatch/logic/CDebugHookManager.cpp

@@ -110,7 +110,7 @@ bool CDebugHookManager::RemoveDebugHook( EDebugHookType hookType, const CLuaFunc
     CLuaMain* pLuaMain = g_pGame->GetLuaManager ()->GetVirtualMachine ( functionRef.GetLuaVM() );
 
     std::vector < SDebugHookCallInfo >& hookInfoList = GetHookInfoListForType( hookType );
-    for( auto iter = hookInfoList.begin() ; iter != hookInfoList.end() ; ++iter )
+    for( auto& iter = hookInfoList.begin() ; iter != hookInfoList.end() ; ++iter )
     {
         if ( (*iter).pLuaMain == pLuaMain && (*iter).functionRef == functionRef )
         {