Possible fix for recently introduced crash

jushar · jushar · commit efe0d2ffd9aa · 2018-05-02T21:51:48.000+02:00
diff --git a/Client/mods/deathmatch/logic/luadefs/CLuaBrowserDefs.cpp b/Client/mods/deathmatch/logic/luadefs/CLuaBrowserDefs.cpp
@@ -168,7 +168,7 @@ int CLuaBrowserDefs::RequestBrowserDomains(lua_State* luaVM)
     if (!argStream.HasErrors())
     {
         // Remove empty URLs
-        pages.erase(std::remove_if(pages.begin(), pages.end(), [](const auto& url) { return url.empty(); }));
+        pages.erase(std::remove_if(pages.begin(), pages.end(), [](const auto& url) { return url.empty(); }), pages.end());
 
         // Convert to domains if we got a list of URLs
         if (bIsURL)

Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ int CLuaBrowserDefs::RequestBrowserDomains(lua_State* luaVM)`
`168`	`168`	`if (!argStream.HasErrors())`
`169`	`169`	`{`
`170`	`170`	`// Remove empty URLs`
`171`		`- pages.erase(std::remove_if(pages.begin(), pages.end(), [](const auto& url) { return url.empty(); }));`
	`171`	`+ pages.erase(std::remove_if(pages.begin(), pages.end(), [](const auto& url) { return url.empty(); }), pages.end());`
`172`	`172`
`173`	`173`	`// Convert to domains if we got a list of URLs`
`174`	`174`	`if (bIsURL)`