Fix undefined behavior in CClientEntity::CallEventNoParent

Dutchman101 · Dutchman101 · commit f0afa3c99c41 · 2025-08-13T05:54:55.000+08:00
diff --git a/Client/mods/deathmatch/logic/CClientEntity.cpp b/Client/mods/deathmatch/logic/CClientEntity.cpp
@@ -791,7 +791,8 @@ void CClientEntity::CallEventNoParent(const char* szName, const CLuaArguments& A
     // Call it on all our children
     if (!m_Children.empty())
     {
-        for (CClientEntity* pEntity : *GetChildrenListSnapshot())
+        auto pChildrenSnapshot = GetChildrenListSnapshot();
+		for (CClientEntity* pEntity : *pChildrenSnapshot)
         {
             if (!pEntity->IsBeingDeleted())
             {

Original file line number	Diff line number	Diff line change
`@@ -791,7 +791,8 @@ void CClientEntity::CallEventNoParent(const char* szName, const CLuaArguments& A`
`791`	`791`	`// Call it on all our children`
`792`	`792`	`if (!m_Children.empty())`
`793`	`793`	`{`
`794`		`- for (CClientEntity* pEntity : *GetChildrenListSnapshot())`
	`794`	`+ auto pChildrenSnapshot = GetChildrenListSnapshot();`
	`795`	`+ for (CClientEntity* pEntity : *pChildrenSnapshot)`
`795`	`796`	`{`
`796`	`797`	`if (!pEntity->IsBeingDeleted())`
`797`	`798`	`{`