setVehicleAudioSetting bug

[Xenius97]

Describe the bug

After using setVehicleAudioSetting streamed in models will have only top speed sounds
https://youtu.be/Cv2B7Jaeza0

Steps to reproduce

local replaceDefaultSoundsEnabled = (type(setVehicleModelAudioSetting) == "function" and true or false)
local customParameters = {
	[575] = getVehicleModelAudioSettings(415), -- # hustler <> cheetah
	[439] = getVehicleModelAudioSettings(415), -- # stallion <> cheetah
	[567] = getVehicleModelAudioSettings(400), -- # savanna <> landstalker
	[474] = getVehicleModelAudioSettings(603), -- # hermes <> phoenix
	[543] = getVehicleModelAudioSettings(411), -- # sadler <> infernus
	[604] = getVehicleModelAudioSettings(445), -- # d. glendale <> admiral
	[516] = getVehicleModelAudioSettings(445), -- # nebula <> admiral
	[545] = getVehicleModelAudioSettings(550), -- # trabant <> walton
}

addEventHandler("onClientResourceStart", resourceRoot, function()
	if not replaceDefaultSoundsEnabled then
		return
	end

	for modelId, values in pairs(customParameters) do
		for key, value in pairs(values) do
			setVehicleModelAudioSetting(modelId, key, value)
		end
	end

	-- # fix streaming after resource start [instantly change sound of vehicle, otherwise you need to use engineRestreamWorld()]
	for _, vehicle in ipairs(getElementsByType("vehicle", root, true)) do
		local model = getElementModel(vehicle)
		if customParameters[model] then
			local values = customParameters[model]
			for key, value in pairs(values) do
				setVehicleAudioSetting(vehicle, key, value)
			end
		end
	end
end)

addEventHandler("onClientResourceStop", resourceRoot, function()
	if not replaceDefaultSoundsEnabled then
		return
	end

	for modelId in pairs(customParameters) do
		resetVehicleModelAudioSettings(modelId)
	end
end)

Version

Multi Theft Auto v1.6-release-23309

Additional context

No response

Relevant log output

Security Policy

• I have read and understood the Security Policy and this issue is not security related.

[Xenius97]

The issue still existing, #4321 not fixed it. Please reopen.
https://youtu.be/epc13hKTYHg

[MohabCodeX]

PR #4321 partially fixed the issue , it changes the audio for newly created vehicles only. Existing vehicles still have the old sound unless you manually call engineRestreamWorld or use a Lua workaround with setVehicleAudioSetting.
This was the original behavior (changes apply to new vehicles only), but it would make sense if changes applied to existing vehicles as well.

Could you please try the following steps:

1. Spawn model 439
2. Use this script:

local replaceDefaultSoundsEnabled = (type(setVehicleModelAudioSetting) == "function")

if replaceDefaultSoundsEnabled then
    addEventHandler("onClientResourceStart", resourceRoot, function()
        local cheetahAudioSettings = getVehicleModelAudioSettings(415)

        for property, value in pairs(cheetahAudioSettings) do
            setVehicleModelAudioSetting(439, property, value)
        end

        outputChatBox("Audio settings for model 439 have been changed to match model 415.")
    end)
else
    outputChatBox("setVehicleModelAudioSetting function is not available.")
end

3. Spawn another vehicle with model 439
4. You'll notice that the newly spawned one has the updated audio without the problem of Top speed RPM sound.

[FileEX]

I think this can be easily fixed by using CClientVehicleManager::RestreamVehicles. I'm not entirely sure what #4321 is doing - after calling setVehicleModelAudioSetting, it applies the settings to all vehicles on the map, which doesn't seem like the correct approach. Restream helps here because it briefly destroy the vehicle and recreates it.

Although I don't think restreaming vehicles is the proper solution. The issue lies within setVehicleModelAudioSetting, and the bug is specifically related to that.

[MohabCodeX]

I also noticed the problem might still happen. Just exit and re-enter the vehicle, and the Top RPM sound will be fixed, i will look again into this

[MohabCodeX]

I think this can be easily fixed by using CClientVehicleManager::RestreamVehicles

• @FileEX

2025-08-01.18-10-05.mp4

problem was also happening with resetVehicleModelAudioSettings and i applied same idea

idk if i should open PR with this solution or not.