Satchels are exploding twice

[Castillos15]

Describe the bug

Satchels are exploding twice, I believe it's caused by this change: 4267

Steps to reproduce

1. Open local server/map editor
2. Runcode this: addEventHandler ( "onClientExplosion", root, function ( x, y, z, type ) iprint ( x, y, z, type, source ) end )
3. Get a satchel, throw and detonate it
4. Watch how onClientExplosion is triggered twice

Version

Client: Multi Theft Auto v1.6-release-23318

Additional context

Doesn't happen on version: Multi Theft Auto v1.6-release-23251

Relevant log output

Security Policy

• I have read and understood the Security Policy and this issue is not security related.

[ArranTuna]

Confirmed bug, players are complaining about satchels doing double damage and confirmed it on a local server that onClientPlayerDamage triggers twice with 1 satchel.

Also noticed that the weapon in 1 event is 39 (satchel) the second is 16 (grenade)

[botder]

Reverted the pull request in commit 7bf6af1

[ArranTuna]

Seems this bug doesn't just cause 1 grenade explosion, but 1 for each streamed in player and each streamed in player is the attacker in a onClientPlayerDamage event.

[ArranTuna]

This bug appears fixed when you test it alone, but when another player is nearby, the extra damage event with the other player nearby comes in and says they damaged you with a grenade explosion still.

[ArranTuna]

I just realised that when I tested it, not all clients in the area had the update, so those old clients were doing this SendExplosionSync that was reverted. Now that everyone is using the fixed version this bug is resolved.