Skip to content

Add setting to toggle photos taken by ingame camera to be saved in documents folder (fixes #3542) #3667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Dec 30, 2024
Merged

Add setting to toggle photos taken by ingame camera to be saved in documents folder (fixes #3542) #3667

merged 14 commits into from
Dec 30, 2024
+37 −2

Conversation

@ffsPLASMA
Copy link
Contributor

@ffsPLASMA ffsPLASMA commented Aug 21, 2024

Adds a new setting in video tab called "Save photos inside documents folder" which allows you to decide if you want to save photos taken by ingame camera to be saved in documents folder or not.

fixes #3542

grafik

@TracerDS
Copy link
Contributor

TracerDS commented Aug 21, 2024 •
edited
Loading

Would it save to %USERPROFILE%/Documents or MTA/screenshots?

@ffsPLASMA
Copy link
Contributor Author

ffsPLASMA commented Aug 21, 2024 •
edited
Loading

This is only related to the ingame camera taking photos. screenshots taken by pressing f12 are not affected.

@TracerDS
Copy link
Contributor

TracerDS commented Aug 21, 2024

This is only related to the ingame camera taking photos. screenshots taken by pressing f12 are not affected.

I think it would be better to save them in screenshots folder.
Userprofile should not be trashed by screenshots from camera.

@ffsPLASMA
Copy link
Contributor Author

ffsPLASMA commented Aug 21, 2024

This is only related to the ingame camera taking photos. screenshots taken by pressing f12 are not affected.

I think it would be better to save them in screenshots folder. Userprofile should not be trashed by screenshots from camera.

The current behaviour is the ingame camera saves the photo to the userprofile documents folder. This PR allows this behaviour to be disabled so no screenshot is being saved to disk when taking one ingame.

@TheNormalnij
Copy link
Member

TheNormalnij commented Aug 21, 2024

It doesn't look like video tab is right tab for this setting.
Maybe you need to use Advanced tab and change name for this setting,
I can't get what this setting do without your additional description

TracerDS
TracerDS suggested changes Aug 21, 2024
View reviewed changes
@tederis tederis added the enhancement New feature or request label Aug 22, 2024
@ffsPLASMA
Copy link
Contributor Author

ffsPLASMA commented Aug 22, 2024

Added it to advanced tab with more fitting description

grafik

tederis
tederis reviewed Aug 23, 2024
View reviewed changes
TheNormalnij
TheNormalnij reviewed Aug 23, 2024
View reviewed changes
FileEX
FileEX approved these changes Oct 4, 2024
View reviewed changes
@botder botder merged commit 3419b9b into multitheftauto:master Dec 30, 2024
6 checks passed
@botder botder added this to the 1.6.1 milestone Dec 30, 2024
MTABot pushed a commit that referenced this pull request Dec 30, 2024
@github-actions
Synchronize changes from 1.6 master branch [ci skip]
00e02f7 
3419b9b Add setting to save camera photos in documents folder (PR #3667, Fixes #3542)
@Xenius97 Xenius97 mentioned this pull request Jan 7, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tederis tederis tederis left review comments

@FileEX FileEX FileEX approved these changes

@botder botder botder approved these changes

+3 more reviewers

@TheNormalnij TheNormalnij TheNormalnij left review comments

@Fernando-A-Rocha Fernando-A-Rocha Fernando-A-Rocha approved these changes

@TracerDS TracerDS TracerDS approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.7

Development

Successfully merging this pull request may close these issues.

Add the possibility that the camera (weapon) does not create screenshots in a folder

7 participants

@ffsPLASMA @TracerDS @TheNormalnij @tederis @FileEX @Fernando-A-Rocha @botder