Refactor GetWeaponProperty & GetOriginalWeaponProperty to new parser

[FileEX]

No description provided.

[FileEX]

After the second commit, the function does not work correctly. The second call to StringToEnum overwrites the weaponType variable, setting its value to 0. This is exactly the same case as in the mentioned PR

[Merlin]

This happens because you changed the eWeaponSkill enum to be 1 byte wide. However, StringToEnum casts outResult to eDummy, which is 4 bytes. In CEnumInfo::FindValue, setting outResult will overwrite 4 bytes, unintentionally modifying other overlapping variables. At least, that's what I think is happening. I didn't debug anything.

[FileEX]

This happens because you changed the eWeaponSkill enum to be 1 byte wide. However, StringToEnum casts outResult to eDummy, which is 4 bytes. In CEnumInfo::FindValue, setting outResult will overwrite 4 bytes, unintentionally modifying other overlapping variables. At least, that's what I think is happening. I didn't debug anything.

You're probably right. EnumToString/StringToEnum qualifies for refactoring because it causes the above issues by casting to eDummy with a size of 4 bytes if the passed enum has a smaller size

[Dutchman101]

Related to #4089 (comment), it's no longer bugged after 3ab068b and the refactor does solve some issues.