chore: update phpstan and fix warnings

Author: ecastro98

composer.json

@@ -26,7 +26,7 @@
         "infection/infection": "^0.11.5",
         "php-http/mock-client": "^1.1",
         "phpspec/prophecy": "~1.0",
-        "phpstan/phpstan": "^0.10.7",
+        "phpstan/phpstan": "^0.12",
         "phpunit/phpunit": "^7"
     },
     "config": {

composer.lock

@@ -15,10 +15,13 @@
 namespace MultiTheftAuto\Sdk\Factory;
 
 use MultiTheftAuto\Sdk\Model\Element;
-use MultiTheftAuto\Sdk\Model\Resource;
+use MultiTheftAuto\Sdk\Model\Resource as MtaResource;
 
 class ElementFactory
 {
+    /**
+     * @return Element|MtaResource|string
+     */
     public static function fromServer(string $value)
     {
         $valuePrefix = substr($value, 0, 3);
@@ -27,8 +30,8 @@ public static function fromServer(string $value)
             case Element::SERVER_PREFIX: {
                 return Element::fromServer($value);
             }
-            case Resource::SERVER_PREFIX: {
-                return Resource::fromServer($value);
+            case MtaResource::SERVER_PREFIX: {
+                return MtaResource::fromServer($value);
             }
         }
 

src/Factory/ElementFactory.php

@@ -25,7 +25,7 @@ class Element implements JsonSerializable
 
     public const SERVER_PREFIX = '^E^';
 
-    public function __construct(string $id)
+    final public function __construct(string $id)
     {
         $this->id = $id;
     }

src/Model/Element.php

@@ -38,7 +38,7 @@ class Resource implements JsonSerializable
     public const SERVER_PREFIX = '^R^';
     protected const UNDEFINED_SERVICE_EXCEPTION = 'Resource %s can not be called because Mta service is not defined';
 
-    public function __construct(string $name, MtaService $mtaService = null)
+    final public function __construct(string $name, MtaService $mtaService = null)
     {
         $this->name = $name;
         $this->mtaService = $mtaService;
@@ -51,14 +51,16 @@ public static function fromServer(string $value): self
         return new static($name);
     }
 
-    public function getName()
+    public function getName(): string
     {
         return $this->name;
     }
 
     /**
+     * @param mixed  ...$arguments
+     *
      * @throws \Http\Client\Exception
-     * @throws Exception
+     * @return array|mixed[]|null
      */
     public function call(string $function, ...$arguments)
     {

src/Model/Resource.php

@@ -28,6 +28,12 @@ public function __construct(MtaResource $resource)
         $this->resource = $resource;
     }
 
+    /**
+     * @param mixed[]  $arguments
+     *
+     * @throws \Http\Client\Exception
+     * @return array|mixed[]|null
+     */
     public function __call(string $name, array $arguments)
     {
         return $this->resource->call($name, ...$arguments);

src/Model/ResourceCall.php

@@ -81,12 +81,16 @@ public function getResourcesInstance(): Resources
 
     /**
      * @codeCoverageIgnore
+     * @return array|mixed[]|null
      */
     public static function getInput(): ?array
     {
         return ElementTransformer::fromServer(Input::get()) ?? null;
     }
 
+    /**
+     * @param mixed ...$arguments
+     */
     public static function doReturn(...$arguments): void
     {
         echo ElementTransformer::toServer($arguments);

src/Mta.php

@@ -46,12 +46,10 @@ public function validate(): void
             case 401:
                 {
                     throw new AccessDeniedException();
-                    break;
                 }
             case 404:
                 {
                     throw new NotFoundStatusException();
-                    break;
                 }
             case 200:
                 {

src/Response/HttpStatusValidator.php

@@ -68,8 +68,11 @@ public function __construct(
     }
 
     /**
+     * @param mixed[]  $arguments
+     *
      * @throws \Http\Client\Exception
      * @throws \Exception
+     * @return mixed[]|null
      */
     public function callFunction(string $resourceName, string $functionName, array $arguments = []): ?array
     {

src/Service/MtaService.php

@@ -18,6 +18,9 @@
 
 abstract class ElementTransformer
 {
+    /**
+     * @return mixed[]|null
+     */
     public static function fromServer(?string $dataFromServer): ?array
     {
         if (empty($dataFromServer)) {
@@ -33,11 +36,18 @@ public static function fromServer(?string $dataFromServer): ?array
         return $data;
     }
 
+    /**
+     * @param mixed[] $inputData
+     *
+     */
     public static function toServer(array $inputData): string
     {
         return json_encode($inputData) ?: '';
     }
 
+    /**
+     * @param mixed[]|string $value
+     */
     private static function stringValuesToObjects(&$value): void
     {
         if (is_array($value)) {