Skip to content

Commit 0495b38

Browse files
xLivexLive
authored
admin & admin2: set hasObjectPermissionTo defaultPermission to false (#663)
1 parent 18d4c2f commit 0495b38

File tree

10 files changed

+48
-48
lines changed

10 files changed

+48
-48
lines changed

‎[admin]/admin/server/admin_commands.lua‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ end
5858
function aCommand ( admin, command, ... )
5959
local call = _commands[command]
6060
if ( call ) then
61-
if ( hasObjectPermissionTo ( admin, "command."..call.action ) ) then
61+
if ( hasObjectPermissionTo ( admin, "command."..call.action, false ) ) then
6262
local arg, errormsg = aCommandToArgs ( { ... }, call.args )
6363
if not errormsg then
6464
if ( call.type == "player" ) then triggerEvent ( "aPlayer", admin, arg[1], call.action, arg[2], arg[3], arg[4] )

‎[admin]/admin/server/admin_screenshot.lua‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ addEventHandler("aScreenShot",root,
4242
if not isElement(admin) then return end
4343
if not action then return end
4444
local right = rights[action]
45-
if not right or not hasObjectPermissionTo(admin,"command."..right) then return end
45+
if not right or not hasObjectPermissionTo(admin,"command."..right, false) then return end
4646
if action == "new" then
4747
if not isElement(player) then return end
4848
if screenshots[player] then

‎[admin]/admin/server/admin_server.lua‎

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ function aHandleIP2CUpdate()
5353

5454
for playerID = 1, #playersTable do
5555
local playerElement = playersTable[playerID]
56-
local hasAdminPermission = hasObjectPermissionTo(playerElement, "general.adminpanel")
56+
local hasAdminPermission = hasObjectPermissionTo(playerElement, "general.adminpanel", false)
5757

5858
if hasAdminPermission then
5959

@@ -89,7 +89,7 @@ addEventHandler ( "onResourceStart", root, function ( resource )
8989
if ( resource ~= getThisResource() ) then
9090
local resourceName = getResourceName(resource)
9191
for id, player in ipairs(getElementsByType("player")) do
92-
if ( hasObjectPermissionTo ( player, "general.tab_resources" ) ) then
92+
if ( hasObjectPermissionTo ( player, "general.tab_resources", false ) ) then
9393
triggerClientEvent ( player, "aClientResourceStart", root, resourceName )
9494
end
9595
end
@@ -107,7 +107,7 @@ addEventHandler ( "onResourceStart", root, function ( resource )
107107
aSetupCommands()
108108
for id, player in ipairs ( getElementsByType ( "player" ) ) do
109109
aPlayerInitialize ( player )
110-
if ( hasObjectPermissionTo ( player, "general.adminpanel" ) ) then
110+
if ( hasObjectPermissionTo ( player, "general.adminpanel", false ) ) then
111111
notifyPlayerLoggedIn(player)
112112
end
113113
end
@@ -257,7 +257,7 @@ addEventHandler ( "onResourceStop", root, function ( resource )
257257
if ( resource ~= getThisResource() ) then
258258
local resourceName = getResourceName(resource)
259259
for id, player in ipairs(getElementsByType("player")) do
260-
if ( hasObjectPermissionTo ( player, "general.tab_resources" ) ) then
260+
if ( hasObjectPermissionTo ( player, "general.tab_resources", false ) ) then
261261
triggerClientEvent ( player, "aClientResourceStop", root, resourceName )
262262
end
263263
end
@@ -431,8 +431,8 @@ addEventHandler ( "onPlayerJoin", root, function ()
431431
end
432432
aPlayerInitialize ( source )
433433
for id, player in ipairs(getElementsByType("player")) do
434-
if ( hasObjectPermissionTo ( player, "general.adminpanel" ) ) then
435-
triggerClientEvent ( player, "aClientPlayerJoin", source, getPlayerIP ( source ), getPlayerAccountName ( source ), getPlayerSerial ( source ), hasObjectPermissionTo ( source, "general.adminpanel" ), aPlayers[source]["country"] )
434+
if ( hasObjectPermissionTo ( player, "general.adminpanel", false ) ) then
435+
triggerClientEvent ( player, "aClientPlayerJoin", source, getPlayerIP ( source ), getPlayerAccountName ( source ), getPlayerSerial ( source ), hasObjectPermissionTo ( source, "general.adminpanel", false ), aPlayers[source]["country"] )
436436
end
437437
end
438438
setPedGravity ( source, getGravity() )
@@ -512,7 +512,7 @@ function aPlayerSerialCheck ( player, result )
512512
end
513513

514514
addEventHandler ( "onPlayerLogin", root, function ( previous, account, auto )
515-
if ( hasObjectPermissionTo ( source, "general.adminpanel" ) ) then
515+
if ( hasObjectPermissionTo ( source, "general.adminpanel", false ) ) then
516516
triggerEvent ( "aPermissions", source )
517517
notifyPlayerLoggedIn( source )
518518
end
@@ -545,7 +545,7 @@ end )
545545
addCommandHandler ( "unregister", function ( player, command, arg1 )
546546
local username = arg1 or ""
547547
local result = "failed - No permission"
548-
if ( hasObjectPermissionTo ( player, "function.removeAccount" ) ) then
548+
if ( hasObjectPermissionTo ( player, "function.removeAccount", false ) ) then
549549
local account = getAccount ( username )
550550
if not account then
551551
result = "failed - Does not exist"
@@ -574,7 +574,7 @@ function getAdminNameForLog(player)
574574
end
575575

576576
function aAdminMenu ( player, command )
577-
if ( hasObjectPermissionTo ( player, "general.adminpanel" ) ) then
577+
if ( hasObjectPermissionTo ( player, "general.adminpanel", false ) ) then
578578
triggerClientEvent ( player, "aClientAdminMenu", root )
579579
aPlayers[player]["chat"] = true
580580
end
@@ -631,7 +631,7 @@ addEventHandler ( "aTeam", root, function ( action, name, r, g, b )
631631
if checkClient( "command."..action, source, 'aTeam', action ) then
632632
return
633633
end
634-
if ( hasObjectPermissionTo ( client or source, "command."..action ) ) then
634+
if ( hasObjectPermissionTo ( client or source, "command."..action, false ) ) then
635635
mdata = ""
636636
if ( action == "createteam" ) then
637637
local success
@@ -954,7 +954,7 @@ addEventHandler ( "aPlayer", root, function ( player, action, data, additional,
954954
if not isElement( player ) then
955955
return -- Ignore if player is no longer valid
956956
end
957-
if ( hasObjectPermissionTo ( client or source, "command."..action ) ) then
957+
if ( hasObjectPermissionTo ( client or source, "command."..action, false ) ) then
958958
local admin = source
959959
local mdata = ""
960960
local more = ""
@@ -1168,7 +1168,7 @@ addEventHandler ( "aPlayer", root, function ( player, action, data, additional,
11681168
action = "adminr"
11691169
end
11701170
for id, p in ipairs ( getElementsByType ( "player" ) ) do
1171-
if ( hasObjectPermissionTo ( p, "general.adminpanel" ) ) then triggerEvent ( "aSync", p, "admins" ) end
1171+
if ( hasObjectPermissionTo ( p, "general.adminpanel", false ) ) then triggerEvent ( "aSync", p, "admins" ) end
11721172
end
11731173
else
11741174
outputChatBox ( "Error - Admin group not initialized. Please reinstall admin resource.", source, 255, 0 ,0 )
@@ -1263,7 +1263,7 @@ end
12631263
addEvent ( "aVehicle", true )
12641264
addEventHandler ( "aVehicle", root, function ( player, action, data )
12651265
if checkClient( "command."..action, source, 'aVehicle', action ) then return end
1266-
if ( hasObjectPermissionTo ( client or source, "command."..action ) ) then
1266+
if ( hasObjectPermissionTo ( client or source, "command."..action, false ) ) then
12671267
if ( not player ) then return end
12681268
local vehicle = getPedOccupiedVehicle ( player )
12691269
if ( vehicle ) then
@@ -1347,7 +1347,7 @@ addEvent ( "aResource", true )
13471347
addEventHandler ( "aResource", root, function ( name, action )
13481348
if checkClient( "command."..action, source, 'aResource', action ) then return end
13491349
local pname = getPlayerName ( source )
1350-
if ( hasObjectPermissionTo ( client or source, "command."..action ) ) then
1350+
if ( hasObjectPermissionTo ( client or source, "command."..action, false ) ) then
13511351
local text = ""
13521352
if ( action == "start" ) then
13531353
if ( startResource ( getResourceFromName ( name ), true ) ) then
@@ -1385,7 +1385,7 @@ end )
13851385
addEvent ( "aServer", true )
13861386
addEventHandler ( "aServer", root, function ( action, data, data2 )
13871387
if checkClient( "command."..action, source, 'aServer', action ) then return end
1388-
if ( hasObjectPermissionTo ( client or source, "command."..action ) ) then
1388+
if ( hasObjectPermissionTo ( client or source, "command."..action, false ) ) then
13891389
local mdata = tostring ( data )
13901390
local mdata2 = ""
13911391
if ( action == "setgame" ) then
@@ -1536,7 +1536,7 @@ function ( action, data )
15361536
aReports[id].read = false
15371537
-- PM all admins to say a new message has arrived
15381538
for _, p in ipairs ( getElementsByType ( "player" ) ) do
1539-
if ( hasObjectPermissionTo ( p, "general.adminpanel" ) ) then
1539+
if ( hasObjectPermissionTo ( p, "general.adminpanel", false ) ) then
15401540
outputChatBox( "New Admin message from " .. aReports[id].author .. " (" .. aReports[id].subject .. ")", p, 255, 0, 0 )
15411541
end
15421542
end
@@ -1545,7 +1545,7 @@ function ( action, data )
15451545
table.remove( aReports, 1 )
15461546
end
15471547
end
1548-
if ( hasObjectPermissionTo ( client or source, "general.adminpanel" ) ) then
1548+
if ( hasObjectPermissionTo ( client or source, "general.adminpanel", false ) ) then
15491549
if ( action == "get" ) then
15501550
triggerClientEvent ( source, "aMessage", source, "get", aReports, get("reportsEnabled") )
15511551
elseif ( action == "read" ) then
@@ -1561,7 +1561,7 @@ function ( action, data )
15611561
end
15621562
end
15631563
for id, p in ipairs ( getElementsByType ( "player" ) ) do
1564-
if ( hasObjectPermissionTo ( p, "general.adminpanel" ) ) then
1564+
if ( hasObjectPermissionTo ( p, "general.adminpanel", false ) ) then
15651565
triggerEvent ( "aSync", p, "messages" )
15661566
end
15671567
end
@@ -1572,7 +1572,7 @@ addEvent ( "aModdetails", true )
15721572
addEventHandler ( "aModdetails", resourceRoot, function ( action, player )
15731573
if source ~= resourceRoot then return end
15741574
if checkClient( false, client, 'aModdetails', action ) then return end
1575-
if ( hasObjectPermissionTo ( client, "general.adminpanel" ) ) then
1575+
if ( hasObjectPermissionTo ( client, "general.adminpanel", false ) ) then
15761576
if ( action == "get" ) then
15771577
triggerClientEvent ( client, "aModdetails", resourceRoot, "get", getPlayerModInfo(player), player )
15781578
end
@@ -1582,7 +1582,7 @@ end )
15821582
addEvent ( "aBans", true )
15831583
addEventHandler ( "aBans", root, function ( action, data, arg1, arg2, arg3 )
15841584
if checkClient( "command."..action, source, 'aBans', action ) then return end
1585-
if ( hasObjectPermissionTo ( client or source, "command."..action ) ) then
1585+
if ( hasObjectPermissionTo ( client or source, "command."..action, false ) ) then
15861586
local mdata = ""
15871587
local more = ""
15881588
if ( action == "banip" ) then
@@ -1686,17 +1686,17 @@ function checkClient(checkAccess,player,...)
16861686
end
16871687
if checkAccess and g_Prefs.securitylevel >= 1 then
16881688
if type(checkAccess) == 'string' then
1689-
if hasObjectPermissionTo ( player, checkAccess ) then
1689+
if hasObjectPermissionTo ( player, checkAccess, false ) then
16901690
return false -- Access ok
16911691
end
1692-
if hasObjectPermissionTo ( player, "general.adminpanel" ) then
1692+
if hasObjectPermissionTo ( player, "general.adminpanel", false ) then
16931693
local desc = table.concat({...}," ")
16941694
local ipAddress = getPlayerIP(player)
16951695
outputDebugString( "Admin security - Client does not have required rights ("..checkAccess.."). " .. tostring(ipAddress) .. " (" .. tostring(desc) .. ")" )
16961696
return true -- Low risk fail - Can't do specific command, but has access to admin panel
16971697
end
16981698
end
1699-
if not hasObjectPermissionTo ( player, "general.adminpanel" ) then
1699+
if not hasObjectPermissionTo ( player, "general.adminpanel", false ) then
17001700
local desc = table.concat({...}," ")
17011701
local ipAddress = getPlayerIP(client or player)
17021702
outputDebugString( "Admin security - Client without admin panel rights trigged an admin panel event. " .. tostring(ipAddress) .. " (" .. tostring(desc) .. ")", 2 )

‎[admin]/admin/server/admin_sync.lua‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ function aSynchCoroutineFunc( type, data, typeOfTag, banSearchTag )
1515
local cor = aSyncCoroutine
1616
local tableOut = {}
1717
local theSource = root
18-
if client and not hasObjectPermissionTo ( client, "general.adminpanel" ) then
18+
if client and not hasObjectPermissionTo ( client, "general.adminpanel", false ) then
1919
type = "loggedout"
2020
elseif ( type == "player" ) then
2121
if not isElement( data ) then return end
@@ -51,14 +51,14 @@ function aSynchCoroutineFunc( type, data, typeOfTag, banSearchTag )
5151
tableOut[player]["accountname"] = getPlayerAccountName ( player ) or "N/A"
5252
tableOut[player]["serial"] = getPlayerSerial ( player )
5353
tableOut[player]["country"] = aPlayers[player]["country"]
54-
tableOut[player]["admin"] = hasObjectPermissionTo ( player, "general.adminpanel" )
54+
tableOut[player]["admin"] = hasObjectPermissionTo ( player, "general.adminpanel", false )
5555
tableOut[player]["acdetected"] = getPlayerACDetectedList( player )
5656
tableOut[player]["d3d9dll"] = getPlayerD3D9DLLHash( player )
5757
tableOut[player]["imgmodsnum"] = getPlayerModCount( player )
5858
end
5959
end
6060
elseif ( type == "resources" ) then
61-
if not hasObjectPermissionTo( source, "general.tab_resources" ) then
61+
if not hasObjectPermissionTo( source, "general.tab_resources", false ) then
6262
return
6363
end
6464
local resourceTable = getResources()
@@ -100,7 +100,7 @@ function aSynchCoroutineFunc( type, data, typeOfTag, banSearchTag )
100100
for id, player in ipairs(getElementsByType("player")) do
101101
if isElement(player) and aPlayers[player] then
102102
tableOut[player] = {}
103-
tableOut[player]["admin"] = hasObjectPermissionTo ( player, "general.adminpanel" )
103+
tableOut[player]["admin"] = hasObjectPermissionTo ( player, "general.adminpanel", false )
104104
if ( tableOut[player]["admin"] ) then
105105
tableOut[player]["chat"] = aPlayers[player]["chat"]
106106
end
@@ -281,7 +281,7 @@ end )
281281
addEvent ( "aPermissions", true )
282282
addEventHandler ( "aPermissions", root, function()
283283
if checkClient( false, source, 'aPermissions' ) then return end
284-
if ( hasObjectPermissionTo ( source, "general.adminpanel" ) ) then
284+
if ( hasObjectPermissionTo ( source, "general.adminpanel", false ) ) then
285285
local tableOut = {}
286286
for gi, group in ipairs ( aclGroupList() ) do
287287
for oi, object in ipairs ( aclGroupListObjects ( group ) ) do

‎[admin]/admin2/server/admin_ACL.lua‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ local aACLFunctions = {
256256
addEvent(EVENT_ACL, true)
257257
addEventHandler(EVENT_ACL, root,
258258
function(action, ...)
259-
if not hasObjectPermissionTo( client, "general.tab_acl" ) then
259+
if not hasObjectPermissionTo( client, "general.tab_acl", false ) then
260260
outputServerLog( ( "[ADMIN SECURITY]: Player %s [%s %s] attempted to tamper with server ACL without proper rights" ):format( client.name, client.ip, client.serial ) )
261261
return
262262
end

‎[admin]/admin2/server/admin_bans.lua‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ local function handleBanRequest(action, data)
115115
end
116116

117117
-- Permissions check
118-
if not hasObjectPermissionTo(source, "command."..action) then
118+
if not hasObjectPermissionTo(source, "command."..action, false) then
119119
outputChatBox("Access denied for '" .. tostring(action) .. "'", source, 255, 168, 0)
120120
return
121121
end

‎[admin]/admin2/server/admin_commands.lua‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ function aCommand(admin, command, ...)
5555
end
5656
local call = _commands[command]
5757
if (call) then
58-
if (hasObjectPermissionTo(admin, "command." .. call.action)) then
58+
if (hasObjectPermissionTo(admin, "command." .. call.action, false)) then
5959
arg2 = aCommandToArgs({...}, call.args)
6060
if (call.type == "player") then
6161
triggerEvent("aPlayer", admin, arg2[1], call.action, arg2[2], arg2[3])

‎[admin]/admin2/server/admin_server.lua‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ function aHandleIP2CUpdate()
3737

3838
for playerID = 1, #playersTable do
3939
local playerElement = playersTable[playerID]
40-
local hasAdminPermission = hasObjectPermissionTo(playerElement, "general.adminpanel")
40+
local hasAdminPermission = hasObjectPermissionTo(playerElement, "general.adminpanel", false)
4141

4242
if hasAdminPermission then
4343

@@ -77,7 +77,7 @@ addEventHandler(
7777
if (resource ~= getThisResource()) then
7878
local resourceName = getResourceName(resource)
7979
for id, player in ipairs(getElementsByType("player")) do
80-
if (hasObjectPermissionTo(player, "general.tab_resources")) then
80+
if (hasObjectPermissionTo(player, "general.tab_resources", false)) then
8181
triggerClientEvent(player, "aClientResourceStart", root, resourceName)
8282
end
8383
end
@@ -104,7 +104,7 @@ addEventHandler(
104104
if (resource ~= getThisResource()) then
105105
local resourceName = getResourceName(resource)
106106
for id, player in ipairs(getElementsByType("player")) do
107-
if (hasObjectPermissionTo(player, "general.tab_resources")) then
107+
if (hasObjectPermissionTo(player, "general.tab_resources", false)) then
108108
triggerClientEvent(player, "aClientResourceStop", root, resourceName)
109109
end
110110
end
@@ -124,7 +124,7 @@ addEventHandler(
124124
function()
125125
aPlayerInitialize(source)
126126
for id, player in ipairs(getElementsByType("player")) do
127-
if (hasObjectPermissionTo(player, "general.adminpanel")) then
127+
if (hasObjectPermissionTo(player, "general.adminpanel", false)) then
128128
triggerClientEvent(
129129
player,
130130
"aClientPlayerJoin",
@@ -207,7 +207,7 @@ addEventHandler(
207207
"aTeam",
208208
root,
209209
function(action, name, ...)
210-
if (hasObjectPermissionTo(client, "command." .. action)) then
210+
if (hasObjectPermissionTo(client, "command." .. action, false)) then
211211
local func = aFunctions.team[action]
212212
if (func) then
213213
local result, mdata1, mdata2 = func(name, ...)
@@ -229,7 +229,7 @@ addEventHandler(
229229
"aPlayer",
230230
root,
231231
function(player, action, ...)
232-
if (hasObjectPermissionTo(client, "command." .. action)) then
232+
if (hasObjectPermissionTo(client, "command." .. action, false)) then
233233
local mdata1, mdata2
234234
local func = aFunctions.player[action]
235235
if (func) then
@@ -257,7 +257,7 @@ addEventHandler(
257257
if (not vehicle) then
258258
return
259259
end
260-
if (hasObjectPermissionTo(client, "command." .. action)) then
260+
if (hasObjectPermissionTo(client, "command." .. action, false)) then
261261
local mdata1, mdata2
262262
local func = aFunctions.vehicle[action]
263263
if (func) then
@@ -298,7 +298,7 @@ addEventHandler(
298298
if (not resource) then
299299
return
300300
end
301-
if (hasObjectPermissionTo(client, "command." .. action)) then
301+
if (hasObjectPermissionTo(client, "command." .. action, false)) then
302302
local func = aFunctions.resource[action]
303303
if (func) then
304304
local result, mdata1, mdata2 = func(resource, ...)
@@ -320,7 +320,7 @@ addEventHandler(
320320
"aServer",
321321
root,
322322
function(action, ...)
323-
if (hasObjectPermissionTo(client, "command." .. action)) then
323+
if (hasObjectPermissionTo(client, "command." .. action, false)) then
324324
local func = aFunctions.server[action]
325325
if (func) then
326326
local result, mdata1, mdata2 = func(...)
@@ -395,7 +395,7 @@ addEventHandler(
395395
triggerClientEvent(client, "aMessage", client, "get", aReports)
396396
end
397397
for id, p in ipairs(getElementsByType("player")) do
398-
if (hasObjectPermissionTo(p, "general.adminpanel")) then
398+
if (hasObjectPermissionTo(p, "general.adminpanel", false)) then
399399
triggerEvent(EVENT_SYNC, p, SYNC_MESSAGES)
400400
end
401401
end

‎[admin]/admin2/server/admin_session.lua‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ local aSessions = {}
1212
addCommandHandler(
1313
"adminpanel",
1414
function(player)
15-
if (hasObjectPermissionTo(player, "general.adminpanel")) then
15+
if (hasObjectPermissionTo(player, "general.adminpanel", false)) then
1616
triggerClientEvent(player, "aClientAdminMenu", root)
1717
aPlayers[player]["chat"] = true
1818
end
@@ -23,7 +23,7 @@ addEventHandler(
2323
"onPlayerLogin",
2424
root,
2525
function(previous, account, auto)
26-
if (hasObjectPermissionTo(source, "general.adminpanel")) then
26+
if (hasObjectPermissionTo(source, "general.adminpanel", false)) then
2727
if (aPlayers[source]["aLoaded"]) then
2828
triggerEvent(EVENT_SESSION, source, SESSION_UPDATE)
2929
end
@@ -42,7 +42,7 @@ addEventHandler(
4242
end
4343
end
4444
if (type == SESSION_UPDATE or type == SESSION_START) then
45-
if (hasObjectPermissionTo(client or source, "general.adminpanel")) then
45+
if (hasObjectPermissionTo(client or source, "general.adminpanel", false)) then
4646
local tableOut = {}
4747
local account = "user." .. getAccountName(getPlayerAccount(client or source))
4848
for gi, group in ipairs(aclGroupList()) do

0 commit comments

Comments
 (0)