Update favourites.xml saving after user issue report

Author: Dutchman101

[editor]/editor_gui/client/browser/browser.lua

@@ -93,7 +93,11 @@ function startBrowser ( elementType, callback, initialCat, initialModel, remembe
 	if not cachedElements[elementType] then
 		cachedElements[elementType] = cacheElements(xmlFiles[elementType], elementCatalogs[elementType])
 	end
-	cachedElements["favourite"] = cacheElements(xmlFiles["favourite"], elementCatalogs[elementType])
+	if xmlFiles["favourite"] then
+		cachedElements["favourite"] = cacheElements(xmlFiles["favourite"], elementCatalogs[elementType])
+	else
+		cachedElements["favourite"] = {}
+	end
 	browser.enabled = true
 	returnX,returnY,returnZ,returnRX,returnRY,returnRZ = getCameraMatrix()
 	returnInterior = getCameraInterior()
@@ -361,8 +365,13 @@ end
 
 addEventHandler("onClientResourceStop", resourceRoot,
 	function ()
-		xmlSaveFile(xmlFiles["favourite"])
-		xmlUnloadFile(xmlFiles["favourite"])
+		if xmlFiles["favourite"] then
+			local success = xmlSaveFile(xmlFiles["favourite"])
+			if not success then
+				outputDebugString("[editor_gui] ERROR: Failed to save favourites.xml on resource stop", 1)
+			end
+			xmlUnloadFile(xmlFiles["favourite"])
+		end
 	end)
 
 local lastCallTick = 0
@@ -371,6 +380,9 @@ function toggleFavourite (gridlist)
 	if getTickCount() - lastCallTick < 500 then return end --Since it always gets called at least twice per click
 	lastCallTick = getTickCount()
 	if not gridlist then return end
+	if not xmlFiles["favourite"] then return end
+	if not catNodes or not catNodes[2] then return end
+	if not initiatedType or not elementCatalogs[initiatedType] then return end
 	local item = guiGridListGetSelectedItem(gridlist)
 	local name = guiGridListGetItemText(gridlist, item, 1)
 	local model = guiGridListGetItemText(gridlist, item, 2)
@@ -384,6 +396,10 @@ function toggleFavourite (gridlist)
 					break
 				end
 			end
+			local success = xmlSaveFile(xmlFiles["favourite"])
+			if not success then
+				outputDebugString("[editor_gui] ERROR: Failed to save favourites.xml after removing item", 1)
+			end
 			cachedElements["favourite"] = cacheElements(xmlFiles["favourite"], elementCatalogs[initiatedType])
 			catNodes[2] = cachedElements["favourite"]
 			if browserGUI.dropdown:getRow() == 2 then
@@ -397,6 +413,10 @@ function toggleFavourite (gridlist)
 	xmlNodeSetAttribute(node, "model", model)
 	xmlNodeSetAttribute(node, "name", name)
 	xmlNodeSetAttribute(node, "keywords", "")
+	local success = xmlSaveFile(xmlFiles["favourite"])
+	if not success then
+		outputDebugString("[editor_gui] ERROR: Failed to save favourites.xml after adding item", 1)
+	end
 	cachedElements["favourite"] = cacheElements(xmlFiles["favourite"], elementCatalogs[initiatedType])
 	catNodes[2] = cachedElements["favourite"]
 	outputMessage(elementCatalogs[initiatedType]:gsub("^%l", string.upper) .. " '" .. name .. "' added to favourites.", 50, 255, 50)