internetradio: addendum to buffer added in 254700c

now localPlayer can change speaker volume without any delay (locally, the effect is instant on client, but it still needs to be processed by server for others), also more to stylistic/consistency improvements

Author: sacr1ficez

[gameplay]/internetradio/logic/handle_radio/CHandleRadio.lua

@@ -57,7 +57,7 @@ end
 local function syncSpeakerVolume()
 	local speakerVolume = getLocalSpeakerVolume()
 
-	triggerServerEvent("onServerEditVolume", localPlayer, speakerVolume)
+	triggerServerEvent("onServerSetSpeakerVolume", localPlayer, speakerVolume)
 	speakerVolumeSyncTimer = false
 
 	return true
@@ -72,6 +72,10 @@ local function requestSpeakerVolumeSync()
 		speakerVolumeSyncTimer = setTimer(syncSpeakerVolume, speakerTimerInterval, 1)
 	end
 
+	local speakerVolume = getLocalSpeakerVolume()
+
+	setPlayerSpeakerVolume(localPlayer, speakerVolume) -- set volume locally so localPlayer could adjust it without any delay (this will be sanity corrected by server later on)
+
 	return true
 end
 
@@ -160,7 +164,7 @@ end
 
 function onClientGUIClickCreateSpeaker()
 	local streamURL, errorCode = getStreamURLFromEdit()
-	local volume = guiScrollBarGetScrollPosition(RADIO_GUI["Volume"]) / 100
+	local speakerVolume = getLocalSpeakerVolume()
 
 	if (not streamURL) then
 		local textToDisplay = errorCode or "SPEAKER: Invalid URL, please check your input!"
@@ -176,7 +180,7 @@ function onClientGUIClickCreateSpeaker()
 		return false
 	end
 
-	triggerServerEvent("onServerCreateSpeaker", localPlayer, streamURL, volume)
+	triggerServerEvent("onServerCreateSpeaker", localPlayer, streamURL, speakerVolume)
 end
 
 function onClientGUIScrollVolume()
@@ -244,15 +248,15 @@ function setPlayerSpeakerData(playerElement, speakerData)
 	return true
 end
 
-function setPlayerSpeakerVolume(playerElement, volume)
+function setPlayerSpeakerVolume(playerElement, speakerVolume)
 	local validElement = isElement(playerElement)
 	local speakerSound = speakerSounds[playerElement]
 
 	if (not validElement or not speakerSound) then
 		return false
 	end
 
-	setSoundVolume(speakerSound, volume)
+	setSoundVolume(speakerSound, speakerVolume)
 
 	return true
 end
@@ -368,11 +372,11 @@ end
 addEvent("onClientCreateSpeaker", true)
 addEventHandler("onClientCreateSpeaker", root, onClientCreateSpeaker)
 
-function onClientUpdateVolume(speakerVolume)
+function onClientSetSpeakerVolume(speakerVolume)
 	setPlayerSpeakerVolume(source, speakerVolume)
 end
-addEvent("onClientUpdateVolume", true)
-addEventHandler("onClientUpdateVolume", root, onClientUpdateVolume)
+addEvent("onClientSetSpeakerVolume", true)
+addEventHandler("onClientSetSpeakerVolume", root, onClientSetSpeakerVolume)
 
 function onClientToggleSpeaker(pauseState)
 	setPlayerSpeakerPaused(source, pauseState)

[gameplay]/internetradio/logic/handle_radio/SHandleRadio.lua

@@ -27,7 +27,7 @@ function updateSpeakerVolume(playerElement, speakerVolume)
 	end
 
 	playerSpeakerData.speakerVolume = speakerVolume
-	triggerClientEvent(root, "onClientUpdateVolume", playerElement, speakerVolume)
+	triggerClientEvent(root, "onClientSetSpeakerVolume", playerElement, speakerVolume)
 
 	return true
 end
@@ -144,7 +144,7 @@ end
 addEvent("onServerCreateSpeaker", true)
 addEventHandler("onServerCreateSpeaker", root, onServerCreateSpeaker)
 
-function onServerEditVolume(speakerVolume)
+function onServerSetSpeakerVolume(speakerVolume)
 	if (not client or client ~= source) then
 		return false
 	end
@@ -169,8 +169,8 @@ function onServerEditVolume(speakerVolume)
 
 	updateSpeakerVolume(client, speakerVolume)
 end
-addEvent("onServerEditVolume", true)
-addEventHandler("onServerEditVolume", root, onServerEditVolume)
+addEvent("onServerSetSpeakerVolume", true)
+addEventHandler("onServerSetSpeakerVolume", root, onServerSetSpeakerVolume)
 
 function onServerToggleSpeaker()
 	if (not client) then