admin: some improvements (#315)

* Update admin_main.lua

* fix the "hide sensitive datas" checkbox width

* Update [admin]/admin/client/gui/admin_main.lua

Co-authored-by: Gabrielius Laurinavičius <[email protected]>

* make "hide sensitive data" ignore the "Output admin messages to chat box" setting

* make "hide sensitive data" ignore "Output player information to console"

* make "hide sensitive data" disable bans and admin Chat tabs

* hide sensitive data and color codes in reports window

* remove color codes from screenshots window

* remove color codes from kick and unmute dialog

* remove color codes from mute window

* fix message box not showing entire messages

* remove extra space from "set dimension" input box

* update server password label when change "hide sensitive data" state

* Update [admin]/admin/client/gui/admin_message.lua

Co-authored-by: Gabrielius Laurinavičius <[email protected]>

* Update [admin]/admin/client/gui/admin_message.lua

Co-authored-by: Gabrielius Laurinavičius <[email protected]>

* fix "Name" label not showing the entire text

Co-authored-by: Breno Danyel <[email protected]>
Co-authored-by: Gabrielius Laurinavičius <[email protected]>

Author: 3 people

[admin]/admin/client/gui/admin_inputbox.lua

@@ -463,7 +463,7 @@ function aMuteInputBox ( player )
 		guiSetText ( aMuteInputRadio2s[i], dur>0 and secondsToTimeDesc(dur) or "Until reconnect" )
 	end
 
-	guiSetText ( aMuteInputForm, "Mute player " .. getPlayerName(player) )
+	guiSetText ( aMuteInputForm, "Mute player " .. removeColorCoding(getPlayerName(player)) )
 	guiSetText ( aMuteInputLabel, "Enter the mute reason" )
 	aHideFloaters()
 	guiSetVisible ( aMuteInputForm, true )

[admin]/admin/client/gui/admin_main.lua

@@ -43,7 +43,7 @@ function aViewMessage ( id )
 		guiSetText ( aViewMessageCategory, _messages[id].category )
 		guiSetText ( aViewMessageForm, _messages[id].subject )
 		guiSetText ( aViewMessageTime, _messages[id].time )
-		guiSetText ( aViewMessageAuthor, _messages[id].author )
+		guiSetText ( aViewMessageAuthor, removeColorCoding( _messages[id].author ) )
 		guiSetText ( aViewMessageText, _messages[id].text )
 		guiSetVisible ( aViewMessageForm, true )
 		local isVisible = _messages[id].suspect ~= nil
@@ -68,9 +68,20 @@ function aViewSuspectInfo ( button )
 						aSuspectInfo = nil
 					end, false)
 
-					local infoMemo = guiCreateMemo(0.04, 0.1, 0.96, 0.75, "Nickname: "..suspectInfo.name.."\nAccount name: "..suspectInfo.username.."\nIP: "
-						..suspectInfo.ip.."\nSerial: "..suspectInfo.serial.."\nMTA version: "..suspectInfo.version.."\n\nChat log:\n"..suspectInfo.chatLog,
-					true, aSuspectInfo)
+					local displayInfo = {
+
+						'Nickname: '.. removeColorCoding(suspectInfo.name),
+						'Account name: '.. getSensitiveText(suspectInfo.username),
+						'IP: '.. getSensitiveText(suspectInfo.ip),
+						'Serial: '.. getSensitiveText(suspectInfo.serial),
+						'MTA version: '.. suspectInfo.version,
+						'\nChat log:\n' .. suspectInfo.chatLog,
+
+					}
+
+					local text = table.concat(displayInfo, '\n')
+
+					local infoMemo = guiCreateMemo(0.04, 0.1, 0.96, 0.75, text, true, aSuspectInfo)
 					guiMemoSetReadOnly(infoMemo, true)
 				else
 					aMessageBox ( "error", "This report does have any suspect information." )

[admin]/admin/client/gui/admin_message.lua

@@ -41,7 +41,7 @@ function aMessageBox ( type, message, action, vOne, vTwo, vThree )
 		guiSetSize ( aMessageLabel, 350, 100, false )
 	else
 		guiSetSize ( aMessageForm, 300, 120, false )
-		guiSetSize ( aMessageLabel, 150, 16, false )
+		guiSetSize ( aMessageLabel, 150, 30, false )
 	end
 	local sx, sy = guiGetSize ( aMessageForm, false )
 	guiSetPosition ( aMessageOk, sx / 2 - 22, 90, false )

[admin]/admin/client/gui/admin_messagebox.lua

@@ -66,7 +66,7 @@ function aMessagesSync ( action, data )
 			if ( message.read ) then guiGridListSetItemText ( aMessagesList, row, 2, message.subject, false, false )
 			else guiGridListSetItemText ( aMessagesList, row, 2, "* "..message.subject, false, false ) end
 			guiGridListSetItemText ( aMessagesList, row, 3, message.time, false, false )
-			guiGridListSetItemText ( aMessagesList, row, 4, message.author, false, false )
+			guiGridListSetItemText ( aMessagesList, row, 4, removeColorCoding(message.author), false, false )
 		end
 	end
 end

[admin]/admin/client/gui/admin_messages.lua

@@ -120,8 +120,8 @@ addEventHandler("aClientScreenShot",resourceRoot,
 			guiGridListClear ( aScreenShotList )
 			for i,screenshot in ipairs (data) do
 				local row = guiGridListAddRow(aScreenShotList)
-				guiGridListSetItemText(aScreenShotList,row,1,screenshot.player,false,false)
-				guiGridListSetItemText(aScreenShotList,row,2,screenshot.admin,false,false)
+				guiGridListSetItemText(aScreenShotList,row,1,removeColorCoding(screenshot.player),false,false)
+				guiGridListSetItemText(aScreenShotList,row,2,removeColorCoding(screenshot.admin),false,false)
 				guiGridListSetItemText(aScreenShotList,row,3,screenshot.realtime,false,false)
 				guiGridListSetItemData(aScreenShotList,row,1,screenshot.id)
 			end