From 22b297a648c8960068374756f7d5219a6937142e Mon Sep 17 00:00:00 2001 From: Breno Danyel Date: Wed, 9 Jun 2021 18:35:01 -0300 Subject: [PATCH 01/26] replace give admin button with permissions widget --- [admin]/admin/client/gui/admin_main.lua | 17 +-- [admin]/admin/client/gui/admin_messagebox.lua | 2 + .../admin/client/gui/admin_permissions.lua | 121 ++++++++++++++++++ [admin]/admin/meta.xml | 1 + [admin]/admin/server/admin_server.lua | 25 +++- 5 files changed, 155 insertions(+), 11 deletions(-) create mode 100644 [admin]/admin/client/gui/admin_permissions.lua diff --git a/[admin]/admin/client/gui/admin_main.lua b/[admin]/admin/client/gui/admin_main.lua index 854c02d65..035f00213 100644 --- a/[admin]/admin/client/gui/admin_main.lua +++ b/[admin]/admin/client/gui/admin_main.lua @@ -75,7 +75,7 @@ function aAdminMenu () aTab1.Nick = guiCreateButton ( 0.71, 0.260, 0.13, 0.04, "Set Nick", true, aTab1.Tab ) aTab1.Shout = guiCreateButton ( 0.85, 0.260, 0.13, 0.04, "Shout!", true, aTab1.Tab, "shout" ) - aTab1.Admin = guiCreateButton ( 0.71, 0.305, 0.27, 0.04, "Give admin rights", true, aTab1.Tab, "setgroup" ) + aTab1.ManagePerms = guiCreateButton ( 0.71, 0.305, 0.27, 0.04, "Manage permissions", true, aTab1.Tab, "setgroup" ) local y = 0.03 -- Start y coord local A = 0.045 -- Large line gap @@ -538,11 +538,6 @@ function aAdminRefresh () guiSetText ( aTab1.Vehicle, "Vehicle: Foot" ) guiSetText ( aTab1.VehicleHealth, "Vehicle Health: 0%" ) end - if ( aPlayers[player]["admin"] ) then - guiSetText(aTab1.Admin, "Revoke admin rights") - else - guiSetText(aTab1.Admin, "Give admin rights") - end return player end end @@ -1041,9 +1036,12 @@ function aClientClick ( button ) elseif ( source == aTab1.VehicleBlow ) then triggerServerEvent ( "aVehicle", localPlayer, player, "blowvehicle" ) elseif ( source == aTab1.VehicleDestroy ) then triggerServerEvent ( "aVehicle", localPlayer, player, "destroyvehicle" ) elseif ( source == aTab1.VehicleCustomize ) then aVehicleCustomize ( player ) - elseif ( source == aTab1.Admin ) then - if ( aPlayers[player]["admin"] ) then aMessageBox ( "warning", "Revoke admin rights from "..name.."?", "revokeAdmin", player ) - else aMessageBox ( "warning", "Give admin rights to "..name.."?", "giveAdmin", player ) end + elseif ( source == aTab1.ManagePerms ) then + if (aPlayers[player]['accountname'] ~= 'guest') then + aPermissions.Show(player) + else + aMessageBox ( "error", "This player is not logged in!" ) + end elseif ( source == aTab1.ACModDetails ) then aViewModdetails(player) end @@ -1290,7 +1288,6 @@ function aAdminReloadInfos() guiSetText ( aTab1.ACModInfo, "Img Mods: N/A" ) guiSetText ( aTab1.Mute, "Mute" ) guiSetText ( aTab1.Freeze, "Freeze" ) - guiSetText ( aTab1.Admin, "Give admin rights" ) guiSetText ( aTab1.Health, "Health: 0%" ) guiSetText ( aTab1.Armour, "Armour: 0%" ) guiSetText ( aTab1.Skin, "Skin: N/A" ) diff --git a/[admin]/admin/client/gui/admin_messagebox.lua b/[admin]/admin/client/gui/admin_messagebox.lua index 4a416266e..aec97d8ca 100644 --- a/[admin]/admin/client/gui/admin_messagebox.lua +++ b/[admin]/admin/client/gui/admin_messagebox.lua @@ -147,6 +147,8 @@ function runMessageAction(action) aSpectator.Close(false) elseif (action == "deleteTeam") then triggerServerEvent("aTeam", localPlayer, "destroyteam", varOne) + elseif (action == "updatePlayerACLGroup") then + aPermissions.PerformAction(varOne, varTwo, varThree) end end diff --git a/[admin]/admin/client/gui/admin_permissions.lua b/[admin]/admin/client/gui/admin_permissions.lua new file mode 100644 index 000000000..0ca59210c --- /dev/null +++ b/[admin]/admin/client/gui/admin_permissions.lua @@ -0,0 +1,121 @@ +--[[********************************** +* +* Multi Theft Auto - Admin Panel +* +* client\gui\admin_permissions.lua +* +* Original File by lil_Toady +* +**************************************]] +aPermissions = { + Form = nil, + SelectedPlayer = nil, +} + +addEvent('aPermissionsSync', true) +addEvent('aOnPermissionsChange', true) + +function aPermissions.Show(player) + if (not aPermissions.Form) then + local x, y = guiGetScreenSize() + aPermissions.Form = guiCreateWindow(x / 2 - 130, y / 2 - 125, 260, 250, ("Manage %s's permissions"):format(getPlayerName(player)), false) + guiSetAlpha(aPermissions.Form, 1) + + aPermissions.Label = guiCreateLabel(0.03, 0.09, 0.94, 0.07, "Use double-click to change the current state", true, aPermissions.Form) + guiLabelSetHorizontalAlign(aPermissions.Label, "center") + + aPermissions.List = guiCreateGridList(0.03, 0.18, 0.94, 0.70, true, aPermissions.Form) + guiGridListAddColumn(aPermissions.List, "ACL Group", 0.65) + guiGridListAddColumn(aPermissions.List, "Has?", 0.2) + + aPermissions.Update = guiCreateButton(0.03, 0.88, 0.47, 0.09, "Refresh", true, aPermissions.Form) + aPermissions.Hide = guiCreateButton(0.5, 0.88, 0.47, 0.09, "Close", true, aPermissions.Form) + + addEventHandler('aPermissionsSync', localPlayer, aPermissions.onSync) + addEventHandler('aOnPermissionsChange', localPlayer, aPermissions.Refresh) + addEventHandler("onClientGUIClick", aPermissions.Form, aPermissions.onClick) + addEventHandler("onClientGUIDoubleClick", aPermissions.Form, aPermissions.onDoubleClick) + + --Register With Admin Form + aRegister("PlayerPermissions", aPermissions.Form, aPermissions.Show, aPermissions.Close) + end + aPermissions.SelectedPlayer = player + aPermissions.Refresh() + guiSetVisible(aPermissions.Form, true) + guiBringToFront(aPermissions.Form) +end + +function aPermissions.onSync(targetPlayer, permissions) + if (targetPlayer == aPermissions.SelectedPlayer) then + guiGridListClear(aPermissions.List) + for group, state in pairs(permissions) do + local row = guiGridListAddRow(aPermissions.List) + guiGridListSetItemText(aPermissions.List, row, 1, group, false, false) + guiGridListSetItemText(aPermissions.List, row, 2, state and 'Yes' or 'No', false, false) + guiGridListSetItemData(aPermissions.List, row, 1, group) + guiGridListSetItemData(aPermissions.List, row, 2, state) + end + end +end + +function aPermissions.Close(destroy) + if (destroy) then + if (aPermissions.Form) then + destroyElement(aPermissions.Form) + aPermissions.Form = nil + removeEventHandler('aPermissionsSync', localPlayer, aPermissions.onSync) + removeEventHandler('aOnPermissionsChange', localPlayer, aPermissions.Refresh) + end + else + guiSetVisible(aPermissions.Form, false) + end + aPermissions.SelectedPlayer = nil +end + +function aPermissions.onClick(button) + if (button == 'left') then + if (source == aPermissions.Hide) then + aPermissions.Close() + elseif (source == aPermissions.Update) then + aPermissions.Refresh() + end + end +end + +function aPermissions.onDoubleClick(button) + if (button == 'left') then + local player = aPermissions.SelectedPlayer + if isElement(player) then + local selectedItem = guiGridListGetSelectedItem(aPermissions.List) + if (selectedItem > -1) then + local selectedGroup = guiGridListGetItemData(aPermissions.List, selectedItem, 1) + local currentState = guiGridListGetItemData(aPermissions.List, selectedItem, 2) + local confirmStr + if currentState then + confirmStr = ('Are you sure you want to remove "%s" from the "%s" group?'):format(getPlayerName(player), selectedGroup) + else + confirmStr = ('Are you sure you want to add "%s" to the "%s" group?'):format(getPlayerName(player), selectedGroup) + end + aMessageBox ( "question", confirmStr, "updatePlayerACLGroup", player, selectedGroup, not currentState ) + end + else + aPermissions.Close(false) + messageBox("Player not found!", MB_WARNING) + end + end +end + +function aPermissions.PerformAction(player, groupName, newState) + local playerAccount = player and aPlayers[player] and aPlayers[player]['accountname'] + if playerAccount and (playerAccount ~= 'guest') then + triggerServerEvent('aAdmin', localPlayer, newState and 'acladd' or 'aclremove', 'object', groupName, 'user.'..playerAccount, true) + end +end + +function aPermissions.Refresh() + local player = aPermissions.SelectedPlayer + if isElement(player) and (aPermissions.List) then + guiGridListClear(aPermissions.List) + triggerServerEvent('aAdmin', localPlayer, "sync", "playeraclgroups", player) + end +end diff --git a/[admin]/admin/meta.xml b/[admin]/admin/meta.xml index 6f28e0a25..212e8818b 100644 --- a/[admin]/admin/meta.xml +++ b/[admin]/admin/meta.xml @@ -26,6 +26,7 @@