Skip to content

Commit 124e8b6

Browse files
committed
Possibly std::ios::binary helps with streams on Windows
1 parent 2498c57 commit 124e8b6

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

test/perftest/rapidjsontest.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ TEST_F(RapidJson, SIMD_SUFFIX(ReaderParse_DummyHandler_FileReadStream_Unbuffered
489489

490490
TEST_F(RapidJson, IStreamWrapper) {
491491
for (size_t i = 0; i < kTrialCount; i++) {
492-
std::ifstream is(filename_);
492+
std::ifstream is(filename_, std::ios::in | std::ios::binary);
493493
char buffer[65536];
494494
IStreamWrapper isw(is, buffer, sizeof(buffer));
495495
while (isw.Take() != '\0')
@@ -500,7 +500,7 @@ TEST_F(RapidJson, IStreamWrapper) {
500500

501501
TEST_F(RapidJson, IStreamWrapper_Unbuffered) {
502502
for (size_t i = 0; i < kTrialCount; i++) {
503-
std::ifstream is(filename_);
503+
std::ifstream is(filename_, std::ios::in | std::ios::binary);
504504
IStreamWrapper isw(is);
505505
while (isw.Take() != '\0')
506506
;
@@ -513,7 +513,7 @@ TEST_F(RapidJson, IStreamWrapper_Setbuffered) {
513513
std::ifstream is;
514514
char buffer[65536];
515515
is.rdbuf()->pubsetbuf(buffer, sizeof(buffer));
516-
is.open(filename_);
516+
is.open(filename_, std::ios::in | std::ios::binary);
517517
IStreamWrapper isw(is);
518518
while (isw.Take() != '\0')
519519
;
@@ -523,7 +523,7 @@ TEST_F(RapidJson, IStreamWrapper_Setbuffered) {
523523

524524
TEST_F(RapidJson, SIMD_SUFFIX(ReaderParse_DummyHandler_IStreamWrapper)) {
525525
for (size_t i = 0; i < kTrialCount; i++) {
526-
std::ifstream is(filename_);
526+
std::ifstream is(filename_, std::ios::in | std::ios::binary);
527527
char buffer[65536];
528528
IStreamWrapper isw(is, buffer, sizeof(buffer));
529529
BaseReaderHandler<> h;
@@ -535,7 +535,7 @@ TEST_F(RapidJson, SIMD_SUFFIX(ReaderParse_DummyHandler_IStreamWrapper)) {
535535

536536
TEST_F(RapidJson, SIMD_SUFFIX(ReaderParse_DummyHandler_IStreamWrapper_Unbuffered)) {
537537
for (size_t i = 0; i < kTrialCount; i++) {
538-
std::ifstream is(filename_);
538+
std::ifstream is(filename_, std::ios::in | std::ios::binary);
539539
IStreamWrapper isw(is);
540540
BaseReaderHandler<> h;
541541
Reader reader;
@@ -549,7 +549,7 @@ TEST_F(RapidJson, SIMD_SUFFIX(ReaderParse_DummyHandler_IStreamWrapper_Setbuffere
549549
std::ifstream is;
550550
char buffer[65536];
551551
is.rdbuf()->pubsetbuf(buffer, sizeof(buffer));
552-
is.open(filename_);
552+
is.open(filename_, std::ios::in | std::ios::binary);
553553
IStreamWrapper isw(is);
554554
BaseReaderHandler<> h;
555555
Reader reader;

0 commit comments

Comments
 (0)