Skip to content

Commit 4e1c736

Browse files
committed
CMake: avoid neeless variable expansion
CMake will automatically expand strings that are variable names in if().
1 parent 17ae6ff commit 4e1c736

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

CMakeLists.txt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ if(CCACHE_FOUND)
5151
endif()
5252
endif(CCACHE_FOUND)
5353

54-
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
55-
if(${RAPIDJSON_ENABLE_INSTRUMENTATION_OPT})
56-
if("${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "powerpc" OR "${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "ppc64" OR "${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "ppc64le")
54+
if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
55+
if(RAPIDJSON_ENABLE_INSTRUMENTATION_OPT)
56+
if(CMAKE_SYSTEM_PROCESSOR STREQUAL "powerpc" OR CMAKE_SYSTEM_PROCESSOR STREQUAL "ppc64" OR CMAKE_SYSTEM_PROCESSOR STREQUAL "ppc64le")
5757
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mcpu=native")
5858
else()
5959
#FIXME: x86 is -march=native, but doesn't mean every arch is this option. To keep original project's compatibility, I leave this except POWER.
@@ -84,7 +84,7 @@ if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
8484
endif()
8585
endif()
8686
elseif (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
87-
if("${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "powerpc" OR "${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "ppc64" OR "${CMAKE_SYSTEM_PROCESSOR}" STREQUAL "ppc64le")
87+
if(CMAKE_SYSTEM_PROCESSOR STREQUAL "powerpc" OR CMAKE_SYSTEM_PROCESSOR STREQUAL "ppc64" OR CMAKE_SYSTEM_PROCESSOR STREQUAL "ppc64le")
8888
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mcpu=native")
8989
else()
9090
#FIXME: x86 is -march=native, but doesn't mean every arch is this option. To keep original project's compatibility, I leave this except POWER.
@@ -105,7 +105,7 @@ elseif (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
105105
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=undefined")
106106
endif()
107107
endif()
108-
elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
108+
elseif (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
109109
add_definitions(-D_CRT_SECURE_NO_WARNINGS=1)
110110
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /EHsc")
111111
elseif (CMAKE_CXX_COMPILER_ID MATCHES "XL")

0 commit comments

Comments
 (0)