Skip to content

Commit c4117c6

Browse files
StilesCrisisStilesCrisis
authored andcommitted
Put in unit tests to catch parser failure
Noticed that the reader could over-consume “NaN” if token terminated in the middle.
1 parent 933eb83 commit c4117c6

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

test/unittest/readertest.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1832,6 +1832,10 @@ TEST(Reader, ParseNanAndInfinity) {
18321832
TEST_NAN_INF("Infinity", inf);
18331833
TEST_NAN_INF("-Inf", -inf);
18341834
TEST_NAN_INF("-Infinity", -inf);
1835+
TEST_NAN_INF_ERROR(kParseErrorValueInvalid, "NInf", 1);
1836+
TEST_NAN_INF_ERROR(kParseErrorValueInvalid, "NaInf", 1);
1837+
TEST_NAN_INF_ERROR(kParseErrorValueInvalid, "INan", 1);
1838+
TEST_NAN_INF_ERROR(kParseErrorValueInvalid, "InNan", 1);
18351839
TEST_NAN_INF_ERROR(kParseErrorValueInvalid, "nan", 1);
18361840
TEST_NAN_INF_ERROR(kParseErrorValueInvalid, "-nan", 1);
18371841
TEST_NAN_INF_ERROR(kParseErrorValueInvalid, "NAN", 1);

0 commit comments

Comments
 (0)