Fix implicit signed/unsigned conversion and a small glitch in the error computation - part 2

abolz · abolz · commit fc85fbeef008 · 2018-06-15T13:44:43.000+02:00
diff --git a/include/rapidjson/internal/strtod.h b/include/rapidjson/internal/strtod.h
@@ -165,7 +165,7 @@ inline bool StrtodDiyFp(const char* decimals, int dLen, int dExp, double* result
         int adjustment = dExp - actualExp;
         RAPIDJSON_ASSERT(adjustment >= 1 && adjustment < 8);
         v = v * kPow10[adjustment - 1];
-        if (dLen + adjustment > 19u) // has more digits than decimal digits in 64-bit
+        if (dLen + adjustment > 19) // has more digits than decimal digits in 64-bit
             error += kUlp / 2;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,7 @@ inline bool StrtodDiyFp(const char* decimals, int dLen, int dExp, double* result`
`165`	`165`	`int adjustment = dExp - actualExp;`
`166`	`166`	`RAPIDJSON_ASSERT(adjustment >= 1 && adjustment < 8);`
`167`	`167`	`v = v * kPow10[adjustment - 1];`
`168`		`- if (dLen + adjustment > 19u) // has more digits than decimal digits in 64-bit`
	`168`	`+ if (dLen + adjustment > 19) // has more digits than decimal digits in 64-bit`
`169`	`169`	`error += kUlp / 2;`
`170`	`170`	`}`
`171`	`171`