Merge pull request #7101 from multiversx/do-not-vote-on-closed-proposal

do not vote on closed proposal

Author: sstanculeanu

vm/systemSmartContracts/governance.go

@@ -1266,7 +1266,7 @@ func (g *governanceContract) saveGeneralProposal(reference []byte, generalPropos
 	return nil
 }
 
-// getValidProposal returns a proposal from storage if it exists, or it is still valid/in-progress
+// getValidProposal returns a proposal from storage if it exists and it is still valid/in-progress
 func (g *governanceContract) getValidProposal(nonce *big.Int) (*GeneralProposal, error) {
 	proposal, err := g.getProposalFromNonce(nonce)
 	if err != nil {
@@ -1282,6 +1282,10 @@ func (g *governanceContract) getValidProposal(nonce *big.Int) (*GeneralProposal,
 		return nil, vm.ErrVotedForAnExpiredProposal
 	}
 
+	if proposal.Closed {
+		return nil, vm.ErrVotedForAnExpiredProposal
+	}
+
 	return proposal, nil
 }