MX-17306 Cleanup, added miniblock timeline gap indicator

Author: mradian1

multiversx_cross_shard_analysis/miniblock_data.py

@@ -138,8 +138,6 @@ def get_data_for_header_report(self) -> dict[int, dict[int, Any]]:
                 if "proposed" in mention_type:
                     continue
 
-                print(f"Processing miniblock {mb_hash} mentioned in header nonce {header.get('nonce')} round {header.get('round')} epoch {header.get('epoch')} shard {header.get('shard_id')}")
-                # epoch = header.get('epoch')
                 if epoch not in report:
                     report[epoch] = {}
 
@@ -160,7 +158,30 @@ def get_data_for_header_report(self) -> dict[int, dict[int, Any]]:
 
                 report[epoch][shard_id][nonce][round_number].append((label, mb_hash[:15] + '...', color))
 
-        with open('debug_miniblock_header_report.json', 'w') as f:
-            import json
-            json.dump(report, f, indent=4, default=lambda o: o.name if isinstance(o, Enum) else str(o))
-        return report
+        return sort_report(report)
+
+
+def sort_report(report: dict[int, dict[int, Any]]) -> dict[int, dict[int, Any]]:
+    out: dict[int, dict[int, Any]] = {}
+
+    for epoch in sorted(report.keys()):
+        out[epoch] = {}
+
+        # metas hard (4294967295) last
+        shard_ids = sorted(
+            report[epoch].keys(),
+            key=lambda s: (s == 4294967295, s),
+        )
+
+        for shard_id in shard_ids:
+            out[epoch][shard_id] = {}
+
+            for nonce in sorted(report[epoch][shard_id].keys()):
+                rounds = report[epoch][shard_id][nonce]
+
+                out[epoch][shard_id][nonce] = {
+                    r: rounds[r]
+                    for r in sorted(rounds.keys())
+                }
+
+    return out

multiversx_cross_shard_analysis/miniblocks_timeline_report.py

@@ -123,6 +123,15 @@ def build_stack_for_round(items: list[tuple[str, str, colors.Color]], col_width:
 # -----------------------------
 # miniblock section
 # -----------------------------
+def has_round_gap(rounds: list[int]) -> bool:
+    if len(rounds) < 2:
+        return False
+    for a, b in zip(rounds, rounds[1:]):
+        if b != a + 1:
+            return True
+    return False
+
+
 def build_miniblock_section(miniblock: dict[str, Any], page_usable_width: float) -> list[Flowable]:
     flow = []
     styles = getSampleStyleSheet()
@@ -143,9 +152,8 @@ def build_miniblock_section(miniblock: dict[str, Any], page_usable_width: float)
         flow.append(Spacer(1, 6))
         return flow
 
-    first_r = miniblock.get("first_seen_round", 0)
-    last_r = miniblock.get("last_seen_round", 0)
-    rounds = list(range(first_r, last_r + 1))
+    mentioned = miniblock.get("mentioned", {})
+    rounds = sorted(mentioned.keys())
 
     num_cols = max(1, len(rounds))
     col_width = page_usable_width / num_cols
@@ -160,24 +168,26 @@ def build_miniblock_section(miniblock: dict[str, Any], page_usable_width: float)
         items = mentioned.get(r, [])
         drawing = build_stack_for_round(items, col_width)
         cells.append(drawing)
+    gap = has_round_gap(rounds)
 
     tbl = Table(
         [header, cells],
         colWidths=[col_width] * num_cols,
         hAlign="LEFT",
     )
 
-    tbl.setStyle(
-        TableStyle(
-            [
-                ("GRID", (0, 0), (-1, -1), 0.25, colors.grey),
-                ("BACKGROUND", (0, 0), (-1, 0), colors.whitesmoke),
-                ("ALIGN", (0, 0), (-1, 0), "CENTER"),
-                ("FONTSIZE", (0, 0), (-1, 0), ROUND_HEADER_FONT),
-                ("VALIGN", (0, 1), (-1, -1), "TOP"),
-            ]
-        )
-    )
+    style = [
+        ("GRID", (0, 0), (-1, -1), 0.25, colors.grey),
+        ("BACKGROUND", (0, 0), (-1, 0), colors.whitesmoke),
+        ("ALIGN", (0, 0), (-1, 0), "CENTER"),
+        ("FONTSIZE", (0, 0), (-1, 0), ROUND_HEADER_FONT),
+        ("VALIGN", (0, 1), (-1, -1), "TOP"),
+    ]
+
+    if gap:
+        style.append(("BOX", (0, 0), (-1, -1), 2, colors.red))
+
+    tbl.setStyle(TableStyle(style))
 
     flow.append(tbl)
     flow.append(Spacer(1, 8))