Merge pull request #2260 from multiversx/utf8-lossy

vm - signal error utf-8 lossy

Author: andrei-marinica

chain/vm/src/host/vm_hooks/vh_handler/vh_error.rs

@@ -1,23 +1,16 @@
 use multiversx_chain_core::types::ReturnCode;
 use multiversx_chain_vm_executor::VMHooksEarlyExit;
 
-use crate::{
-    host::vm_hooks::{VMHooksContext, vh_early_exit::early_exit_vm_error},
-    types::RawHandle,
-};
+use crate::{host::vm_hooks::VMHooksContext, types::RawHandle};
 
 use super::VMHooksHandler;
 
 impl<C: VMHooksContext> VMHooksHandler<C> {
     pub fn signal_error(&mut self, message: &[u8]) -> Result<(), VMHooksEarlyExit> {
-        match String::from_utf8(message.to_owned()) {
-            Ok(message_string) => {
-                self.error_trace(&message_string);
-                Err(VMHooksEarlyExit::new(ReturnCode::UserError.as_u64())
-                    .with_message(message_string))
-            }
-            Err(_) => Err(early_exit_vm_error("error message utf-8 error")),
-        }
+        let message_string = String::from_utf8_lossy(message);
+        self.error_trace(&message_string);
+        Err(VMHooksEarlyExit::new(ReturnCode::UserError.as_u64())
+            .with_message(message_string.to_string()))
     }
 
     pub fn signal_error_from_buffer(

framework/base/src/types/managed/basic/managed_buffer.rs

@@ -583,11 +583,8 @@ impl<M: ManagedTypeApi> core::fmt::Debug for ManagedBuffer<M> {
 
 impl<M: ManagedTypeApi> core::fmt::Display for ManagedBuffer<M> {
     fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
-        use crate::contract_base::ErrorHelper;
-
-        let s = alloc::string::String::from_utf8(self.to_boxed_bytes().into_vec())
-            .unwrap_or_else(|err| ErrorHelper::<M>::signal_error_with_message(err.as_bytes()));
-
+        let bytes = self.to_boxed_bytes();
+        let s = alloc::string::String::from_utf8_lossy(bytes.as_slice());
         s.fmt(f)
     }
 }