updated basic features tests

Author: andrei-marinica

chain/vm/src/host/vm_hooks/vh_handler/vh_crypto.rs

@@ -61,7 +61,7 @@ impl<C: VMHooksContext> VMHooksHandler<C> {
             crypto_functions::verify_ed25519(key, message, signature)
         };
         if !sig_valid {
-            return Err(early_exit_vm_error(vm_err_msg::CRYPTO_INVALID_SIGNATURE));
+            return Err(early_exit_vm_error(vm_err_msg::CRYPTO_ED25519_ERROR));
         }
 
         Ok(())

chain/vm/src/vm_err_msg.rs

@@ -27,3 +27,4 @@ pub const ERROR_BYTES_EXCEED_UINT64: &str = "bytes cannot be parsed as uint64";
 pub const PROMISES_TOKENIZE_FAILED: &str = "tokenize failed";
 
 pub const CRYPTO_INVALID_SIGNATURE: &str = "invalid signature";
+pub const CRYPTO_ED25519_ERROR: &str = "ed25519 verify error";

contracts/feature-tests/basic-features/scenarios/crypto_verify_bls.scen.json

@@ -58,7 +58,7 @@
             "expect": {
                 "out": [],
                 "status": "10",
-                "message": "str:signature is invalid",
+                "message": "str:bls verify error",
                 "logs": "*",
                 "gas": "*",
                 "refund": "*"

contracts/feature-tests/basic-features/scenarios/crypto_verify_bls_aggregated_signature.scen.json

@@ -70,7 +70,7 @@
             "expect": {
                 "out": [],
                 "status": "10",
-                "message": "str:signature is invalid",
+                "message": "str:bls verify error",
                 "logs": "*",
                 "gas": "*",
                 "refund": "*"

contracts/feature-tests/basic-features/scenarios/crypto_verify_bls_share.scen.json

@@ -58,7 +58,7 @@
             "expect": {
                 "out": [],
                 "status": "10",
-                "message": "str:signature is invalid",
+                "message": "str:bls verify error",
                 "logs": "*",
                 "gas": "*",
                 "refund": "*"

contracts/feature-tests/basic-features/scenarios/crypto_verify_ed25519.scen.json

@@ -55,7 +55,7 @@
             "expect": {
                 "out": [],
                 "status": "10",
-                "message": "str:invalid signature",
+                "message": "str:ed25519 verify error",
                 "logs": "*",
                 "gas": "*",
                 "refund": "*"

contracts/feature-tests/basic-features/scenarios/crypto_verify_secp256r1.scen.json

@@ -57,7 +57,7 @@
             "expect": {
                 "out": [],
                 "status": "10",
-                "message": "str:signature is invalid",
+                "message": "str:secp256k1 verify error",
                 "logs": "*",
                 "gas": "*",
                 "refund": "*"

contracts/feature-tests/basic-features/tests/basic_features_scenario_go_test.rs

@@ -80,21 +80,25 @@ fn crypto_sha_256_go() {
 }
 
 #[test]
+#[ignore = "TODO: error message changed, unignore after Barnard"]
 fn crypto_verify_bls_go() {
     world().run("scenarios/crypto_verify_bls.scen.json");
 }
 
 #[test]
+#[ignore = "TODO: error message changed, unignore after Barnard"]
 fn crypto_verify_bls_aggregated_signature_go() {
     world().run("scenarios/crypto_verify_bls_aggregated_signature.scen.json");
 }
 
 #[test]
+#[ignore = "TODO: error message changed, unignore after Barnard"]
 fn crypto_verify_bls_share_go() {
     world().run("scenarios/crypto_verify_bls_share.scen.json");
 }
 
 #[test]
+#[ignore = "TODO: error message changed, unignore after Barnard"]
 fn crypto_verify_ed_25519_go() {
     world().run("scenarios/crypto_verify_ed25519.scen.json");
 }
@@ -105,6 +109,7 @@ fn crypto_verify_secp_256_k_1_go() {
 }
 
 #[test]
+#[ignore = "TODO: error message changed, unignore after Barnard"]
 fn crypto_verify_secp_256_r_1_go() {
     world().run("scenarios/crypto_verify_secp256r1.scen.json");
 }

contracts/feature-tests/big-float-features/scenarios/big_float_operator_checks.scen.json

@@ -32,7 +32,7 @@
             "expect": {
                 "out": [],
                 "status": "10",
-                "message": "str:this big Float operation is not permitted while doing float.Add"
+                "message": "str:big float decode error"
             }
         },
         {
@@ -72,7 +72,7 @@
             "expect": {
                 "out": [],
                 "status": "10",
-                "message": "str:this big Float operation is not permitted while doing float.Sub"
+                "message": "str:big float decode error"
             }
         }
     ]

contracts/feature-tests/big-float-features/tests/big_float_scenario_go_test.rs

@@ -45,6 +45,7 @@ fn big_float_new_from_sci_go() {
 }
 
 #[test]
+#[ignore = "TODO: error message changed, unignore after Barnard"]
 fn big_float_operator_checks_go() {
     world().run("scenarios/big_float_operator_checks.scen.json");
 }