bug: `.get()` returns blockchain state instead of latest sate on internal call

[laciferin2024]

Code

• Max Participants is set to one.
• A participant is pushed https://github.com/laciferin2024/lottery.multiversex/blob/debug/participants-state-draw-winner/src/lottery.rs#L87
• Calls (draw_winner) : https://github.com/laciferin2024/lottery.multiversex/blob/debug/participants-state-draw-winner/src/lottery.rs#L94

Code fails at https://github.com/laciferin2024/lottery.multiversex/blob/debug/participants-state-draw-winner/src/lottery.rs#L123 due to index error.

My Analysis

The state is not committed to the shard. But participants.len() is updated cuz the code enters the loop. The code fails with commented code iteration via .iter() as well.

Run at your end

just deploy
just i place_bet 1

Trace:

https://devnet-explorer.multiversx.com/transactions/c9f72471daf6f92e1d46a30ab84918609d54ccab999911fbf028ffe93d01724b

[laciferin2024]

Note that I hotfixed the issue by passing the state vector as parameter to the internal call: https://github.com/laciferin2024/lottery.multiversex/blob/a5329f8ab07c2b66d31d8a7ef0b3749a6931ebca/src/lottery.rs#L130

[mihaicalinluca]

VecMapper index starts at 1:
https://docs.multiversx.com/developers/developer-reference/storage-mappers/#vecmapper

[laciferin2024]

Done using .iter() from now on. But i would like to know the rationale behind going 1 over 0. @mihaicalinluca a request to work on the error msg please.