-
-
Notifications
You must be signed in to change notification settings - Fork 40
Description
The deployment manifest files deploy/namespaced/deployment.yaml and deploy/cluster_scoped/deployment.yaml contain a reference to the Docker image as follows:
# Replace this with the built image name
image: mumoshu/aws-secret-operator:v0.1.0
I find the v prefix in the image tag misleading. Pulling an old image like v0.1.0 requires the v prefix but pulling a recent image like 0.3.2 does not require the v prefix and in fact it fails if it is added. I tried with other recent images (e.g. 0.2.4) and they also fail with the v prefix.
My suggestion would be to replace v0.1.0 with a more recent image like 0.3.2 in both deployment manifest files. The version number doesn't have to be kept in sync with every release but using a more recent image would make it more seamless for users to update it. The first time I did it I was puzzled because I simply replaced the version number and didn't understand why it failed until I discovered the v prefix had to be removed.