PR #2
Open
PR #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-gomez
requested changes
Apr 9, 2025
| @@ -0,0 +1,30 @@ | |||
| S C:\Users\gisel\desktop\challenge_1> git add challenge1.py | |||
ch1.py
Outdated
|
|
||
| #los primeros 10 items | ||
|
|
||
| import feedparser |
There was a problem hiding this comment.
los imports siempre van al principio del archivo, nunca al final
ch1.py
Outdated
| print(f"Link: {link}") | ||
|
|
||
| #Guardar un archivo JSON | ||
| import json |
There was a problem hiding this comment.
los imports siempre van al principio del archivo, nunca al final
ch1.py
Outdated
Comment on lines
7
to
11
| if r.status_code == 200: | ||
| xml_content = r.text | ||
| print(xml_content) | ||
| else: | ||
| print("error") |
There was a problem hiding this comment.
Aquí no ocupa imprimir el contenido de la pagina si está checando el status code.
Suggested change
| if r.status_code == 200: | |
| xml_content = r.text | |
| print(xml_content) | |
| else: | |
| print("error") | |
| if r.status_code != 200: | |
| print(f"error with status code {r.status_code}") |
|
Muy bien 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ver si ahora sí asuuu