👨‍💻📦 build QDMI generators and spdlog as shared libraries on install

Signed-off-by: burgholzer <burgholzer@me.com>

Author: burgholzer

cmake/ExternalDependencies.cmake

@@ -94,12 +94,21 @@ set(SPDLOG_SYSTEM_INCLUDES
     ON
     CACHE INTERNAL "Treat the library headers like system headers")
 cmake_dependent_option(SPDLOG_INSTALL "Install spdlog library" ON "MQT_CORE_INSTALL" OFF)
+cmake_dependent_option(SPDLOG_BUILD_SHARED "Build spdlog as shared library" ON
+                       "BUILD_MQT_CORE_SHARED_LIBS" OFF)
 FetchContent_Declare(spdlog URL ${SPDLOG_URL} FIND_PACKAGE_ARGS ${SPDLOG_VERSION})
 list(APPEND FETCH_PACKAGES spdlog)
 
 # Make all declared dependencies available.
 FetchContent_MakeAvailable(${FETCH_PACKAGES})
 
+# Ensure external shared libraries end up in a common lib layout used by our RUNPATH
+if(TARGET spdlog)
+  set_target_properties(
+    spdlog PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_LIBDIR}"
+                      ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_LIBDIR}")
+endif()
+
 # Patch for spdlog cmake files to be installed in a common cmake directory
 if(SPDLOG_INSTALL)
   include(GNUInstallDirs)

src/qdmi/na/CMakeLists.txt

@@ -13,11 +13,7 @@ set(TARGET_NAME ${MQT_CORE_TARGET_NAME}-qdmi-na-device-gen)
 if(NOT TARGET ${TARGET_NAME})
 
   # Add library for device generation
-  #
-  # Note: We use a static library here to avoid issues with RPATH and finding the executable during
-  # the build process in Python builds
-  add_library(${TARGET_NAME} STATIC)
-  add_library(MQT::CoreQDMINaDeviceGen ALIAS ${TARGET_NAME})
+  add_mqt_core_library(${TARGET_NAME} ALIAS_NAME QDMINaDeviceGen)
 
   # add sources to target
   target_sources(${TARGET_NAME} PRIVATE Generator.cpp)
@@ -26,27 +22,20 @@ if(NOT TARGET ${TARGET_NAME})
   target_sources(${TARGET_NAME} PUBLIC FILE_SET HEADERS BASE_DIRS ${MQT_CORE_INCLUDE_BUILD_DIR}
                                        FILES ${MQT_CORE_INCLUDE_BUILD_DIR}/qdmi/na/Generator.hpp)
 
-  # Link nlohmann_json, spdlog
+  # Link nlohmann_json and spdlog
   target_link_libraries(
     ${TARGET_NAME}
     PUBLIC nlohmann_json::nlohmann_json
-    PRIVATE spdlog::spdlog MQT::ProjectOptions MQT::ProjectWarnings)
-
-  # set versioning information
-  set_target_properties(
-    ${TARGET_NAME}
-    PROPERTIES VERSION ${PROJECT_VERSION}
-               SOVERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}
-               EXPORT_NAME CoreNaDeviceGen)
-
-  # set c++ standard
-  target_compile_features(${TARGET_NAME} PRIVATE cxx_std_20)
+    PRIVATE spdlog::spdlog)
 
   # add to list of MQT core targets
   list(APPEND MQT_CORE_TARGETS ${TARGET_NAME})
 
-  # Make version available
-  target_compile_definitions(${TARGET_NAME} PRIVATE MQT_CORE_VERSION="${MQT_CORE_VERSION}")
+  # place the generated library in a predictable location where the executable can find it
+  set_target_properties(
+    ${TARGET_NAME}
+    PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_LIBDIR}"
+               ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_LIBDIR}")
 endif()
 
 # Set target name
@@ -193,6 +182,7 @@ if(NOT TARGET ${TARGET_NAME})
     endif()
   endif()
 endif()
+
 set(MQT_CORE_TARGETS
     ${MQT_CORE_TARGETS}
     PARENT_SCOPE)

src/qdmi/sc/CMakeLists.txt

@@ -13,11 +13,7 @@ set(TARGET_NAME ${MQT_CORE_TARGET_NAME}-qdmi-sc-device-gen)
 if(NOT TARGET ${TARGET_NAME})
 
   # Add library for device generation
-  #
-  # Note: We use a static library here to avoid issues with RPATH and finding the executable during
-  # the build process in Python builds
-  add_library(${TARGET_NAME} STATIC)
-  add_library(MQT::CoreQDMIScDeviceGen ALIAS ${TARGET_NAME})
+  add_mqt_core_library(${TARGET_NAME} ALIAS_NAME QDMIScDeviceGen)
 
   # add sources to target
   target_sources(${TARGET_NAME} PRIVATE Generator.cpp)
@@ -26,27 +22,17 @@ if(NOT TARGET ${TARGET_NAME})
   target_sources(${TARGET_NAME} PUBLIC FILE_SET HEADERS BASE_DIRS ${MQT_CORE_INCLUDE_BUILD_DIR}
                                        FILES ${MQT_CORE_INCLUDE_BUILD_DIR}/qdmi/sc/Generator.hpp)
 
-  # Link nlohmann_json, spdlog
+  # Link nlohmann_json and spdlog
   target_link_libraries(
     ${TARGET_NAME}
     PUBLIC nlohmann_json::nlohmann_json
-    PRIVATE spdlog::spdlog MQT::ProjectOptions MQT::ProjectWarnings)
+    PRIVATE spdlog::spdlog)
 
-  # set versioning information
+  # place the generated library in a predictable location where the executable can find it
   set_target_properties(
     ${TARGET_NAME}
-    PROPERTIES VERSION ${PROJECT_VERSION}
-               SOVERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}
-               EXPORT_NAME CoreScDeviceGen)
-
-  # set c++ standard
-  target_compile_features(${TARGET_NAME} PRIVATE cxx_std_20)
-
-  # add to list of MQT core targets
-  set(MQT_CORE_TARGETS ${MQT_CORE_TARGETS} ${TARGET_NAME})
-
-  # Make version available
-  target_compile_definitions(${TARGET_NAME} PRIVATE MQT_CORE_VERSION="${MQT_CORE_VERSION}")
+    PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_LIBDIR}"
+               ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_LIBDIR}")
 endif()
 
 # Set target name
@@ -193,6 +179,7 @@ if(NOT TARGET ${TARGET_NAME})
     endif()
   endif()
 endif()
+
 set(MQT_CORE_TARGETS
     ${MQT_CORE_TARGETS}
     PARENT_SCOPE)