Fix more linter errors

Author: denialhaag

bindings/dd/register_dd_package.cpp

@@ -164,7 +164,7 @@ void registerDDPackage(const nb::module_& m) {
   dd.def(
       "from_vector",
       [](dd::Package& p, const Vector& v) {
-        const auto length = static_cast<size_t>(v.shape(0));
+        const auto length = v.shape(0);
         if (length == 0) {
           return dd::vEdge::one();
         }
@@ -351,8 +351,8 @@ void registerDDPackage(const nb::module_& m) {
   dd.def(
       "from_matrix",
       [](dd::Package& p, const Matrix& m) {
-        const auto rows = static_cast<size_t>(m.shape(0));
-        const auto cols = static_cast<size_t>(m.shape(1));
+        const auto rows = m.shape(0);
+        const auto cols = m.shape(1);
         if (rows != cols) {
           throw std::invalid_argument("Matrix must be square.");
         }

bindings/dd/register_vector_dds.cpp

@@ -22,6 +22,7 @@
 #include <nanobind/stl/complex.h> // NOLINT(misc-include-cleaner)
 #include <nanobind/stl/string.h>  // NOLINT(misc-include-cleaner)
 #include <nanobind/stl/vector.h>  // NOLINT(misc-include-cleaner)
+#include <ranges>
 #include <sstream>
 #include <string>
 

bindings/fomac/fomac.cpp

@@ -23,6 +23,7 @@
 #include <optional>
 #include <qdmi/client.h>
 #include <string>
+#include <utility>
 #include <vector>
 
 namespace mqt {
@@ -45,9 +46,17 @@ NB_MODULE(MQT_CORE_MODULE_NAME, m) {
          std::optional<std::string> custom1, std::optional<std::string> custom2,
          std::optional<std::string> custom3, std::optional<std::string> custom4,
          std::optional<std::string> custom5) {
-        fomac::SessionConfig config{token,    authFile,  authUrl, username,
-                                    password, projectId, custom1, custom2,
-                                    custom3,  custom4,   custom5};
+        const fomac::SessionConfig config{.token = std::move(token),
+                                          .authFile = std::move(authFile),
+                                          .authUrl = std::move(authUrl),
+                                          .username = std::move(username),
+                                          .password = std::move(password),
+                                          .projectId = std::move(projectId),
+                                          .custom1 = std::move(custom1),
+                                          .custom2 = std::move(custom2),
+                                          .custom3 = std::move(custom3),
+                                          .custom4 = std::move(custom4),
+                                          .custom5 = std::move(custom5)};
         new (self) fomac::Session(config);
       },
       "token"_a = std::nullopt, "auth_file"_a = std::nullopt,

bindings/ir/operations/register_compound_operation.cpp

@@ -70,7 +70,8 @@ void registerCompoundOperation(const nb::module_& m) {
             auto [start, stop, step, sliceLength] = slice.compute(op.size());
             auto ops = std::vector<qc::Operation*>();
             ops.reserve(sliceLength);
-            for (std::size_t i = start; i < stop; i += step) {
+            for (std::size_t i = start; std::cmp_less(i, stop);
+                 i += static_cast<std::size_t>(step)) {
               ops.emplace_back(op.at(i).get());
             }
             return ops;
@@ -95,7 +96,7 @@ void registerCompoundOperation(const nb::module_& m) {
                   "Length of slice and number of operations do not match.");
             }
             for (std::size_t i = 0; i < sliceLength; ++i) {
-              compOp[start] = ops[i]->clone();
+              compOp[static_cast<std::size_t>(start)] = ops[i]->clone();
               start += step;
             }
           },
@@ -113,8 +114,8 @@ void registerCompoundOperation(const nb::module_& m) {
             auto [start, stop, step, sliceLength] = slice.compute(op.size());
             // delete in reverse order to not invalidate indices
             for (std::size_t i = sliceLength; i > 0; --i) {
-              op.erase(op.begin() +
-                       static_cast<int64_t>(start + ((i - 1) * step)));
+              op.erase(op.begin() + static_cast<std::size_t>(start) +
+                       ((i - 1) * static_cast<std::size_t>(step)));
             }
           },
           "index"_a)

bindings/ir/register_permutation.cpp

@@ -13,12 +13,12 @@
 #include "ir/operations/Control.hpp"
 
 #include <iterator>
-#include <memory>
 #include <nanobind/make_iterator.h>
 #include <nanobind/nanobind.h>
 #include <nanobind/operators.h>
 #include <nanobind/stl/string.h> // NOLINT(misc-include-cleaner)
 #include <sstream>
+#include <utility>
 
 namespace mqt {
 

bindings/ir/register_quantum_computation.cpp

@@ -104,7 +104,8 @@ void registerQuantumComputation(nb::module_& m) {
         auto [start, stop, step, sliceLength] = slice.compute(circ.getNops());
         auto ops = std::vector<qc::Operation*>();
         ops.reserve(sliceLength);
-        for (std::size_t i = start; i < stop; i += step) {
+        for (size_t i = start; std::cmp_less(i, stop);
+             i += static_cast<size_t>(step)) {
           ops.emplace_back(circ.at(i).get());
         }
         return ops;
@@ -128,7 +129,7 @@ void registerQuantumComputation(nb::module_& m) {
               "Length of slice and number of operations do not match.");
         }
         for (std::size_t i = 0; i < sliceLength; ++i) {
-          circ.at(start) = ops[i]->clone();
+          circ.at(static_cast<std::size_t>(start)) = ops[i]->clone();
           start += step;
         }
       },
@@ -146,8 +147,8 @@ void registerQuantumComputation(nb::module_& m) {
         auto [start, stop, step, sliceLength] = slice.compute(circ.getNops());
         // delete in reverse order to not invalidate indices
         for (std::size_t i = sliceLength; i > 0; --i) {
-          circ.erase(circ.begin() +
-                     static_cast<int64_t>(start + ((i - 1) * step)));
+          circ.erase(circ.begin() + static_cast<std::size_t>(start) +
+                     ((i - 1) * static_cast<std::size_t>(step)));
         }
       },
       "index"_a);

bindings/ir/symbolic/register_variable.cpp

@@ -30,7 +30,7 @@ void registerVariable(nb::module_& m) {
       .def(nb::self == nb::self) // NOLINT(misc-redundant-expression)
       .def(nb::self != nb::self) // NOLINT(misc-redundant-expression)
       .def(nb::hash(nb::self))
-      .def(nb::self < nb::self)
-      .def(nb::self > nb::self);
+      .def(nb::self < nb::self)  // NOLINT(misc-redundant-expression)
+      .def(nb::self > nb::self); // NOLINT(misc-redundant-expression)
 }
 } // namespace mqt