Add initial infrastructure for Jeff conversions

denialhaag · denialhaag · commit fd40aba300a8 · 2026-01-27T16:42:39.000+01:00
diff --git a/.license-tools-config.json b/.license-tools-config.json
@@ -35,6 +35,8 @@
     "uv\\.lock",
     "py\\.typed",
     ".*build.*",
-    "core_patterns.txt"
+    "core_patterns.txt",
+    "mlir/include/mlir/Dialect/Jeff/.*",
+    "mlir/lib/Dialect/Jeff/.*"
   ]
 }
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -145,16 +145,12 @@ endif()
 if(BUILD_MQT_CORE_MLIR)
   add_subdirectory(mlir)
 
-  # copy generated MLIR documentation
-  add_custom_command(
-    TARGET mlir-doc
-    POST_BUILD
-    COMMAND ${CMAKE_COMMAND} -E copy_directory ${CMAKE_CURRENT_BINARY_DIR}/docs/
-            ${CMAKE_CURRENT_SOURCE_DIR}/docs/mlir/
-    COMMAND ${CMAKE_COMMAND} -D DOCS_DIR:PATH=${CMAKE_CURRENT_SOURCE_DIR}/docs/mlir -P
-            ${CMAKE_CURRENT_SOURCE_DIR}/cmake/CleanMLIRDocs.cmake
-    COMMENT "Copying and cleaning up generated MLIR documentation"
-    VERBATIM)
+  # copy generated MLIR documentation add_custom_command( TARGET mlir-doc POST_BUILD COMMAND
+  # ${CMAKE_COMMAND} -E copy_directory ${CMAKE_CURRENT_BINARY_DIR}/docs/
+  # ${CMAKE_CURRENT_SOURCE_DIR}/docs/mlir/ COMMAND ${CMAKE_COMMAND} -D
+  # DOCS_DIR:PATH=${CMAKE_CURRENT_SOURCE_DIR}/docs/mlir -P
+  # ${CMAKE_CURRENT_SOURCE_DIR}/cmake/CleanMLIRDocs.cmake COMMENT "Copying and cleaning up generated
+  # MLIR documentation" VERBATIM)
 
 endif()
 
diff --git a/cmake/ExternalDependencies.cmake b/cmake/ExternalDependencies.cmake
@@ -33,6 +33,21 @@ if(BUILD_MQT_CORE_MLIR)
       CACHE INTERNAL "Disable building Eigen tests")
   FetchContent_Declare(Eigen URL ${Eigen_URL} FIND_PACKAGE_ARGS ${Eigen_VERSION})
   list(APPEND FETCH_PACKAGES Eigen)
+
+  # Fetch jeff-mlir
+  FetchContent_Declare(
+    jeff_mlir
+    GIT_REPOSITORY https://github.com/PennyLaneAI/jeff-mlir.git
+    GIT_TAG main
+    GIT_SUBMODULES "" GIT_SUBMODULES_RECURSE FALSE)
+  FetchContent_MakeAvailable(jeff_mlir)
+
+  # Include jeff-mlir headers
+  include_directories(${jeff_mlir_SOURCE_DIR}/include)
+  include_directories(${jeff_mlir_BINARY_DIR}/include)
+
+  # Restore C++ standard changed by jeff-mlir
+  set(CMAKE_CXX_STANDARD 20)
 endif()
 
 set(JSON_VERSION
diff --git a/mlir/include/mlir/Conversion/CMakeLists.txt b/mlir/include/mlir/Conversion/CMakeLists.txt
@@ -6,6 +6,8 @@
 #
 # Licensed under the MIT License
 
+add_subdirectory(JeffToQC)
 add_subdirectory(QCOToQC)
+add_subdirectory(QCToJeff)
 add_subdirectory(QCToQCO)
 add_subdirectory(QCToQIR)
diff --git a/mlir/include/mlir/Conversion/JeffToQC/CMakeLists.txt b/mlir/include/mlir/Conversion/JeffToQC/CMakeLists.txt
@@ -0,0 +1,13 @@
+# Copyright (c) 2023 - 2026 Chair for Design Automation, TUM
+# Copyright (c) 2025 - 2026 Munich Quantum Software Company GmbH
+# All rights reserved.
+#
+# SPDX-License-Identifier: MIT
+#
+# Licensed under the MIT License
+
+set(LLVM_TARGET_DEFINITIONS JeffToQC.td)
+mlir_tablegen(JeffToQC.h.inc -gen-pass-decls -name JeffToQC)
+add_public_tablegen_target(JeffToQCIncGen)
+
+add_mlir_doc(JeffToQC MLIRJeffToQC Conversions/ -gen-pass-doc)
diff --git a/mlir/include/mlir/Conversion/JeffToQC/JeffToQC.h b/mlir/include/mlir/Conversion/JeffToQC/JeffToQC.h
@@ -0,0 +1,21 @@
+/*
+ * Copyright (c) 2023 - 2026 Chair for Design Automation, TUM
+ * Copyright (c) 2025 - 2026 Munich Quantum Software Company GmbH
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: MIT
+ *
+ * Licensed under the MIT License
+ */
+
+#pragma once
+
+#include <mlir/Pass/Pass.h>
+
+namespace mlir {
+#define GEN_PASS_DECL_JEFFTOQC
+#include "mlir/Conversion/JeffToQC/JeffToQC.h.inc"
+
+#define GEN_PASS_REGISTRATION
+#include "mlir/Conversion/JeffToQC/JeffToQC.h.inc"
+} // namespace mlir
diff --git a/mlir/include/mlir/Conversion/JeffToQC/JeffToQC.td b/mlir/include/mlir/Conversion/JeffToQC/JeffToQC.td
@@ -0,0 +1,22 @@
+// Copyright (c) 2023 - 2026 Chair for Design Automation, TUM
+// Copyright (c) 2025 - 2026 Munich Quantum Software Company GmbH
+// All rights reserved.
+//
+// SPDX-License-Identifier: MIT
+//
+// Licensed under the MIT License
+
+include "mlir/Pass/PassBase.td"
+
+def JeffToQC : Pass<"jeff-to-qc"> {
+  let summary = "TODO";
+
+  let description = [{
+      TODO
+   }];
+
+  let dependentDialects = [
+     "jeff::JeffDialect",
+     "mlir::QCDialect",
+  ];
+}
diff --git a/mlir/include/mlir/Conversion/QCOToQC/QCOToQC.h b/mlir/include/mlir/Conversion/QCOToQC/QCOToQC.h
@@ -10,7 +10,7 @@
 
 #pragma once
 
-#include <mlir/Pass/Pass.h> // from @llvm-project
+#include <mlir/Pass/Pass.h>
 
 namespace mlir {
 #define GEN_PASS_DECL_QCOTOQC
diff --git a/mlir/include/mlir/Conversion/QCToJeff/CMakeLists.txt b/mlir/include/mlir/Conversion/QCToJeff/CMakeLists.txt
@@ -0,0 +1,13 @@
+# Copyright (c) 2023 - 2026 Chair for Design Automation, TUM
+# Copyright (c) 2025 - 2026 Munich Quantum Software Company GmbH
+# All rights reserved.
+#
+# SPDX-License-Identifier: MIT
+#
+# Licensed under the MIT License
+
+set(LLVM_TARGET_DEFINITIONS QCToJeff.td)
+mlir_tablegen(QCToJeff.h.inc -gen-pass-decls -name QCToJeff)
+add_public_tablegen_target(QCToJeffIncGen)
+
+add_mlir_doc(QCToJeff MLIRQCToJeff Conversions/ -gen-pass-doc)
diff --git a/mlir/include/mlir/Conversion/QCToJeff/QCToJeff.h b/mlir/include/mlir/Conversion/QCToJeff/QCToJeff.h
@@ -0,0 +1,21 @@
+/*
+ * Copyright (c) 2023 - 2026 Chair for Design Automation, TUM
+ * Copyright (c) 2025 - 2026 Munich Quantum Software Company GmbH
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: MIT
+ *
+ * Licensed under the MIT License
+ */
+
+#pragma once
+
+#include <mlir/Pass/Pass.h>
+
+namespace mlir {
+#define GEN_PASS_DECL_QCTOJEFF
+#include "mlir/Conversion/QCToJeff/QCToJeff.h.inc"
+
+#define GEN_PASS_REGISTRATION
+#include "mlir/Conversion/QCToJeff/QCToJeff.h.inc"
+} // namespace mlir
diff --git a/mlir/include/mlir/Conversion/QCToJeff/QCToJeff.td b/mlir/include/mlir/Conversion/QCToJeff/QCToJeff.td
@@ -0,0 +1,22 @@
+// Copyright (c) 2023 - 2026 Chair for Design Automation, TUM
+// Copyright (c) 2025 - 2026 Munich Quantum Software Company GmbH
+// All rights reserved.
+//
+// SPDX-License-Identifier: MIT
+//
+// Licensed under the MIT License
+
+include "mlir/Pass/PassBase.td"
+
+def QCToJeff : Pass<"qc-to-jeff"> {
+  let summary = "TODO";
+
+  let description = [{
+      TODO
+   }];
+
+  let dependentDialects = [
+     "jeff::JeffDialect",
+     "mlir::QCDialect",
+  ];
+}
diff --git a/mlir/include/mlir/Conversion/QCToQCO/QCToQCO.h b/mlir/include/mlir/Conversion/QCToQCO/QCToQCO.h
@@ -10,7 +10,7 @@
 
 #pragma once
 
-#include <mlir/Pass/Pass.h> // from @llvm-project
+#include <mlir/Pass/Pass.h>
 
 namespace mlir {
 #define GEN_PASS_DECL_QCTOQCO
diff --git a/mlir/include/mlir/Conversion/QCToQIR/QCToQIR.h b/mlir/include/mlir/Conversion/QCToQIR/QCToQIR.h
@@ -10,7 +10,7 @@
 
 #pragma once
 
-#include <mlir/Pass/Pass.h> // from @llvm-project
+#include <mlir/Pass/Pass.h>
 
 namespace mlir {
 #define GEN_PASS_DECL_QCTOQIR
diff --git a/mlir/lib/Conversion/CMakeLists.txt b/mlir/lib/Conversion/CMakeLists.txt
@@ -6,6 +6,8 @@
 #
 # Licensed under the MIT License
 
+add_subdirectory(JeffToQC)
 add_subdirectory(QCOToQC)
+add_subdirectory(QCToJeff)
 add_subdirectory(QCToQCO)
 add_subdirectory(QCToQIR)
diff --git a/mlir/lib/Conversion/JeffToQC/CMakeLists.txt b/mlir/lib/Conversion/JeffToQC/CMakeLists.txt
@@ -0,0 +1,20 @@
+# Copyright (c) 2023 - 2026 Chair for Design Automation, TUM
+# Copyright (c) 2025 - 2026 Munich Quantum Software Company GmbH
+# All rights reserved.
+#
+# SPDX-License-Identifier: MIT
+#
+# Licensed under the MIT License
+
+file(GLOB CONVERSION_SOURCES *.cpp)
+
+add_mlir_library(
+  JeffToQC
+  ${CONVERSION_SOURCES}
+  DEPENDS
+  JeffToQCIncGen
+  LINK_LIBS
+  MLIRJeff
+  MLIRQCDialect
+  MLIRTransforms
+  DISABLE_INSTALL)
diff --git a/mlir/lib/Conversion/JeffToQC/JeffToQC.cpp b/mlir/lib/Conversion/JeffToQC/JeffToQC.cpp
@@ -0,0 +1,111 @@
+/*
+ * Copyright (c) 2023 - 2026 Chair for Design Automation, TUM
+ * Copyright (c) 2025 - 2026 Munich Quantum Software Company GmbH
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: MIT
+ *
+ * Licensed under the MIT License
+ */
+
+#include "mlir/Conversion/JeffToQC/JeffToQC.h"
+
+#include "mlir/Dialect/QC/IR/QCDialect.h"
+
+#include <jeff/IR/JeffDialect.h>
+#include <jeff/IR/JeffOps.h>
+#include <mlir/Dialect/Func/IR/FuncOps.h>
+#include <mlir/Dialect/Func/Transforms/FuncConversions.h>
+#include <mlir/IR/BuiltinTypeInterfaces.h>
+#include <mlir/IR/MLIRContext.h>
+#include <mlir/IR/OperationSupport.h>
+#include <mlir/IR/PatternMatch.h>
+#include <mlir/IR/ValueRange.h>
+#include <mlir/Support/LLVM.h>
+#include <mlir/Support/LogicalResult.h>
+#include <mlir/Transforms/DialectConversion.h>
+#include <utility>
+
+namespace mlir {
+using namespace qc;
+
+#define GEN_PASS_DEF_JEFFTOQC
+#include "mlir/Conversion/JeffToQC/JeffToQC.h.inc"
+
+struct ConvertJeffQubitAllocOpToQC final
+    : OpConversionPattern<jeff::QubitAllocOp> {
+  using OpConversionPattern::OpConversionPattern;
+
+  LogicalResult
+  matchAndRewrite(jeff::QubitAllocOp op, OpAdaptor adaptor,
+                  ConversionPatternRewriter& rewriter) const override {
+    rewriter.replaceOpWithNewOp<qc::AllocOp>(op);
+    return success();
+  }
+};
+
+struct ConvertJeffQubitFreeOpToQC final
+    : OpConversionPattern<jeff::QubitFreeOp> {
+  using OpConversionPattern::OpConversionPattern;
+
+  LogicalResult
+  matchAndRewrite(jeff::QubitFreeOp op, OpAdaptor adaptor,
+                  ConversionPatternRewriter& rewriter) const override {
+    auto qcQubit = adaptor.getInQubit();
+    rewriter.replaceOpWithNewOp<qc::DeallocOp>(op, qcQubit);
+    return success();
+  }
+};
+
+struct ConvertJeffXOpToQC final : OpConversionPattern<jeff::XOp> {
+  using OpConversionPattern::OpConversionPattern;
+
+  LogicalResult
+  matchAndRewrite(jeff::XOp op, OpAdaptor adaptor,
+                  ConversionPatternRewriter& rewriter) const override {
+    auto qcQubit = adaptor.getInQubit();
+    auto qcOp = rewriter.create<qc::XOp>(op.getLoc(), qcQubit);
+    rewriter.replaceOp(op, qcQubit);
+    return success();
+  }
+};
+
+class JeffToQCTypeConverter final : public TypeConverter {
+public:
+  explicit JeffToQCTypeConverter(MLIRContext* ctx) {
+    // Identity conversion for all types by default
+    addConversion([](Type type) { return type; });
+
+    addConversion([ctx](jeff::QubitType /*type*/) -> Type {
+      return qc::QubitType::get(ctx);
+    });
+  }
+};
+
+struct JeffToQC final : impl::JeffToQCBase<JeffToQC> {
+  using JeffToQCBase::JeffToQCBase;
+
+  void runOnOperation() override {
+    MLIRContext* context = &getContext();
+    auto* module = getOperation();
+
+    ConversionTarget target(*context);
+    RewritePatternSet patterns(context);
+    JeffToQCTypeConverter typeConverter(context);
+
+    // Configure conversion target: Jeff illegal, QC legal
+    target.addIllegalDialect<jeff::JeffDialect>();
+    target.addLegalDialect<QCDialect>();
+
+    // Register operation conversion patterns
+    patterns.add<ConvertJeffQubitAllocOpToQC, ConvertJeffQubitFreeOpToQC,
+                 ConvertJeffXOpToQC>(typeConverter, context);
+
+    // Apply the conversion
+    if (failed(applyPartialConversion(module, target, std::move(patterns)))) {
+      signalPassFailure();
+    }
+  }
+};
+
+} // namespace mlir
diff --git a/mlir/lib/Conversion/QCToJeff/CMakeLists.txt b/mlir/lib/Conversion/QCToJeff/CMakeLists.txt
@@ -0,0 +1,21 @@
+# Copyright (c) 2023 - 2026 Chair for Design Automation, TUM
+# Copyright (c) 2025 - 2026 Munich Quantum Software Company GmbH
+# All rights reserved.
+#
+# SPDX-License-Identifier: MIT
+#
+# Licensed under the MIT License
+
+file(GLOB CONVERSION_SOURCES *.cpp)
+
+add_mlir_library(
+  QCToJeff
+  ${CONVERSION_SOURCES}
+  DEPENDS
+  QCToJeffIncGen
+  LINK_LIBS
+  MLIRDialect
+  MLIRJeff
+  MLIRQCDialect
+  MLIRTransforms
+  DISABLE_INSTALL)
diff --git a/mlir/lib/Conversion/QCToJeff/QCToJeff.cpp b/mlir/lib/Conversion/QCToJeff/QCToJeff.cpp
diff --git a/mlir/lib/Conversion/QCToQCO/QCToQCO.cpp b/mlir/lib/Conversion/QCToQCO/QCToQCO.cpp
diff --git a/mlir/unittests/CMakeLists.txt b/mlir/unittests/CMakeLists.txt
diff --git a/mlir/unittests/Conversion/CMakeLists.txt b/mlir/unittests/Conversion/CMakeLists.txt
diff --git a/mlir/unittests/Conversion/JeffToQC/CMakeLists.txt b/mlir/unittests/Conversion/JeffToQC/CMakeLists.txt
diff --git a/mlir/unittests/Conversion/JeffToQC/test_conversion_jeff_to_qc.cpp b/mlir/unittests/Conversion/JeffToQC/test_conversion_jeff_to_qc.cpp
diff --git a/mlir/unittests/Conversion/QCToJeff/CMakeLists.txt b/mlir/unittests/Conversion/QCToJeff/CMakeLists.txt
diff --git a/mlir/unittests/Conversion/QCToJeff/test_conversion_qc_to_jeff.cpp b/mlir/unittests/Conversion/QCToJeff/test_conversion_qc_to_jeff.cpp

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,8 @@`
`35`	`35`	`"uv\\.lock",`
`36`	`36`	`"py\\.typed",`
`37`	`37`	`".build.",`
`38`		`- "core_patterns.txt"`
	`38`	`+ "core_patterns.txt",`
	`39`	`+ "mlir/include/mlir/Dialect/Jeff/.*",`
	`40`	`+ "mlir/lib/Dialect/Jeff/.*"`
`39`	`41`	`]`
`40`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,8 @@`
`6`	`6`	`#`
`7`	`7`	`# Licensed under the MIT License`
`8`	`8`
	`9`	`+add_subdirectory(JeffToQC)`
`9`	`10`	`add_subdirectory(QCOToQC)`
	`11`	`+add_subdirectory(QCToJeff)`
`10`	`12`	`add_subdirectory(QCToQCO)`
`11`	`13`	`add_subdirectory(QCToQIR)`