Skip to content

Commit 366f2f3

Browse files
committed
♻️ Try different fix for spdlog
1 parent 0799adb commit 366f2f3

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

CMakeLists.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,6 @@ set_property(
4444
CRITICAL
4545
OFF)
4646
add_compile_definitions(SPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_${MQT_QMAP_LOG_LEVEL})
47-
# todo: this might not be the right place to put this but required for spdlog and python bindings on
48-
# linux
49-
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
5047

5148
option(BUILD_MQT_QMAP_BINDINGS "Build the MQT QMAP Python bindings" OFF)
5249
if(BUILD_MQT_QMAP_BINDINGS)

cmake/ExternalDependencies.cmake

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,8 @@ set(SPDLOG_VERSION
8989
1.15.3
9090
CACHE STRING "spdlog version")
9191
set(SPDLOG_URL https://github.com/gabime/spdlog/archive/refs/tags/v${SPDLOG_VERSION}.tar.gz)
92+
# Add position independent code for spdlog, this is required for python bindings on linux
93+
set(SPDLOG_BUILD_PIC ON)
9294
FetchContent_Declare(spdlog URL ${SPDLOG_URL} FIND_PACKAGE_ARGS ${SPDLOG_VERSION})
9395
list(APPEND FETCH_PACKAGES spdlog)
9496

0 commit comments

Comments
 (0)