Skip to content

Commit ea4cf50

Browse files
authored
🔥 Remove Z3 from build dependencies (#199)
## Description This PR gets rid of the Z3 build dependency. Due to build isolation, the virtual environment containing Z3 (that is being linked to the C++ binding library) does no longer exist after the build. Hence, the package install is essentially broken if the Z3 Python package is picked up during the build. This was a workaround for getting the RtD build to work. I managed to work around the underlying issue by figuring out a way to specify the `Z3_ROOT` environment variable for the package installation step. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. Signed-off-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
1 parent 79c48ac commit ea4cf50

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

.readthedocs.yaml

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,11 @@ submodules:
77
build:
88
os: ubuntu-22.04
99
tools:
10-
python: "3.9"
11-
apt_packages:
12-
- cmake
10+
python: "3.10"
11+
jobs:
12+
post_create_environment:
13+
- pip install "z3-solver>=4.8.15"
14+
- Z3_ROOT=$(python -c "import z3 as _; print(_.__path__[0])"); export Z3_ROOT; pip install -e .[docs] -v
1315

1416
sphinx:
1517
configuration: docs/source/conf.py
16-
17-
python:
18-
install:
19-
- method: pip
20-
path: .
21-
extra_requirements:
22-
- docs

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ requires = [
44
"setuptools_scm[toml]>=7",
55
"ninja>=1.10; sys_platform != 'win32'",
66
"cmake>=3.19",
7-
"z3-solver>=4.8.15,<4.12.0",
87
]
98
build-backend = "setuptools.build_meta"
109

0 commit comments

Comments
 (0)