Skip to content

Commit ddb9e48

Browse files
authored
🔥 remove dedicated MLIR option for reusable-change-detection.yml and merge with C++ checks (#300)
* 🔥 remove dedicated MLIR option for reusable-change-detection.yml and merge with C++ checks Signed-off-by: burgholzer <burgholzer@me.com> * 📝 add changelog and upgrade guide note Signed-off-by: burgholzer <burgholzer@me.com> * 👌 address CodeRabbit concerns Signed-off-by: burgholzer <burgholzer@me.com> --------- Signed-off-by: burgholzer <burgholzer@me.com>
1 parent 9917004 commit ddb9e48

File tree

3 files changed

+18
-22
lines changed

3 files changed

+18
-22
lines changed

.github/workflows/reusable-change-detection.yml

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,6 @@ on:
2525
run-cd:
2626
description: Whether to run the continuous deployment job
2727
value: ${{ jobs.change-detection.outputs.run-cd || false }}
28-
run-mlir:
29-
description: Whether to run the MLIR tests
30-
value: ${{ jobs.change-detection.outputs.run-mlir || false }}
3128

3229
concurrency:
3330
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}-change-detection
@@ -46,7 +43,6 @@ jobs:
4643
run-cpp-linter: ${{ steps.cpp-linter-changes.outputs.run-cpp-linter || false }}
4744
run-python-tests: ${{ steps.python-tests-changes.outputs.run-python-tests || false }}
4845
run-cd: ${{ steps.cd-changes.outputs.run-cd || false }}
49-
run-mlir: ${{ steps.mlir-changes.outputs.run-mlir || false }}
5046
steps:
5147
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
5248
with:
@@ -58,6 +54,7 @@ jobs:
5854
with:
5955
filter: |
6056
include/**
57+
mlir/**
6158
src/**
6259
test/**
6360
!test/python/**
@@ -85,10 +82,10 @@ jobs:
8582
filter: |
8683
bindings/**
8784
include/**
85+
mlir/**
8886
src/**
8987
test/**
9088
!test/python/**
91-
mlir/**
9289
.clang-tidy
9390
.github/workflows/reusable-cpp-linter.yml
9491
.github/workflows/ci.yml
@@ -142,20 +139,3 @@ jobs:
142139
id: cd-changes
143140
run: >-
144141
echo "run-cd=true" >> "${GITHUB_OUTPUT}"
145-
- name: Get a list of the changed files relevant for the MLIR tests
146-
if: github.event_name == 'pull_request'
147-
id: changed-mlir-testable-files
148-
uses: Ana06/get-changed-files@25f79e676e7ea1868813e21465014798211fad8c # v2.3.0
149-
with:
150-
filter: |
151-
mlir/**
152-
.github/workflows/reusable-mlir-tests.yml
153-
plugins/catalyst/**
154-
.github/workflows/reusable-mlir-catalyst-plugin-tests.yml
155-
- name: Set a flag for running the MLIR tests
156-
if: >-
157-
github.event_name != 'pull_request'
158-
|| steps.changed-mlir-testable-files.outputs.added_modified_renamed != ''
159-
id: mlir-changes
160-
run: >-
161-
echo "run-mlir=true" >> "${GITHUB_OUTPUT}"

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,14 @@ This project adheres to [Semantic Versioning], with the exception that minor rel
99

1010
## [Unreleased]
1111

12+
### Changed
13+
14+
- 🔧 Include `mlir/**` in C++ change detection ([#300]) ([**@burgholzer**])
15+
16+
### Removed
17+
18+
- 🔥 remove dedicated `run-mlir` MLIR output for reusable-change-detection.yml ([#300]) ([**@burgholzer**])
19+
1220
## [1.17.10] - 2026-01-04
1321

1422
### Fixed
@@ -260,6 +268,7 @@ _📚 Refer to the [GitHub Release Notes] for previous changelogs._
260268

261269
<!-- PR links -->
262270

271+
[#300]: https://github.com/munich-quantum-toolkit/workflows/pull/300
263272
[#298]: https://github.com/munich-quantum-toolkit/workflows/pull/298
264273
[#297]: https://github.com/munich-quantum-toolkit/workflows/pull/297
265274
[#296]: https://github.com/munich-quantum-toolkit/workflows/pull/296

UPGRADING.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,13 @@ This document describes breaking changes and how to upgrade. For a complete list
44

55
## [Unreleased]
66

7+
### Removal of `run-mlir` output from change-detection
8+
9+
This release removes the `run-mlir` output from the change-detection step of the `reusable-cpp-linter.yml` workflow.
10+
The output was only used in MQT Core, where MLIR will be enabled by default with the next release.
11+
Hence, this update includes `mlir/**` in the regular C++ file filter instead.
12+
Since this is only affecting the MQT Core repository, this is only flagged as a patch release.
13+
714
## [1.17.6]
815

916
### Checking Python stub files

0 commit comments

Comments
 (0)