Refactor caching mechanism to use in-memory storage only

- Removed file-based cache persistence and associated options.
- Updated command-line flags to reflect changes in caching behavior.
- Enhanced cache management for improved performance and simplicity.

Author: mununki

CHANGELOG.md

@@ -12,9 +12,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 - Static linking support for Linux environments
 - Performance benchmarking mode with `--benchmark` flag
-- Improved cache management with `--clear-cache` option
 
 ### Changed
+- Removed file-based cache persistence in favor of in-memory caching only
+- Removed `--cache-file` option completely
 - Enhanced error handling for workspace analysis
 - Improved progress reporting in VS Code extension
 

bin/main.ml

@@ -7,7 +7,6 @@ let focus_module = ref None
 let verbose = ref false
 let benchmark = ref false
 let skip_cache = ref false
-let cache_file = ref None
 let clear_cache = ref false
 
 let spec_list =
@@ -48,11 +47,10 @@ let spec_list =
     ("--verbose", Arg.Set verbose, "Enable verbose output");
     ("-b", Arg.Set benchmark, "Enable performance benchmarking");
     ("--benchmark", Arg.Set benchmark, "Enable performance benchmarking");
-    ("--no-cache", Arg.Set skip_cache, "Skip using the cache");
-    ( "--cache-file",
-      Arg.String (fun s -> cache_file := Some s),
-      "Specify cache file location" );
-    ("--clear-cache", Arg.Set clear_cache, "Clear the cache before analyzing");
+    ("--no-cache", Arg.Set skip_cache, "Skip using the in-memory cache");
+    ( "--clear-cache",
+      Arg.Set clear_cache,
+      "Clear the in-memory cache before analyzing" );
   ]
 
 let anon_fun file = input_files := file :: !input_files
@@ -82,23 +80,15 @@ let main () =
 
     time_checkpoint "Start";
 
-    (* Setup cache configuration *)
-
-    (* Set cache file if provided *)
-    (match !cache_file with
-    | Some path -> Rescriptdep.Parser.set_cache_file path
-    | None ->
-        ();
-
-        (* Clear cache if requested *)
-        if !clear_cache then (
-          if !verbose then Printf.eprintf "Clearing cache\n";
-          Rescriptdep.Parser.clear_cache ()));
+    (* Clear in-memory cache if requested *)
+    if !clear_cache then (
+      if !verbose then Printf.eprintf "Clearing in-memory cache\n";
+      Rescriptdep.Parser.clear_cache ());
 
     (* Parse files and directories to get module infos *)
     let module_infos =
       if !skip_cache then (
-        if !verbose then Printf.eprintf "Skipping cache usage\n";
+        if !verbose then Printf.eprintf "Skipping in-memory cache usage\n";
         Rescriptdep.Parser.clear_cache ();
         Rescriptdep.Parser.parse_files_or_dirs ~verbose:!verbose
           ~skip_cache:true !input_files)

lib/parser.ml

@@ -24,75 +24,17 @@ module Cache = struct
   (* AST dependency check result cache *)
   let ast_dependency_cache = Hashtbl.create 200
 
-  (* Cache file path - where the cache will be stored on disk *)
-  let cache_file = ref None
-
-  (* Set the cache file path *)
-  let set_cache_file path = cache_file := Some path
-
-  (* Get the path of the cache file, creating default if needed *)
-  let get_cache_file () =
-    match !cache_file with
-    | Some path -> path
-    | None ->
-        let path =
-          Filename.concat (Sys.getcwd ()) ".rescriptdep_cache.marshal"
-        in
-        cache_file := Some path;
-        path
-
-  (* Initialize the cache from disk if available *)
+  (* Initialize the cache - simplified to just return false as we don't load from disk anymore *)
   let initialize ?(verbose = false) ?(skip_cache = false) () =
-    (* Skip initialization if skip_cache is set *)
-    if skip_cache then (
-      if verbose then
-        Printf.printf "Skip cache flag is set, not loading cache\n";
-      false)
-    else
-      let path = get_cache_file () in
-      if Sys.file_exists path then (
-        try
-          let ic = open_in_bin path in
-          let stored_cache : (string, cache_entry) Hashtbl.t =
-            Marshal.from_channel ic
-          in
-          close_in ic;
-
-          (* Transfer to our in-memory cache *)
-          Hashtbl.iter (fun k v -> Hashtbl.replace cache_table k v) stored_cache;
-
-          if verbose then
-            Printf.printf "Cache loaded from %s with %d entries\n" path
-              (Hashtbl.length cache_table);
-          true
-        with e ->
-          if verbose then
-            Printf.printf "Error loading cache: %s\n" (Printexc.to_string e);
-          false)
-      else (
-        if verbose then Printf.printf "No cache file found at %s\n" path;
-        false)
+    if verbose then
+      Printf.printf "File-based caching is disabled, using only memory cache\n";
+    false
 
-  (* Save the cache to disk *)
+  (* Save the cache - simplified to just return false as we don't save to disk anymore *)
   let save ?(verbose = false) ?(skip_cache = false) () =
-    (* Skip saving if skip_cache is set *)
-    if skip_cache then (
-      if verbose then Printf.printf "Skip cache flag is set, not saving cache\n";
-      false)
-    else
-      let path = get_cache_file () in
-      try
-        let oc = open_out_bin path in
-        Marshal.to_channel oc cache_table [];
-        close_out oc;
-        if verbose then
-          Printf.printf "Cache saved to %s with %d entries\n" path
-            (Hashtbl.length cache_table);
-        true
-      with e ->
-        if verbose then
-          Printf.printf "Error saving cache: %s\n" (Printexc.to_string e);
-        false
+    if verbose then
+      Printf.printf "File-based caching is disabled, not saving cache to disk\n";
+    false
 
   (* Add or update an entry in the cache *)
   let add ?(skip_cache = false) path module_info =
@@ -892,9 +834,9 @@ let parse_files_or_dirs ?(verbose = false) ?(skip_cache = false) paths =
   if !benchmark then benchmark_start := Unix.gettimeofday ();
   bench_checkpoint "Parser started";
 
-  (* Initialize the cache system *)
+  (* Initialize the memory cache system - call is kept for compatibility *)
   let _ = Cache.initialize ~verbose ~skip_cache () in
-  bench_checkpoint "Cache initialization completed";
+  bench_checkpoint "Memory cache setup completed";
 
   (* Collect all cmt files *)
   let collect_cmt_files paths =
@@ -1021,10 +963,8 @@ let parse_files_or_dirs ?(verbose = false) ?(skip_cache = false) paths =
       results)
   in
 
-  (* After all files are processed, save the cache *)
-  let _ = bench_checkpoint "Processing completed" in
-  let _ = Cache.save ~verbose ~skip_cache () in
-  bench_checkpoint "Cache saved";
+  (* After all files are processed, no need to save cache to disk anymore *)
+  bench_checkpoint "Processing completed";
 
   if !benchmark && verbose then (
     Printf.eprintf "\n[PARSER-BENCH] Summary:\n";
@@ -1037,8 +977,5 @@ let parse_files_or_dirs ?(verbose = false) ?(skip_cache = false) paths =
 (* Clear the module info cache *)
 let clear_cache () = Cache.clear ()
 
-(* Set the cache file path *)
-let set_cache_file path = Cache.set_cache_file path
-
 (* Set the skip cache flag - now just a stub since we pass skip_cache directly *)
 let set_skip_cache _flag = ()

test/benchmark.ml

@@ -19,17 +19,13 @@ let benchmark_path =
     then "test/fixtures" (* Use test fixtures as fallback *)
     else "/tmp" (* Default to a directory that should always exist *)
 
-let cache_path = "/tmp/rescriptdep_bench_cache.marshal"
-
 (* Environment variables *)
 let () =
   Unix.putenv "RESCRIPTDEP_BENCHMARK" "1";
   Unix.putenv "RESCRIPTDEP_VERBOSE" "1"
 
 let run_benchmark () =
-  (* Set up the cache file and ensure it doesn't exist *)
-  set_cache_file cache_path;
-  if Sys.file_exists cache_path then Sys.remove cache_path;
+  (* Clear memory cache to ensure fresh analysis *)
   clear_cache ();
 
   (* Run the analysis *)
@@ -67,7 +63,6 @@ let () =
       exit 1);
 
     Printf.printf "Running benchmark on %s\n" benchmark_path;
-    Printf.printf "Cache file: %s\n" cache_path;
 
     let _ = run_benchmark () in
     ())