Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

Commit cbe0f7c

Browse files
committed
TODO additions
1 parent 51e93ac commit cbe0f7c

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

ToDo.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
Bugs / Outstanding
22
===================
33

4+
Back in commit 402ff1a0a6efe40532fb6e523184eb4f974e0c92 I changed it so that both bespoke reactions and generic reactions ran for the same event. This was a mistake and I did it as a simple fix for what JD wanted to do at the time. I should reverse this change and add a new option for this type of usage case. As its breaking standard behavour for more normal usage scenarios. Also I never updated all the Readme for it.
5+
I couldn't use negative filtering by type on a money reaction: [TYPE] != 'subscription' and [TYPE] != 'subMysteryGift'
6+
Document that you can add comments within the profile if you want. The tool never looks for a "comment" key in the JSON. The tool only looks for the documented keys in the JSON with anything else being ignored.
47
Replace the event definitions with a proper readme type file. Also add to readme what the generic event types are.
58
The profiles loading tries to do everything in Profiles folder, no sanity check about file/folder type. If you make a "backup" folder in it, the program crashes without recording an error.
69
Look to use yaml in RCON integration configs as they may be nicer to read and may support the action commands and passing JSON to Factorio nicer.

0 commit comments

Comments
 (0)