Rector code cleanup (librenms#18390)

* Add rector with initial config

* Run rector

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <[email protected]>

Author: murrant

LibreNMS/Alert/AlertUtil.php

@@ -170,7 +170,7 @@ public static function findContactsSysContact(array $results): array
 
     public static function findContactsOwners(array $results): array
     {
-        return User::whereNot('email', '')->where(function (Builder $query) use ($results) {
+        return User::whereNot('email', '')->where(function (Builder $query) use ($results): void {
             if ($device_ids = array_filter(Arr::pluck($results, 'device_id'))) {
                 $query->orWhereHas('devicesOwned', fn ($q) => $q->whereIn('devices_perms.device_id', $device_ids));
             }

LibreNMS/Alert/Template.php

@@ -46,7 +46,7 @@ public function getTemplate($obj = null)
             // Return the cached template information.
             return $this->template;
         }
-        $this->template = AlertTemplate::whereHas('map', function ($query) use ($obj) {
+        $this->template = AlertTemplate::whereHas('map', function ($query) use ($obj): void {
             $query->where('alert_rule_id', '=', $obj['rule_id']);
         })->first();
         if (! $this->template) {

LibreNMS/Alert/Transport/Elasticsearch.php

@@ -64,7 +64,7 @@ public function deliverAlert(array $alert_data): bool
             'entity_descr' => $alert_data['sysDescr'],
         ];
 
-        foreach ($alert_data['faults'] as $k => $v) {
+        foreach ($alert_data['faults'] as $v) {
             $data['message'] = $v['string'];
             switch (true) {
                 case array_key_exists('port_id', $v):

LibreNMS/Alert/Transport/Pagerduty.php

@@ -54,7 +54,7 @@ public function deliverAlert(array $alert_data): bool
                 'group' => (string) \DeviceCache::get($alert_data['device_id'])->groups->pluck('name'),
                 'source' => $alert_data['hostname'],
                 'severity' => $alert_data['severity'],
-                'summary' => ($alert_data['title'] ? $alert_data['title'] : $alert_data['name'] . ' on ' . $alert_data['hostname']),
+                'summary' => ($alert_data['title'] ?: $alert_data['name'] . ' on ' . $alert_data['hostname']),
             ],
         ];
 

LibreNMS/Alert/Transport/Victorops.php

@@ -54,7 +54,7 @@ public function deliverAlert(array $alert_data): bool
             },
         };
 
-        foreach ($alert_data['faults'] as $fault => $data) {
+        foreach ($alert_data['faults'] as $data) {
             $protocol['state_message'] .= $data['string'];
         }
 

LibreNMS/Alert/Transport/Zenduty.php

@@ -44,7 +44,7 @@ public function deliverAlert(array $alert_data): bool
             $alert_type = $alert_data['severity'];
         }
         // Set the standard data ZD expects to see
-        $msg = (json_decode($alert_data['msg'], true)) ? json_decode($alert_data['msg'], true) : $alert_data['msg'];
+        $msg = json_decode($alert_data['msg'], true) ?: $alert_data['msg'];
         $data = [
             'message' => $alert_data['title'],
             'alert_type' => $alert_type,

LibreNMS/Alerting/QueryBuilderFluentParser.php

@@ -61,7 +61,7 @@ public function toQuery()
      */
     protected function parseGroupToQuery($query, $rule, $parent_condition = null)
     {
-        return $query->where(function ($query) use ($rule) {
+        return $query->where(function ($query) use ($rule): void {
             foreach ($rule['rules'] as $group_rule) {
                 if (array_key_exists('condition', $group_rule)) {
                     $this->parseGroupToQuery($query, $group_rule, $rule['condition']);

LibreNMS/Authentication/ActiveDirectoryCommon.php

@@ -44,7 +44,7 @@ protected function sidFromLdap($sid)
         if (PHP_INT_SIZE <= 4) {
             for ($i = 1; $i <= count($subAuths); $i++) {
                 if ($subAuths[$i] < 0) {
-                    $subAuths[$i] = $subAuths[$i] + 0x100000000;
+                    $subAuths[$i] += 0x100000000;
                 }
             }
         }

LibreNMS/Component.php

@@ -224,7 +224,7 @@ public function setComponentPrefs($device_id, $updated)
         \App\Models\Component::whereIntegerInRaw('id', array_keys($updated))
             ->with('prefs')
             ->get()
-            ->each(function (\App\Models\Component $component) use ($device_id, $updated) {
+            ->each(function (\App\Models\Component $component) use ($device_id, $updated): void {
                 $update = $updated[$component->id];
                 unset($update['type']);  // can't change type
 

LibreNMS/Data/Source/Fping.php

@@ -115,7 +115,7 @@ public function bulkPing(array $hosts, callable $callback): void
         Log::debug('[FPING] ' . $process->getCommandLine() . PHP_EOL);
 
         $partial = '';
-        $process->run(function ($type, $output) use ($callback, &$partial) {
+        $process->run(function ($type, $output) use ($callback, &$partial): void {
             // stdout contains individual ping responses, stderr contains summaries
             if ($type == Process::ERR) {
                 $lines = explode(PHP_EOL, $output);