Fix deprecation warnings

Author: murrant

LibreNMS/ComposerHelper.php

@@ -134,8 +134,6 @@ private static function populateEnv()
         ];
 
         if (file_exists('config.php')) {
-            /** @phpstan-ignore ignore.unmatched */
-            /** @phpstan-ignore include.fileNotFound */
             @include 'config.php';
         }
 

app/Http/Controllers/Ajax/AvailabilityMapController.php

@@ -56,7 +56,7 @@ public function setGroup(Request $request)
      */
     private function setSessionValue($request, $key)
     {
-        $value = $request->get($key);
+        $value = $request->input($key);
         $request->session()->put($key, $value);
 
         return response()->json([$key, $value]);

app/Http/Controllers/Ajax/DeviceSearchController.php

@@ -85,7 +85,7 @@ public function buildQuery(string $search, Request $request): Builder
     public function formatItem($device): array
     {
         $name = $device->displayName();
-        if (! request()->get('map') && $name !== $device->sysName) {
+        if (! request()->input('map') && $name !== $device->sysName) {
             $name .= " ($device->sysName)";
         }
 

app/Http/Controllers/Ajax/NetCommand.php

@@ -44,21 +44,21 @@ public function run(Request $request)
 
         ini_set('allow_url_fopen', '0');
 
-        switch ($request->get('cmd')) {
+        switch ($request->input('cmd')) {
             case 'whois':
-                $cmd = [LibrenmsConfig::get('whois', 'whois'), $request->get('query')];
+                $cmd = [LibrenmsConfig::get('whois', 'whois'), $request->input('query')];
                 break;
             case 'ping':
-                $cmd = [LibrenmsConfig::get('ping', 'ping'), '-c', '5', $request->get('query')];
+                $cmd = [LibrenmsConfig::get('ping', 'ping'), '-c', '5', $request->input('query')];
                 break;
             case 'tracert':
-                $cmd = [LibrenmsConfig::get('mtr', 'mtr'), '-r', '-c', '5', $request->get('query')];
+                $cmd = [LibrenmsConfig::get('mtr', 'mtr'), '-r', '-c', '5', $request->input('query')];
                 break;
             case 'nmap':
                 if (! $request->user()->isAdmin()) {
                     return response('Insufficient privileges');
                 } else {
-                    $cmd = [LibrenmsConfig::get('nmap', 'nmap'), $request->get('query')];
+                    $cmd = [LibrenmsConfig::get('nmap', 'nmap'), $request->input('query')];
                 }
                 break;
             default:

app/Http/Controllers/Ajax/PortSearchController.php

@@ -40,7 +40,7 @@ public function buildQuery(string $search, Request $request): Builder
             ->with('device')
             ->where('deleted', 0)
             ->where(function (Builder $query) use ($request) {
-                $search = $request->get('search');
+                $search = $request->input('search');
                 $like_search = "%$search%";
 
                 return $query->orWhere('ifAlias', 'LIKE', $like_search)

app/Http/Controllers/Ajax/RipeNccApiController.php

@@ -40,10 +40,10 @@ public function raw(Request $request, RipeApi $api)
             'query_param' => 'required|ip_or_hostname',
         ]);
 
-        $is_whois = $request->get('data_param') == 'whois';
+        $is_whois = $request->input('data_param') == 'whois';
 
         try {
-            $resource = $request->get('query_param');
+            $resource = $request->input('query_param');
             $output = $is_whois ? $api->getWhois($resource) : $api->getAbuseContact($resource);
 
             return response()->json([

app/Http/Controllers/Ajax/SearchController.php

@@ -35,7 +35,7 @@ abstract class SearchController
 {
     public function __invoke(Request $request): JsonResponse
     {
-        $search = $request->get('search');
+        $search = $request->input('search');
         if (empty($search)) {
             return new JsonResponse;
         }

app/Http/Controllers/AlertController.php

@@ -18,7 +18,7 @@ public function ack(Request $request, Alert $alert): \Illuminate\Http\JsonRespon
             'ack_until_clear' => 'nullable|in:0,1,true,false',
         ]);
 
-        $state = $request->get('state');
+        $state = $request->input('state');
         $state_description = '';
         if ($state == 2) {
             $alert->state = 1;
@@ -31,12 +31,12 @@ public function ack(Request $request, Alert $alert): \Illuminate\Http\JsonRespon
         }
 
         $info = $alert->info;
-        $info['until_clear'] = filter_var($request->get('ack_until_clear'), FILTER_VALIDATE_BOOLEAN);
+        $info['until_clear'] = filter_var($request->input('ack_until_clear'), FILTER_VALIDATE_BOOLEAN);
         $alert->info = $info;
 
         $timestamp = date(LibrenmsConfig::get('dateformat.long'));
         $username = $request->user()->username;
-        $ack_msg = $request->get('ack_msg');
+        $ack_msg = $request->input('ack_msg');
         $alert->note = trim($alert->note . PHP_EOL . "$timestamp - $state_description ($username) " . $ack_msg);
 
         if ($alert->save()) {

app/Http/Controllers/Auth/TwoFactorController.php

@@ -115,7 +115,7 @@ public function create(Request $request)
             'key' => $key,
             'fails' => 0,
             'last' => 0,
-            'counter' => $request->get('twofactortype') == 'counter' ? 0 : false,
+            'counter' => $request->input('twofactortype') == 'counter' ? 0 : false,
         ];
 
         Session::put('twofactoradd', $settings);

app/Http/Controllers/DashboardController.php

@@ -137,7 +137,7 @@ public function show(Request $request, Dashboard $dashboard)
             : [];
 
         return view('overview.default', [
-            'bare' => $request->get('bare'),
+            'bare' => $request->input('bare'),
             'dash_config' => $data,
             'dashboard' => $dashboard,
             'hide_dashboard_editor' => UserPref::getPref($user, 'hide_dashboard_editor'),
@@ -154,7 +154,7 @@ public function store(Request $request): JsonResponse
             'dashboard_name' => 'string|max:255',
         ]);
 
-        $name = trim(strip_tags((string) $request->get('dashboard_name')));
+        $name = trim(strip_tags((string) $request->input('dashboard_name')));
         $dashboard = Dashboard::create([
             'user_id' => Auth::id(),
             'dashboard_name' => $name,
@@ -201,7 +201,7 @@ public function copy(Request $request, Dashboard $dashboard): JsonResponse
             'target_user_id' => 'required|exists:App\Models\User,user_id',
         ]);
 
-        $target_user_id = $request->get('target_user_id');
+        $target_user_id = $request->input('target_user_id');
 
         $this->authorize('copy', [$dashboard, $target_user_id]);