PHPUnit should fail on all issues (librenms#17802)

* PHPUnit should fail on all issues

* Update test.yml

* Update test.yml

* Update ErrorReporting.php

* Update test.yml

* rebase and invert check with early return

* Update test.yml

* don't use array_push with one arg

---------

Co-authored-by: Tony Murray <[email protected]>

Author: Jellyfrog

LibreNMS/Util/CiHelper.php

@@ -179,10 +179,10 @@ public function getFlags(): array
      */
     public function checkUnit(): int
     {
-        $phpunit_cmd = [$this->checkPhpExec('phpunit'), '--colors=always'];
+        $phpunit_cmd = [$this->checkPhpExec('phpunit'), '--colors=always', '--fail-on-all-issues'];
 
         if ($this->flags['fail-fast']) {
-            array_push($phpunit_cmd, '--stop-on-error', '--stop-on-failure');
+            $phpunit_cmd[] = '--stop-on-defect';
         }
 
         if (Debug::isVerbose()) {

app/Exceptions/ErrorReporting.php

@@ -157,37 +157,38 @@ public function isReportingEnabled(): bool
 
     private function adjustErrorHandlingForAppEnv(string $environment): void
     {
-        // TODO remove testing and then APP_DEBUG requirement when issues are cleaned up
-        if ($environment == 'production' || $environment == 'testing' || ! config('app.debug')) {
-            // in production, don't halt execution on non-fatal errors
-            set_error_handler(function ($severity, $message, $file, $line) {
-                // If file is from a package, find the first non-vendor frame
-                if (str_contains($file, '/vendor/')) {
-                    // add vendor file to message
-                    $message .= ' from ' . strstr($file, 'vendor') . ':' . $line;
-                    [$file, $line] = self::findFirstNonVendorFrame();
-                }
-
-                if ((error_reporting() & $severity) !== 0) { // this check primarily allows @ to suppress errors
-                    error_log("\e[31mPHP Error($severity)\e[0m: $message in $file:$line");
-                }
-
-                // For notices and warnings, prevent conversion to exceptions
-                if (($severity & (E_NOTICE | E_WARNING | E_USER_NOTICE | E_USER_WARNING | E_DEPRECATED)) !== 0) {
-                    return true; // Prevent the standard error handler from running
-                }
-
-                return false; // For other errors, let Laravel handle them
-            });
-        } else {
-            // non-prod, show deprecations
+        // throw exceptions and deprecations in testing and non-prod when APP_DEBUG is set.
+        if ($environment == 'testing' || ($environment !== 'production' && config('app.debug'))) {
             app()->booted(function () {
                 config([
                     'logging.deprecations.channel' => 'deprecations_channel',
                     'logging.deprecations.trace' => true,
                 ]);
             });
+
+            return; // do not override error handler below
         }
+
+        // in production, don't halt execution on non-fatal errors
+        set_error_handler(function ($severity, $message, $file, $line) {
+            // If file is from a package, find the first non-vendor frame
+            if (str_contains($file, '/vendor/')) {
+                // add vendor file to message
+                $message .= ' from ' . strstr($file, 'vendor') . ':' . $line;
+                [$file, $line] = self::findFirstNonVendorFrame();
+            }
+
+            if ((error_reporting() & $severity) !== 0) { // this check primarily allows @ to suppress errors
+                error_log("\e[31mPHP Error($severity)\e[0m: $message in $file:$line");
+            }
+
+            // For notices and warnings, prevent conversion to exceptions
+            if (($severity & (E_NOTICE | E_WARNING | E_USER_NOTICE | E_USER_WARNING | E_DEPRECATED)) !== 0) {
+                return true; // Prevent the standard error handler from running
+            }
+
+            return false; // For other errors, let Laravel handle them
+        });
     }
 
     private static function findFirstNonVendorFrame(): array