rector cleanups for deps update (librenms#18511)

Author: murrant

LibreNMS/Data/Store/InfluxDBv2.php

@@ -121,7 +121,7 @@ public function write(string $measurement, array $fields, array $tags = [], arra
             $device_groups = $device->groups;
             foreach ($device_groups as $group) {
                 // The group name will always be parsed as lowercase, even when uppercase in the GUI.
-                if (in_array(strtoupper((string) $group->name), array_map('strtoupper', $excluded_groups))) {
+                if (in_array(strtoupper((string) $group->name), array_map(strtoupper(...), $excluded_groups))) {
                     Log::warning('Skipped parsing to InfluxDBv2, device is in group: ' . $group->name);
 
                     return;

LibreNMS/IRCBot.php

@@ -108,7 +108,7 @@ public function __construct()
         $this->server = $this->config['irc_host'];
         if ($this->config['irc_port'][0] == '+') {
             $this->ssl = true;
-            $this->port = substr($this->config['irc_port'], 1);
+            $this->port = substr((string) $this->config['irc_port'], 1);
         } else {
             $this->port = $this->config['irc_port'];
         }
@@ -118,8 +118,8 @@ public function __construct()
         }
 
         if ($this->config['irc_alert_chan']) {
-            if (strstr($this->config['irc_alert_chan'], ',')) {
-                $this->config['irc_alert_chan'] = explode(',', $this->config['irc_alert_chan']);
+            if (strstr((string) $this->config['irc_alert_chan'], ',')) {
+                $this->config['irc_alert_chan'] = explode(',', (string) $this->config['irc_alert_chan']);
             } elseif (! is_array($this->config['irc_alert_chan'])) {
                 $this->config['irc_alert_chan'] = [$this->config['irc_alert_chan']];
             }

LibreNMS/OS.php

@@ -203,7 +203,7 @@ public function getCacheByIndex($oid, $mib = null, $snmpflags = '-OQUs')
 
         if (! isset($this->cache['cache_oid'][$oid])) {
             $data = snmpwalk_cache_oid($this->getDeviceArray(), $oid, [], $mib, null, $snmpflags);
-            $this->cache['cache_oid'][$oid] = array_map('current', $data);
+            $this->cache['cache_oid'][$oid] = array_map(current(...), $data);
         }
 
         return $this->cache['cache_oid'][$oid];
@@ -291,7 +291,7 @@ public function getName()
         $name = $rf->getShortName();
         preg_match_all('/[A-Z][a-z]*/', $name, $segments);
 
-        return implode('-', array_map('strtolower', $segments[0]));
+        return implode('-', array_map(strtolower(...), $segments[0]));
     }
 
     /**

LibreNMS/OS/Routeros.php

@@ -689,7 +689,7 @@ public function discoverVlans(): Collection
 
             foreach (preg_split("/((\r?\n)|(\r\n?))/", (string) $data) as $line) {
                 if (! empty($line)) {
-                    [$mtType, $vlanId, $mtData] = array_map('trim', explode(',', $line));
+                    [$mtType, $vlanId, $mtData] = array_map(trim(...), explode(',', $line));
 
                     if ($mtType == 'N') {
                         $vlanNames[$vlanId] = $mtData;
@@ -727,7 +727,7 @@ public function discoverVlanPorts(Collection $vlans): Collection
 
             foreach (preg_split("/((\r?\n)|(\r\n?))/", (string) $data) as $line) {
                 if (! empty($line)) {
-                    [$mtType, $vlanId, $mtData] = array_map('trim', explode(',', $line));
+                    [$mtType, $vlanId, $mtData] = array_map(trim(...), explode(',', $line));
 
                     if ($mtType == 'N') { // type 'N' is for vlan name, skip from processing
                         continue;

LibreNMS/Util/FileCategorizer.php

@@ -157,7 +157,7 @@ private function osFromFile($file)
     private function osFromClass($class)
     {
         preg_match_all('/[A-Z][a-z0-9]*/', $class, $segments);
-        $osname = implode('-', array_map('strtolower', $segments[0]));
+        $osname = implode('-', array_map(strtolower(...), $segments[0]));
         $osname = preg_replace(
             ['/^zero-/', '/^one-/', '/^two-/', '/^three-/', '/^four-/', '/^five-/', '/^six-/', '/^seven-/', '/^eight-/', '/^nine-/'],
             ['0', '1', '2', '3', '4', '5', '6', '7', '8', '9'],

LibreNMS/Util/IPv6.php

@@ -125,7 +125,7 @@ public function getNetworkAddress($cidr = null)
         }
         array_unshift($net_bytes, 'n*'); // add pack format
 
-        return self::ntop(call_user_func_array('pack', $net_bytes));
+        return self::ntop(call_user_func_array(pack(...), $net_bytes));
     }
 
     /**
@@ -210,6 +210,6 @@ public function toSnmpIndex()
     {
         $ipv6_split = str_split(str_replace(':', '', $this->uncompressed()), 2);
 
-        return implode('.', array_map('hexdec', $ipv6_split));
+        return implode('.', array_map(hexdec(...), $ipv6_split));
     }
 }

LibreNMS/Util/Mac.php

@@ -167,7 +167,7 @@ public function vendor(): string
      */
     public function oid(): string
     {
-        return implode('.', array_map('hexdec', $this->mac));
+        return implode('.', array_map(hexdec(...), $this->mac));
     }
 
     /**

LibreNMS/Util/StringHelpers.php

@@ -226,7 +226,7 @@ public static function bitsToIndices(string $hex_data): array
         if (! StringHelpers::isHex($hex_data)) {
             // could be malformed
             if (preg_match('/^(\d+)(,\d+)*$/', ltrim($hex_data, '0'), $matches)) {
-                return array_map(fn ($v) => intval($v), explode(',', $matches[0]));
+                return array_map(intval(...), explode(',', $matches[0]));
             }
 
             return [];

LibreNMS/Validator.php

@@ -143,7 +143,7 @@ public function getResults(?string $validation_group = null): array
             return $this->results[$validation_group] ?? [];
         }
 
-        return array_reduce($this->results, 'array_merge', []);
+        return array_reduce($this->results, array_merge(...), []);
     }
 
     /**

app/Http/Controllers/DeviceGroupController.php

@@ -126,7 +126,7 @@ public function update(Request $request, DeviceGroup $deviceGroup, ToastInterfac
             // sync device_ids from input
             $updated = $deviceGroup->devices()->sync($request->get('devices', []));
             // check for attached/detached/updated
-            $devices_updated = array_sum(array_map(fn ($device_ids) => count($device_ids), $updated)) > 0;
+            $devices_updated = array_sum(array_map(count(...), $updated)) > 0;
         } else {
             $deviceGroup->rules = json_decode($request->rules);
         }