Skip to content

Commit 465bc1e

Browse files
sb-relaxt-atlaf
andauthored
Correct labels for rx/tx power for fs.com switches (librenms#18334)
* Correct labels for rc/tx power for fs.com switches * Update fs-centec_s5850-48s2q4c.json --------- Co-authored-by: Neil Lathwood <gh+n@laf.io>
1 parent f40e2ca commit 465bc1e

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

includes/discovery/sensors/dbm/fs-centec.inc.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
'sensor_oid' => ".1.3.6.1.4.1.52642.1.37.1.10.6.1.5.$ifIndex",
2323
'sensor_index' => "rx-$ifIndex.$channel",
2424
'sensor_type' => 'fs-centec',
25-
'sensor_descr' => "$ifName:$channel xcvr TX power",
25+
'sensor_descr' => "$ifName:$channel xcvr RX power",
2626
'sensor_divisor' => 1,
2727
'sensor_multiplier' => 1,
2828
'sensor_limit_low' => $current['FS-SWITCH-V2-MIB::receivepowerLowAlarmThreshold'] ?? null,
@@ -47,7 +47,7 @@
4747
'sensor_oid' => ".1.3.6.1.4.1.52642.1.37.1.10.5.1.5.$ifIndex",
4848
'sensor_index' => "tx-$ifIndex.$channel",
4949
'sensor_type' => 'fs-centec',
50-
'sensor_descr' => "$ifName:$channel xcvr RX power",
50+
'sensor_descr' => "$ifName:$channel xcvr TX power",
5151
'sensor_divisor' => 1,
5252
'sensor_multiplier' => 1,
5353
'sensor_limit_low' => $current['FS-SWITCH-V2-MIB::transpowerLowAlarmThreshold'] ?? null,

tests/data/fs-centec_s5850-48s2q4c.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11585,7 +11585,7 @@
1158511585
"sensor_oid": ".1.3.6.1.4.1.52642.1.37.1.10.6.1.5.50",
1158611586
"sensor_index": "rx-50.0",
1158711587
"sensor_type": "fs-centec",
11588-
"sensor_descr": "eth-0-50:0 xcvr TX power",
11588+
"sensor_descr": "eth-0-50:0 xcvr RX power",
1158911589
"group": "transceiver",
1159011590
"sensor_divisor": 1,
1159111591
"sensor_multiplier": 1,
@@ -11610,7 +11610,7 @@
1161011610
"sensor_oid": ".1.3.6.1.4.1.52642.1.37.1.10.6.1.5.50",
1161111611
"sensor_index": "rx-50.1",
1161211612
"sensor_type": "fs-centec",
11613-
"sensor_descr": "eth-0-50:1 xcvr TX power",
11613+
"sensor_descr": "eth-0-50:1 xcvr RX power",
1161411614
"group": "transceiver",
1161511615
"sensor_divisor": 1,
1161611616
"sensor_multiplier": 1,
@@ -11635,7 +11635,7 @@
1163511635
"sensor_oid": ".1.3.6.1.4.1.52642.1.37.1.10.6.1.5.50",
1163611636
"sensor_index": "rx-50.2",
1163711637
"sensor_type": "fs-centec",
11638-
"sensor_descr": "eth-0-50:2 xcvr TX power",
11638+
"sensor_descr": "eth-0-50:2 xcvr RX power",
1163911639
"group": "transceiver",
1164011640
"sensor_divisor": 1,
1164111641
"sensor_multiplier": 1,
@@ -11660,7 +11660,7 @@
1166011660
"sensor_oid": ".1.3.6.1.4.1.52642.1.37.1.10.6.1.5.50",
1166111661
"sensor_index": "rx-50.3",
1166211662
"sensor_type": "fs-centec",
11663-
"sensor_descr": "eth-0-50:3 xcvr TX power",
11663+
"sensor_descr": "eth-0-50:3 xcvr RX power",
1166411664
"group": "transceiver",
1166511665
"sensor_divisor": 1,
1166611666
"sensor_multiplier": 1,
@@ -11685,7 +11685,7 @@
1168511685
"sensor_oid": ".1.3.6.1.4.1.52642.1.37.1.10.5.1.5.50",
1168611686
"sensor_index": "tx-50.0",
1168711687
"sensor_type": "fs-centec",
11688-
"sensor_descr": "eth-0-50:0 xcvr RX power",
11688+
"sensor_descr": "eth-0-50:0 xcvr TX power",
1168911689
"group": "transceiver",
1169011690
"sensor_divisor": 1,
1169111691
"sensor_multiplier": 1,
@@ -11710,7 +11710,7 @@
1171011710
"sensor_oid": ".1.3.6.1.4.1.52642.1.37.1.10.5.1.5.50",
1171111711
"sensor_index": "tx-50.1",
1171211712
"sensor_type": "fs-centec",
11713-
"sensor_descr": "eth-0-50:1 xcvr RX power",
11713+
"sensor_descr": "eth-0-50:1 xcvr TX power",
1171411714
"group": "transceiver",
1171511715
"sensor_divisor": 1,
1171611716
"sensor_multiplier": 1,
@@ -11735,7 +11735,7 @@
1173511735
"sensor_oid": ".1.3.6.1.4.1.52642.1.37.1.10.5.1.5.50",
1173611736
"sensor_index": "tx-50.2",
1173711737
"sensor_type": "fs-centec",
11738-
"sensor_descr": "eth-0-50:2 xcvr RX power",
11738+
"sensor_descr": "eth-0-50:2 xcvr TX power",
1173911739
"group": "transceiver",
1174011740
"sensor_divisor": 1,
1174111741
"sensor_multiplier": 1,
@@ -11760,7 +11760,7 @@
1176011760
"sensor_oid": ".1.3.6.1.4.1.52642.1.37.1.10.5.1.5.50",
1176111761
"sensor_index": "tx-50.3",
1176211762
"sensor_type": "fs-centec",
11763-
"sensor_descr": "eth-0-50:3 xcvr RX power",
11763+
"sensor_descr": "eth-0-50:3 xcvr TX power",
1176411764
"group": "transceiver",
1176511765
"sensor_divisor": 1,
1176611766
"sensor_multiplier": 1,

0 commit comments

Comments
 (0)