Revert "Set relation after syncing models (librenms#18040)" (librenms#18042)

murrant · web-flow · commit 4ae643f0c381 · 2025-07-09T13:09:29.000-05:00
This reverts commit 24a3de5.
diff --git a/LibreNMS/DB/SyncsModels.php b/LibreNMS/DB/SyncsModels.php
@@ -78,10 +78,7 @@ protected function syncModels($parentModel, $relationship, $models, $existing =
             $parentModel->$relationship()->saveMany($new);
         }
 
-        $savedModels = $existing->map->first()->merge($new);
-        $parentModel->setRelation($relationship, $savedModels);
-
-        return $savedModels;
+        return $existing->map->first()->merge($new);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -78,10 +78,7 @@ protected function syncModels($parentModel, $relationship, $models, $existing =`
`78`	`78`	`$parentModel->$relationship()->saveMany($new);`
`79`	`79`	`}`
`80`	`80`
`81`		`- $savedModels = $existing->map->first()->merge($new);`
`82`		`- $parentModel->setRelation($relationship, $savedModels);`
`83`		`-`
`84`		`- return $savedModels;`
	`81`	`+ return $existing->map->first()->merge($new);`
`85`	`82`	`}`
`86`	`83`
`87`	`84`	`/**`