Fix Modem Connection State sensor for Opengear (librenms#18371)

electrocret · web-flow · commit 50d919213809 · 2025-10-16T09:55:10.000+02:00
* Update opengear.yaml

* Update condition for ogCellModemEnabled check

* Update oid format in opengear.yaml

* Update OID for cell modem status in opengear.yaml

* Change cell modem enabled value from 1 to 2

* Update opengear.json

* Update opengear_humidity.json
diff --git a/resources/definitions/os_discovery/opengear.yaml b/resources/definitions/os_discovery/opengear.yaml
@@ -129,9 +129,9 @@ modules:
                         - { value: 2, descr: Disconnected, graph: 2, generic: 2 }
                     skip_values:
                         -
-                            oid: 'ogCellModemEnabled.{{ $index }}'
-                            op: '!='
-                            value: enabled
+                            oid: 'OG-STATUSv2-MIB::ogCellModemEnabled'
+                            op: '='
+                            value: 2
                 -
                     oid: OG-STATUSv2-MIB::ogCellModemTable
                     value: OG-STATUSv2-MIB::ogCellModemRadioTechnology
diff --git a/tests/data/opengear.json b/tests/data/opengear.json
@@ -1926,6 +1926,31 @@
                     "rrd_type": "GAUGE",
                     "state_name": null
                 },
+                {
+                    "sensor_deleted": 0,
+                    "sensor_class": "state",
+                    "poller_type": "snmp",
+                    "sensor_oid": ".1.3.6.1.4.1.25049.17.17.1.5.1",
+                    "sensor_index": "ogCellModemConnected.1",
+                    "sensor_type": "ogCellModemConnected",
+                    "sensor_descr": "Modem Connection State",
+                    "group": null,
+                    "sensor_divisor": 1,
+                    "sensor_multiplier": 1,
+                    "sensor_current": 2,
+                    "sensor_limit": null,
+                    "sensor_limit_warn": null,
+                    "sensor_limit_low": null,
+                    "sensor_limit_low_warn": null,
+                    "sensor_alert": 1,
+                    "sensor_custom": "No",
+                    "entPhysicalIndex": null,
+                    "entPhysicalIndex_measured": null,
+                    "sensor_prev": null,
+                    "user_func": null,
+                    "rrd_type": "GAUGE",
+                    "state_name": "ogCellModemConnected"
+                },
                 {
                     "sensor_deleted": 0,
                     "sensor_class": "state",
@@ -1978,6 +2003,20 @@
                 }
             ],
             "state_indexes": [
+                {
+                    "state_name": "ogCellModemConnected",
+                    "state_descr": "Connected",
+                    "state_draw_graph": 1,
+                    "state_value": 1,
+                    "state_generic_value": 0
+                },
+                {
+                    "state_name": "ogCellModemConnected",
+                    "state_descr": "Disconnected",
+                    "state_draw_graph": 2,
+                    "state_value": 2,
+                    "state_generic_value": 2
+                },
                 {
                     "state_name": "ogCellModemRadioTechnology",
                     "state_descr": "Unavailable",
diff --git a/tests/data/opengear_humidity.json b/tests/data/opengear_humidity.json
@@ -1968,6 +1968,31 @@
                     "rrd_type": "GAUGE",
                     "state_name": null
                 },
+                {
+                    "sensor_deleted": 0,
+                    "sensor_class": "state",
+                    "poller_type": "snmp",
+                    "sensor_oid": ".1.3.6.1.4.1.25049.17.17.1.5.1",
+                    "sensor_index": "ogCellModemConnected.1",
+                    "sensor_type": "ogCellModemConnected",
+                    "sensor_descr": "Modem Connection State",
+                    "group": null,
+                    "sensor_divisor": 1,
+                    "sensor_multiplier": 1,
+                    "sensor_current": 1,
+                    "sensor_limit": null,
+                    "sensor_limit_warn": null,
+                    "sensor_limit_low": null,
+                    "sensor_limit_low_warn": null,
+                    "sensor_alert": 1,
+                    "sensor_custom": "No",
+                    "entPhysicalIndex": null,
+                    "entPhysicalIndex_measured": null,
+                    "sensor_prev": null,
+                    "user_func": null,
+                    "rrd_type": "GAUGE",
+                    "state_name": "ogCellModemConnected"
+                },
                 {
                     "sensor_deleted": 0,
                     "sensor_class": "state",
@@ -2020,6 +2045,20 @@
                 }
             ],
             "state_indexes": [
+                {
+                    "state_name": "ogCellModemConnected",
+                    "state_descr": "Connected",
+                    "state_draw_graph": 1,
+                    "state_value": 1,
+                    "state_generic_value": 0
+                },
+                {
+                    "state_name": "ogCellModemConnected",
+                    "state_descr": "Disconnected",
+                    "state_draw_graph": 2,
+                    "state_value": 2,
+                    "state_generic_value": 2
+                },
                 {
                     "state_name": "ogCellModemRadioTechnology",
                     "state_descr": "Unavailable",

Original file line number	Diff line number	Diff line change
`@@ -129,9 +129,9 @@ modules:`
`129`	`129`	`- { value: 2, descr: Disconnected, graph: 2, generic: 2 }`
`130`	`130`	`skip_values:`
`131`	`131`	`-`
`132`		`- oid: 'ogCellModemEnabled.{{ $index }}'`
`133`		`- op: '!='`
`134`		`- value: enabled`
	`132`	`+ oid: 'OG-STATUSv2-MIB::ogCellModemEnabled'`
	`133`	`+ op: '='`
	`134`	`+ value: 2`
`135`	`135`	`-`
`136`	`136`	`oid: OG-STATUSv2-MIB::ogCellModemTable`
`137`	`137`	`value: OG-STATUSv2-MIB::ogCellModemRadioTechnology`