update Sneck for for version 1.1.0 (librenms#18105)

* add in support for .data.run_time for sneck

* update the app page

* add sneck_run_time.inc.php

* add run_time for sneck to apps.inc.php

* add pretty display of per test run time

* add total run to app page

* fix metrics

* remove a stray ;

* rename sneck_run_time to sneck_runtime for the graph and change "Run Time" to Runtime" for display

Author: VVelox

includes/html/graphs/application/sneck_runtime.inc.php

@@ -0,0 +1,24 @@
+<?php
+
+$name = 'sneck';
+$unit_text = 'Seconds';
+$colours = 'psychedelic';
+$dostack = 0;
+$printtotal = 0;
+$addarea = 0;
+$transparency = 15;
+
+$rrd_filename = Rrd::name($device['hostname'], ['app', $name, $app->app_id, 'run_time']);
+
+$rrd_list = [
+];
+
+if (Rrd::checkRrdExists($rrd_filename)) {
+    $rrd_list[] = [
+        'filename' => $rrd_filename,
+        'descr' => 'Runtime',
+        'ds' => 'data',
+    ];
+}
+
+require 'includes/html/graphs/generic_multi_line.inc.php';

includes/html/pages/apps.inc.php

@@ -102,6 +102,7 @@
 $graphs['sneck'] = [
     'results',
     'time',
+    'runtime',
 ];
 $graphs['ntp-client'] = [
     'stats',

includes/html/pages/device/apps/sneck.inc.php

@@ -48,6 +48,10 @@
                 }
             }
         }
+        // run time
+        if (isset($app->data['data']['run_time'])) {
+            echo '<b>Runtime:</b> ' . htmlspecialchars($app->data['data']['run_time']) . " seconds<br>\n";
+        }
         print_optionbar_end();
     }
 }
@@ -70,6 +74,10 @@
     if (isset($app->data['data'][$type][$type_name]['ran'])) {
         echo '<b>Ran:</b> ' . htmlspecialchars($app->data['data'][$type][$type_name]['ran']) . "<br>\n";
     }
+    // run time
+    if (isset($app->data['data'][$type][$type_name]['run_time'])) {
+        echo '<b>Runtime:</b> ' . htmlspecialchars($app->data['data'][$type][$type_name]['run_time']) . " seconds<br>\n";
+    }
     // exit code
     if (isset($app->data['data'][$type][$type_name]['exit'])) {
         echo '<b>Exit:</b> ' . htmlspecialchars($app->data['data'][$type][$type_name]['exit']) . "<br>\n";
@@ -93,6 +101,10 @@
         'sneck_time' => 'Time Difference',
     ];
 
+    if (isset($app->data['data']['checks'])) {
+        $graphs['sneck_runtime'] = 'Runtime';
+    }
+
     foreach ($graphs as $key => $text) {
         $graph_type = $key;
         $graph_array['height'] = '100';

includes/polling/applications/sneck.inc.php

@@ -80,6 +80,29 @@
 $tags = ['name' => $name, 'app_id' => $app->app_id, 'rrd_def' => $rrd_def, 'rrd_name' => $rrd_name];
 app('Datastore')->put($device, 'app', $tags, $fields);
 
+// run_time is only present in version 1.1.0 and up
+if (isset($json_return['data']) and isset($json_return['data']['run_time']) and is_numeric($json_return['data']['run_time'])) {
+    $rrd_def = RrdDefinition::make()
+        ->addDataset('data', 'GAUGE', 0);
+
+    $rrd_name = ['app', $name, $app->app_id, 'run_time'];
+
+    // $fields is also used for storing metrics, so don't stomp it
+    $run_time_fields = [
+        'data' => $json_return['data']['run_time'],
+    ];
+    $fields['run_time'] = $json_return['data']['run_time'];
+
+    $tags = ['name' => $name, 'app_id' => $app->app_id, 'rrd_def' => $rrd_def, 'rrd_name' => $rrd_name];
+    app('Datastore')->put($device, 'app', $tags, $run_time_fields);
+
+    // if this is over 300, it took 300+ seconds to run, meaning we are currently ingesting data for a previous time slot
+    if ($json_return['data']['run_time'] >= 300) {
+        $log_message = 'Sneck took ' . $json_return['data']['run_time'] . ' seconds to run';
+        Eventlog::log($log_message, $device['device_id'], 'application', Severity::Error);
+    }
+}
+
 // save the return status for each alerting possibilities
 foreach ($json_return['data']['checks'] as $key => $value) {
     $fields['check_' . $key] = $value['exit'];