Use common log message format

Author: murrant

LibreNMS/Modules/Core.php

@@ -29,6 +29,7 @@
 use App\Facades\LibrenmsConfig;
 use App\Models\Device;
 use App\Models\Eventlog;
+use App\Observers\DeviceObserver;
 use Illuminate\Support\Facades\Cache;
 use Illuminate\Support\Str;
 use LibreNMS\Enum\Severity;
@@ -72,7 +73,8 @@ public function discover(OS $os): void
 
         foreach (['sysObjectID', 'sysName', 'sysDescr'] as $attribute) {
             if ($device->isDirty($attribute)) {
-                Eventlog::log($attribute . ': ' . $device->getOriginal($attribute) . ' -> ' . $device->$attribute, $device, 'system', Severity::Notice);
+                $message = DeviceObserver::attributeChangedMessage($attribute, $device->$attribute, $device->getOriginal($attribute));
+                Eventlog::log($message, $device, 'system', Severity::Notice);
                 $os->getDeviceArray()[$attribute] = $device->$attribute; // update device array
             }
         }

app/Observers/DeviceObserver.php

@@ -237,7 +237,7 @@ public function pivotAttached(Device $device, $relationName, $pivotIds, $pivotId
         }
     }
 
-    public static function attributeChangedMessage($attribute, $value, $previous)
+    public static function attributeChangedMessage($attribute, $value, $previous): string
     {
         return trans("device.attributes.$attribute") . ': '
             . (($previous && $previous != $value) ? "$previous -> " : '')

lang/en/device.php

@@ -11,7 +11,9 @@
         'location' => 'Location',
         'os' => 'Device OS',
         'serial' => 'Serial',
+        'sysDescr' => 'sysDescr',
         'sysName' => 'sysName',
+        'sysObjectID' => 'sysObjectID',
         'version' => 'OS Version',
         'type' => 'Device type',
     ],