Better handle issues with ipmitool/freeipmi so we try other types as … (librenms#17066)

* Better handle issues with ipmitool/freeipmi so we try other types as needed.

* Correct StyleCI Requirement

* Fix code style

Author: visbits

includes/discovery/sensors/ipmi.inc.php

@@ -1,5 +1,6 @@
 <?php
 
+use Illuminate\Support\Facades\Log;
 use Illuminate\Support\Str;
 use LibreNMS\Config;
 
@@ -21,16 +22,22 @@
     }
 
     foreach (Config::get('ipmi.type', []) as $ipmi_type) {
-        $results = explode(PHP_EOL, external_exec(array_merge($cmd, ['-I', $ipmi_type, 'sensor'])));
+        // Check if the IPMI type is available, catch segfaults of ipmitool/freeipmi.
+        try {
+            Log::debug('Trying IPMI type: ' . $ipmi_type);
+            $results = explode(PHP_EOL, external_exec(array_merge($cmd, ['-I', $ipmi_type, 'sensor'])));
 
-        $results = array_values(array_filter($results, function ($line) {
-            return ! Str::contains($line, 'discrete');
-        }));
+            $results = array_values(array_filter($results, function ($line) {
+                return ! Str::contains($line, 'discrete');
+            }));
 
-        if (! empty($results)) {
-            set_dev_attrib($device, 'ipmi_type', $ipmi_type);
-            echo "$ipmi_type ";
-            break;
+            if (! empty($results)) {
+                set_dev_attrib($device, 'ipmi_type', $ipmi_type);
+                echo "$ipmi_type ";
+                break;
+            }
+        } catch (\Exception $e) {
+            Log::error('IPMI Discovery error occurred: ' . $e->getMessage());
         }
     }