Rector to PHP 8.0 (librenms#18445)

* Rector PHP8

* Some cleanups and missed ones

* Fix bug found by rector (bad field name)

Author: murrant

LibreNMS/Alert/Template.php

@@ -93,7 +93,7 @@ public function bladeTitle($data)
         $alert['alert'] = new AlertData($data['alert']);
         try {
             return Blade::render($data['title'], $alert);
-        } catch (\Exception $e) {
+        } catch (\Exception) {
             return $data['title'] ?: Blade::render('Template ' . $data['name'], $alert);
         }
     }

LibreNMS/Alert/Transport/Canopsis.php

@@ -28,19 +28,12 @@ public function deliverAlert(array $alert_data): bool
         $ch->exchange_declare($exchange, AMQPExchangeType::TOPIC, false, true, false);
 
         // Create Canopsis event, see: https://github.com/capensis/canopsis/wiki/Event-specification
-        switch ($alert_data['severity']) {
-            case 'ok':
-                $state = 0;
-                break;
-            case 'warning':
-                $state = 2;
-                break;
-            case 'critical':
-                $state = 3;
-                break;
-            default:
-                $state = 0;
-        }
+        $state = match ($alert_data['severity']) {
+            'ok' => 0,
+            'warning' => 2,
+            'critical' => 3,
+            default => 0,
+        };
         $msg_body = [
             'timestamp' => time(),
             'connector' => 'librenms',

LibreNMS/Alert/Transport/Gotify.php

@@ -43,16 +43,11 @@ public function deliverAlert(array $alert_data): bool
          * 4-7 + Sound      = Warning
          * 8-10 + Vibration = Critical
          */
-        switch ($alert_data['severity']) {
-            case 'critical':
-                $priority = 8;
-                break;
-            case 'warning':
-                $priority = 4;
-                break;
-            default:
-                $priority = 0;
-        }
+        $priority = match ($alert_data['severity']) {
+            'critical' => 8,
+            'warning' => 4,
+            default => 0,
+        };
 
         $data = [
             'title' => $alert_data['title'],

LibreNMS/Authentication/ActiveDirectoryAuthorizer.php

@@ -149,7 +149,7 @@ public function getRoles(string $username): array|false
                         }
                     }
                 }
-            } catch (AuthenticationException $e) {
+            } catch (AuthenticationException) {
             }
         }
 

LibreNMS/Authentication/SSOAuthorizer.php

@@ -142,7 +142,7 @@ public function authSSOProxyTrusted()
 
                 // No match, proxy is untrusted
                 return false;
-            } catch (InvalidIpException $e) {
+            } catch (InvalidIpException) {
                 // Webserver is talking nonsense (or, IPv10 has been deployed, or maybe something weird like a domain socket is in use?)
                 return false;
             }

LibreNMS/Component.php

@@ -199,7 +199,7 @@ public function createStatusLogEntry($component_id, $status, $message)
     {
         try {
             return ComponentStatusLog::create(['component_id' => $component_id, 'status' => $status, 'message' => $message])->id;
-        } catch (\Exception $e) {
+        } catch (\Exception) {
             Log::debug('Failed to create component status log');
         }
 

LibreNMS/DB/Eloquent.php

@@ -58,7 +58,7 @@ public static function isConnected(?string $name = null): bool
 
                 return true;
             }
-        } catch (PDOException $e) {
+        } catch (PDOException) {
             return false;
         }
 

LibreNMS/Data/Graphing/GraphImage.php

@@ -28,7 +28,7 @@
 
 use LibreNMS\Enum\ImageFormat;
 
-class GraphImage
+class GraphImage implements \Stringable
 {
     public function __construct(public readonly ImageFormat $format, public readonly string $title, public readonly string $data)
     {
@@ -54,7 +54,7 @@ public function contentType(): string
         return $this->format->contentType();
     }
 
-    public function __toString()
+    public function __toString(): string
     {
         return $this->data;
     }

LibreNMS/Data/Graphing/GraphParameters.php

@@ -33,7 +33,7 @@
 use LibreNMS\Util\Clean;
 use LibreNMS\Util\Time;
 
-class GraphParameters
+class GraphParameters implements \Stringable
 {
     public readonly array $visibleElements;
 

LibreNMS/Data/Source/FpingResponse.php

@@ -33,7 +33,7 @@
 use LibreNMS\Exceptions\FpingUnparsableLine;
 use LibreNMS\RRD\RrdDefinition;
 
-class FpingResponse
+class FpingResponse implements \Stringable
 {
     const SUCESS = 0;
     const UNREACHABLE = 1;
@@ -128,7 +128,7 @@ public function success(): bool
         return $this->exit_code == 0 && $this->loss < 100;
     }
 
-    public function __toString()
+    public function __toString(): string
     {
         $str = "$this->host : xmt/rcv/%loss = $this->transmitted/$this->received/$this->loss%";